Repository navigation
Design note: push-event affected-set baseline (evidence status, chaining gap, stage-1 landing condition) - #7730
Conversation
…er claim Written to outlive #7720 and #7729, because the load-bearing content is not either implementation — it is which claims are observed, which are spec-grounded, and which window each number came from. Every number here is short-window by construction (the events API retains a few hundred events and before is unrecoverable once a push ages out), so an unnamed window would imply a baseline nobody measured. Records, with receipts: the self-compare defect and its three-consumer tell; why the payload beats a minted env channel on section 3 grounds rather than diff size; the per-arm evidence table including the zero-SHA arm being unobserved-and-spec-grounded rather than measured; and two claims that sound right and are not — a non-ancestor before was NOT shown to under-select, and the 'discarded object will be missing so git fails loudly' fallback is false at 9 of 9. The deeper defect and the measurement that flips it: incremental selection is sound only if every prior push was covered, and run conclusion is a bad proxy for floor coverage in BOTH directions — 6 of 15 failure runs had a green floor, and 10 of 10 cancelled runs had a green floor, because cancellation lands after the floor completes. On the right predicate the walk-back to the nearest green floor is 1 for 30 of 39 and never past 6, so a last-green baseline is affordable rather than prohibitive. And the landing condition on stage 1, which is what makes 'the gap becomes observable' true rather than merely plausible: without a counted receipt the gap becomes active and silent instead, since today it is inert only because main pushes select nothing. Declared as a section 4b(3) rung regression with bounded population and restoration trigger. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… 47769) All four findings confirmed by execution against origin/main: - "Filed in DESIGN's recurring-failure-modes list as empty-observation narrow" was present tense about a name that gunbc#7720 proposes and has not merged. Now states the proposal and its open PR explicitly. - dag/tools/merge_admission_stamp.dag is deleted; "already reads GITHUB_EVENT_PATH" cited a module that does not exist. The surviving symbol, tools.merge_admission_walk merge_admission_pr_number_deferred_note, is stronger evidence anyway: its dissolve-on already names the typed payload projection this note proposes, so one projection discharges both consumers. - extdeps.github.push_event does not exist on main or HEAD. Both sites naming it now say it is written by gunbc#7729 and is unresolvable until that lands. The class the reviewer caught is the one this note is about: a citation that reads as current repository state while naming something that is merely intended. Section 3's own evidence-status discipline applies to the note's citations, not only to its measurements. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Review 47769: all four findings confirmed by execution against `origin/main`, and all four fixed in 4364ba0. None was a judgement call — each was decidable by a grep I had not run.
3 & 4. Worth naming the class, because it is the note's own subject: three of these read as current repository state while naming something merely intended, and the fourth named something that used to be true. §3's cite-the-symbol rule exists precisely because a name-level claim is decidable by grep — I applied that discipline to the note's measurements and not to its citations. The intended/actual distinction is now explicit at every site. The — sent from sleek-dove-87 |
Design note for work item
adhoc-b62a4d11-6a6, written to outlive the two PRs it sequences (#7720 receipts, #7729 before-baseline). Doc-only — no code, no carrier edits.The reason it is a note rather than a PR body: the load-bearing content is not either implementation, it is which claims are observed, which are spec-grounded, and which window each number came from. Every measurement here is short-window by construction — the events API retains a few hundred events and
beforeis unrecoverable once a push ages out — so an unnamed window would imply a baseline nobody measured. That distinction decays fastest if it stays in a session's head.What it records
GUNBC_CI_PUSH_BEFOREchannel on §3 grounds — that it is also the smaller diff is a consequence, not the reason.PushEventscan structurally cannot see branch creation.Two claims that sound right and are not, both recorded so nobody re-derives them:
beforewas not shown to under-select.git diff before..headis a full tree comparison; it over-selects after a force-push, which is wasteful, not unsafe.beforeobject present in a full clone.The deeper defect, and the measurement that flips it. Incremental selection is sound only if every prior push was covered, and that chains. Run conclusion is a bad proxy for floor coverage in both directions: 6 of 15 failure runs had a green floor job, and 10 of 10 cancelled runs had a green floor job, because cancellation lands after the floor completes. On the right predicate the walk-back to the nearest green floor is 1 for 30 of 39 and never past 6 — so a last-green baseline is affordable, not prohibitive. The run-level reading implied it reached back past 31 hours, and that reading would have driven the design the other way.
The landing condition on stage 1, which is what makes "the gap becomes observable" true rather than merely plausible: today the chaining gap is inert because main pushes select nothing. The moment before-baseline lands, selection becomes real and the gap becomes real with it — so without a counted receipt the gap does not become observable, it becomes active and silent. Declared as a §4b(3) rung regression with previous rung, temporary rung, reason, bounded population (9 of 39, walk-back never past 6) and restoration trigger.
Also named before it is discovered: a last-green baseline cannot be specified against floor job conclusion, because "the job passed" and "the corpus executed" coincide only while main pushes select nothing — i.e. the before-baseline change itself invalidates the predicate. It has to be specified against the floor having run and its selection having covered that commit.
— sent from sleek-dove-87
Session state (sleek-dove-87, recorded 2026-08-03 for the wind-down)
DONE. The note is complete and the doc-graph registration is verified load-bearing rather than decorative: with the
HandAuthoredDocBindrow removed,doc_graph_has_no_orphan_docsreturnsFAIL; with it, all 7 doc-reachability witnesses PASS (has_no_orphan_docs,hand_authored_slugs_not_registered,works_refs_carry_symbols,bind_identities_unique,slug_wall_reds_on_registered_slug,duplicate_identity_red_control,has_no_dangling_links). The slug was checked against 60 registeredPlan.slugvalues and every existing bind — 0 collisions. All four cited symbols resolve onorigin/main.Review 47769 (REQUEST_CHANGES) is addressed in
4364ba06e04. All four findings confirmed by execution and fixed; see the PR comment for the per-finding verification. The class was the note's own subject turned on itself: three citations read as current repository state while naming something merely intended, and one named a deleted module. Correcting the second improved the argument — the survivingtools.merge_admission_walkmerge_admission_pr_number_deferred_notehas a dissolve-on that already names the typed payload projection this note proposes, so one projection discharges two consumers.CI: all checks COMPLETED and green —
build,regen,heal_generated_artifactsand the floorciare SUCCESS;deploy_dashboard_srv1is SKIPPED. Caveat for whoever merges from this body: the dashboard summary may reportchecks: pending, which is the skipped deploy job being read as pending —gh pr view --json statusCheckRollupshows every check COMPLETED and nothing failing.NOT blocked, and NOT in flight. I am not the builder for #7729 — a duplicate worker (keen-fox-25) was auto-spawned onto the same item and had already built it, so I am the authority on the arms and the evidence status, not the implementation. #7729 stays draft pending the operator's cost call on the last-green baseline. Nothing here waits on me.
Numbers in the note, with their windows (restated because an unqualified number is the thing guaranteed to be misread): the push-event measurements come from the repo events API over
2026-08-02T22:16:00Z .. 2026-08-03T03:26:13Z, 166 push events — 21 to main, 145 to branches. The 9-of-145 force-push figure is about branch pushes, which never reach this arm; main is 0 of 21. The chaining figures (9 of 39, walk-back 1 for 30, max 6) are over floor job conclusions, not run conclusions — that distinction is the correction, and using run conclusions gives 6 of 15 and 10 of 10 false holes.What I would do next if I continued. Nothing on this PR. If the operator green-lights the last-green baseline, the next step is #7729's stage-1 counted receipt for unverifiable predecessor coverage — that is keen-fox-25's build, and the §4b(3) declaration it must satisfy is already written in §5 of this note.