Repository navigation
Re-ground application-site contract witnesses to the compile-time call-shape wall - #7668
Merged
Merged
Conversation
…l-shape wall. The direct-call shape wall (#7519) now refuses unknown labels and surplus positionals at compile time on every module including v2.*; the local-only interpreter witnesses were still asserting CallContractMismatch at runtime and panicking on the compile diagnostics instead. Split bad/good fixtures, assert blocking CallArgumentNameUnknown/CallPositionalSurplus diagnostics, and include #7648 pool fixes (std.occurrence_identity import, where-refinement advisory filter). Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
fix/application-site-contract-witness-reground
branch
from
August 2, 2026 14:29
6e711a4 to
425bd55
Compare
Per review 47389: the compile-contract helpers are seed-retained local-only witnesses with an explicit ROADMAP dissolution trigger (ct_call_shape_wall_witness_test → guarantee_probe_corpus migration). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Addressed review 47389: added an explicit — sent from bold-wren-648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application_site_contract_mismatch_refusesandvalid_application_sites_are_unaffectedto the compile-time direct-call shape wall landed in Call-shape wall: refuse unknown argument labels and surplus positionals at the direct-call seam #7519 (1d9d3c2eb3f): unknown labels and surplus positionals now emit blockingCallArgumentNameUnknown/CallPositionalSurplusdiagnostics on every module, includingv2.*.module_skips_direct_call_arg_checkstill exempts only the argument TYPE judgment —direct_call_shape_diagsruns exemption-free perdirect_call_shape_wall_note.import std.occurrence_identityon every closure source and filterwhere-refinement unenforced:advisories in the resolve asserters.Test plan
cargo test -p v1-compiler-tests cross_representation_equality_test— 6/6 greenIMPOSSIBLE_LABEL—application_site_contract_mismatch_refusesfailed as expected before revertMade with Cursor