Skip to content

v1 seed parser: let/return/for initializers cannot continue onto the next line (missing skip_newlines) - #7564

Merged
briansrls merged 1 commit into
mainfrom
session/quiet-newt-212
Aug 1, 2026
Merged

briansrls merged 1 commit into
mainfrom
session/quiet-newt-212

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Aug 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The v1 seed parser did not call skip_newlines before reading required expressions after =, return, and in, so a newline before the value caused parse failure. This PR adds skip_newlines at those four sites in src/v1/02_parse.dag (typed/untyped let, return, for-in) without widening generic parse_expr entry, keeps the generated seed parser in sync, and enrolls durable floor coverage via src/v1/tests/claim/required_expr_newline_continuation_test.dag plus a seed-side oracle in pipeline.rs.

Test plan

  • cargo test -p v1-compiler-tests let_return_for_initializer_allows_newline_before_expr — ok
  • target/release/regen_stage0 --verify — regen_divergence_count=0
  • CI: build, regen, heal, floor (pending on latest auto-heal commit)

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review August 1, 2026 05:29
@gunbai-bot

gunbai-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Review 46080 (REQUEST_CHANGES — missing regen output): addressed

The finding was correct on ac6cc55: stage0_emit_model.dag registered v1_tests_claim_required_expr_newline_continuation_test.rs but the emitted .rs and lib.rs pub mod were not committed.

Fixed in 7a19c77 (CI auto-heal): emits src/v1/stage0/src/v1_tests_claim_required_expr_newline_continuation_test.rs, adds pub mod v1_tests_claim_required_expr_newline_continuation_test to lib.rs, and syncs the seed parser delta in v1_compiler_parse.rs. Verified locally: regen_stage0 --verify → regen_divergence_count=0.

— sent from quiet-newt-212

@gunbai-bot

gunbai-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Review 46166 (REQUEST_CHANGES — duplicate hand-Rust oracle): addressed in ab3960e

Verified: src/v1/tests/claim/required_expr_newline_continuation_test.dag already exercises all eight accept/refuse rows (untyped/typed let, return, for-in, statement boundary, and the three missing-expression refusals). The pipeline.rs test duplicated that parse surface without a ROADMAP row or shrink receipt on its DeleteWith comment, so it is removed rather than scaffolded.

— sent from quiet-newt-212

@gunbai-bot

gunbai-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Review 46209 (REQUEST_CHANGES — stale dissolve-on scaffold): addressed

The trigger was already satisfied at four sites. Introduced parse_required_expression_after_separator (fn-body =, typed/untyped let, return) and parse_required_expression_no_brace_after_separator (for … in collection); updated the carrier note to name both authorities; regen verified (regen_divergence_count=0).

— sent from quiet-newt-212

@gunbai-bot
gunbai-bot Bot force-pushed the session/quiet-newt-212 branch from 18df586 to a16afa6 Compare August 1, 2026 14:18
@briansrls
briansrls merged commit a79fd0e into main Aug 1, 2026
5 checks passed
@briansrls
briansrls deleted the session/quiet-newt-212 branch August 1, 2026 15:26
gunbai-bot Bot pushed a commit that referenced this pull request Aug 1, 2026
…ven re-stamps dropped

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant