Repository navigation
WalkPlan schedule lens covers success-stage structure - #7521
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap where the schedule lens inspected only the ordinary RealizationPlan while the executor consumed a WalkPlan with a second on-success population.
This change narrows the old function to schedule_lens_verdict_for_ci_floor_ordinary and adds the complete WalkPlan wrapper. The wrapper joins authored batches to the ordinary planner projection, consumes the modeled std.realization_schedule on-success disposition, and compares ordered stage barriers with unordered sibling multisets using full runnable identity. Duplicate identity refuses across the staged population.
The production CI plan now derives its deliberately empty stage roster from gunbc_ci_on_success_stages. A dedicated blocking floor witness replaces the stale AuditOnly/NoConsumerWitness contract metadata. Synthetic nonempty controls execute the complete verdict table, including sibling reorder green and dropped, duplicated, flattened, split, reordered, or inadmissible stages red. Finalization remains deliberately separate under its existing witnesses and strict runtime parser.
Verification:
Sequencing: remains draft until prerequisite #7518 merges, then main will be integrated and the shared std carrier regenerated before ready-for-review.