Repository navigation
r1 surface manager - #739
Merged
Merged
Conversation
# Conflicts: # docs/briefs/r1-surface-manager.md
briansrls
commented
Apr 24, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
81f84883· Trigger:schedule - Thinking:
317s wall
Non-blocking — Strengths
docs/briefs/r1-surface-manager.mdThe brief keeps CharClass phase-2 as a tracked substrate/load-set handoff instead of over-claiming T-Sub closure.
ROADMAP — Verified
- sub_match_over_user_sum: PR #702 is merged and the cited TestClaim, TestRunner, and rustc boundary receipts exist on the PR head.
- sub_type_alias_where_lowers: PR #703 is merged and the cited alias-RHS parse/lower tests exist in m2_feature_parity_test.rs.
- sub_charclass_in_std_unicode_phase_2: PR #693 landed the CharClass tokenizer half, while ValueBody and bootstrap std_fixtures confirm the remaining list/sum top-level data and std.unicode load-set blockers.
✅ No blocking concerns; the docs updates are consistent with the verified receipts and keep the remaining work scoped.
briansrls
marked this pull request as ready for review
April 24, 2026 17:27
briansrls
added a commit
that referenced
this pull request
Apr 24, 2026
Reconcile with main (e.g. r1 surface manager #739); regen only. Made-with: Cursor
briansrls
added a commit
that referenced
this pull request
Apr 24, 2026
PR #739 (r1 surface manager) modified src/v3/compiler/tokenize.dag without refreshing the auto-generated parse_corpus_manifest.txt, leaving main red on parse_stage4_prep::handwritten_parse_snapshot_matches_manifest (item count and byte count match; only the fnv1a64 hash drifted). Regenerated via the command in the manifest header: cargo test -p v3-compiler refresh_handwritten_parse_snapshot_manifest -- --ignored One-line delta (tokenize.dag hash c7f6bac0c8839dac → 9a7718edd277aa93). Unblocks #737 CI; also unblocks main once this lands. Off-lane vs the docs work in the previous commit; included here only because the dashboard flagged the failure as merge-blocking on this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Apr 24, 2026
The `src/v3/compiler/tokenize.dag` entry drifted on main since #744 (PR #739 / #745 CI runs on main also fail this test). Refreshed via `cargo test -p v3-compiler refresh_handwritten_parse_snapshot_manifest -- --ignored` so this PR unblocks and the pending merge queue clears. Ride-along with PR #746 docs-only work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Apr 24, 2026
* WIP: T-PB-B * WIP: T-PB-B * WIP: T-PB-B * WIP: T-PB-B * WIP: T-PB-B * WIP: T-PB-B * chore: refresh parse_corpus_manifest.txt after main-side drift The `src/v3/compiler/tokenize.dag` entry drifted on main since #744 (PR #739 / #745 CI runs on main also fail this test). Refreshed via `cargo test -p v3-compiler refresh_handwritten_parse_snapshot_manifest -- --ignored` so this PR unblocks and the pending merge queue clears. Ride-along with PR #746 docs-only work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened from session-dashboard for session
wise-dove-599.