Skip to content

Retire orphaned DurableApprovalGrantRead HostEffect variant - #7237

Merged
briansrls merged 2 commits into
mainfrom
session/swift-pike-320-durable-approval-read-retirement
Jul 25, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/swift-pike-320-durable-approval-read-retirement

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #7233 (srv3 install/reconcile subgraph retirement): DurableApprovalGrantRead was Record's paired typed-read arm and had zero callers after the §5.D deletions landed on main.

Summary

Remove the orphaned DurableApprovalGrantRead variant and all its realization plumbing — cell type, Filesystem.Read arm, BmcController incompatibility arms, drive directives, uncalled srv3_durable_approval_grant_read_apply(), witness case, and the now-unused srv3_boot_once_approval_grant_path constant.

Test plan

  • gunbc compile --target dag --source-root dag --source-root src/v2 — green (0 diagnostics)
  • git grep DurableApprovalGrantRead across .dag/.rs — empty

Worker attestation

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why.
  • Tests run: gunbc compile --target dag — green.
  • No surprise commits.
  • No secrets / credentials / large binaries staged.

Record's paired typed-read arm had zero callers after §5.D srv3 subgraph
deletion; remove variant, realization arms, uncalled apply fn, and witness case.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot gunbai-bot Bot changed the title srv3 install/reconcile subgraph retirement (shell→dag wave-2, operator GO 2026-07-25): delete the DEAD subgraph + its orphaned HostEffect variants + retained_srvn wraps + srv3 witnesses TOGETHER, one PR. READ docs/plans/shell-to-dag-residual-census-and-arc-completion.md §5.D 'srv3 install/reconcile Retire orphaned DurableApprovalGrantRead HostEffect variant Jul 25, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 25, 2026 19:26
@briansrls
briansrls merged commit 861145a into main Jul 25, 2026
5 checks passed
@briansrls
briansrls deleted the session/swift-pike-320-durable-approval-read-retirement branch July 25, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant