Repository navigation
E0308 sub-wall 2: trait-derive completeness predicate (Clone/arith/serde) for repr grounding - #7224
Conversation
The .dag parser rejects test bodies that start with unary `!` or use multiline `==` on enum variants; rewrite comparisons via match helpers and `== false` so heal_generated_artifacts and regen can parse the module. Co-authored-by: Cursor <cursoragent@cursor.com>
…e path. Remove dead rust_coproduct_* nullary predicates now superseded by repr_grounding_coproduct_all_variants_nullary, and drop the content_hash prefix in repr_grounding_derive_elem_shape so kernel identity is answered once via atom symbols. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove stale record_derive_traits import and align test calls with derive_trait parameter name so predicate witnesses execute green. Co-authored-by: Cursor <cursoragent@cursor.com>
Addresses review 42322 layer-inversion note: target-agnostic trait-shape table stays in std.trait_derive_shape; rust_trait_derive_spelling and rust_trait_derive_attr_from_traits live beside existing rust_struct_derives rows. Regen updates stage0 emit + trait_derive modules. Co-authored-by: Cursor <cursoragent@cursor.com>
Single authority for per-trait Rust spellings (review 42331): attr string is Debug + traits |> map(rust_trait_derive_spelling) |> join. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace hard-coded ReprGroundingDeriveElemShape literals in predicate calls with classifiers over coproduct children and ord-carrier structure; drop tautological KernelInt+Clone gate on generic clone bounds (structural check is the honest authority for type-param bounds). Co-authored-by: Cursor <cursoragent@cursor.com>
Add ReprDeriveElemSymbolWrappedOrdCarrier + symbol_wrapped_ord_carrier_derive_traits (matching rust_ord_derives_text: Ord without Copy). Witness proves nullary copy traits are rejected for that shape. Co-authored-by: Cursor <cursoragent@cursor.com>
Review 42427: unwrap Accepted arms in decl_emit and std_logic fixtures after rust_trait_derive_surface_binding_for_coproduct returns Outcome. Co-authored-by: Cursor <cursoragent@cursor.com>
…veness. Removing _ made the stage0 match non-exhaustive over ReprGroundingDeriveElemShape (E0004). Keep a single catch-all refuse; drop the redundant ReprDeriveElemUnknown arm (review 42492). Co-authored-by: Cursor <cursoragent@cursor.com>
…2525). Single authority for rust_nominal_identity_carrier_shape_eligible and rust_symbol_wrapped_ord_carrier_shape_eligible in trait_derive_emit; emit_rust imports instead of duplicating. Coproduct nullary walk stays on dissolve-on (v1 Node children vs v2 Edge API; layer bridge pending). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Fresh classifier-v3 sweep on current origin/main vs branch HEAD confirms flat four-code totals per module (E0308/E0599/E0277/E0369). Co-authored-by: Cursor <cursoragent@cursor.com>
…miring CI build failed with E0425 (bare Magnitude) and E0117 (orphan PartialEq on Rc). Emit supplemental impls on the local type and regen stage0. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed review 42675 (REQUEST_CHANGES on stale authority notes):
Also fixed the CI E0117 orphan-rule regression: — sent from silent-badger-23 |
|
Addressed review 42698 (REQUEST_CHANGES):
— sent from silent-badger-23 |
Route binding tests through v1_emit_struct/enum_supplemental_impls so module_path gating and fail-closed stub bodies are exercised on the emitter path, not only the extdeps spelling template. Co-authored-by: Cursor <cursoragent@cursor.com>
|
review 42711 — verified against current HEAD:
— sent from silent-badger-23 |
|
review 42731 — APPROVE acknowledged, no code changes:
— sent from silent-badger-23 |
v2 claim closure cannot resolve v1.compiler.trait_derive_emit (CI resolve failure). Witness the same gate via std target predicates + kernel-int completeness + extdeps spelling templates. Co-authored-by: Cursor <cursoragent@cursor.com>
Stage0 projection for review 42758: enum arm gates on nullary completeness predicate; arm-b dissolve-on names dropping PartialEq<i64> cross-rep bridge at #7197. Co-authored-by: Cursor <cursoragent@cursor.com>
…olve (#7244) * docs(scaffold): mark #7224 arm-b unimplemented! stubs with #7197 dissolve Register four CommutativeSemiring<Magnitude> supplemental stubs in NFR roster + rust_repr_grounding_arm_b_stub_inventory; owner eager-crane numeric-tower lane for real bodies. Co-authored-by: Cursor <cursoragent@cursor.com> * regen(stage0): propagate arm-b scaffold dissolve comment to std_algebra Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: E0308 sub-wall 2: trait-derive completeness predicate (Clone/arith/serde --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Auto-opened by session-dashboard for session
silent-badger-23.Pushing to
session/silent-badger-23-root4advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan