Repository navigation
Dissolve std.baseboard's minted BaseboardManufacturer onto Vendor<Domain> - #7189
Merged
Merged
Conversation
…ain> std.baseboard re-coined ASRock Rack as a freshly-minted single-variant BaseboardManufacturer enum instead of citing it on the single Vendor<Domain> authority (DESIGN §3), and std cannot import extdeps.vendor (layer DAG points toward std), so the whole baseboard domain model — BaseboardModel, BaseboardCatalogRow, ServerBaseboard — moves to extdeps/boards/types.dag beside its cited catalog row, matching the CpuModelCatalogRow/GpuFacts precedent (vendor is a plain Vendor<Hardware> field, not a derived-by-match enum). Adds extdeps/vendor/asrock_rack.dag as the cited entity. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gunbai-bot
Bot
force-pushed
the
session/keen-bat-128
branch
from
July 25, 2026 00:45
00034c1 to
c5c7f66
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std.baseboardre-coined ASRock Rack as a freshly-minted single-variantBaseboardManufacturerenum (dispatched via a match fn) instead of citing iton the single
Vendor<Domain>authority (DESIGN §3) all other hardwarevendors already ground on (
Vendor<Hardware>— seeCpuModelCatalogRow,GpuFacts,DramModuleCatalogRow). Perdocs/plans/extdeps-std-grounding-inventory.md§1/§2 this is an s3-fork.Because
stdcannot importextdeps.vendor(the layer DAG points importstoward
std, never away from it), grounding the vendor field forces thewhole baseboard domain shape —
BaseboardModel,BaseboardCatalogRow,ServerBaseboard— out ofstd/baseboard.dagand intoextdeps/boards/types.dag, matching the existing CPU/GPU/DRAM precedentwhere the catalog-row shape lives in
extdepsbeside its cited vendor rows,and
stdkeeps only the frameworks (measure,types) those shapes buildon.
BaseboardCatalogRow.vendoris now a plainVendor<Hardware>field(cited
extdeps/vendor/asrock_rack.dag), not a derived-by-match enum —dropping
BaseboardManufacturerandbaseboard_manufacturer()entirely.Consumers updated:
dag/extdeps/boards/asrock_rack.dag(catalog row nowcarries
vendor: asrock_rack),dag/gunbc/fleet_intent.dag(importrepointed),
dag/test/claim/bmc_factory_credential_witness_test.dag(assertion now compares
.catalog.vendoragainst the cited vendor entityinstead of matching the deleted enum).
Test plan
claim_batch --source-root dag --source-root src/v2 --entry dag/test/claim/bmc_factory_credential_witness_test.dag --function bmc_factory_credential_holds→PASS bmc_factory_credential_holds(green-by-execution, exercises the newvendorfield end to end).claim_batch ... --entry dag/test/claim/fleet_intent_network_witness_test.dag --function fleet_intent_network_container_to_bmc_allowed→PASS(provesfleet_intent.dag'sServerBaseboardconsumers, incl.srv1_baseboard..srv4_baseboard, still resolve and compile clean against the moved module).cargo build -p v1-compiler --bin claim_executor/--bin claim_batch→ clean.