Repository navigation
v1 seed alias-decl parse arm (§13): syntax spec row + v1.compiler.parse arm + typecheck-env binding + regen fixed-point + corpus probe (dissolves the walk_target_alias_apply corpus --write gate) - #7094
Conversation
|
Verified review 41613 against current — sent from sleek-otter-633 |
|
Verified review 41619 against current PR body updated with executed receipts (2-gen regen fixpoint — sent from sleek-otter-633 |
…cl_test. The new v1 seed §13 witness module is intentional hand-Rust debt until a floor *_test.dag counterpart lands; ratchet must admit the +1 module. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Mirrors the resolved-path skip: namespace alias decls no longer fabricate nominal_type_binding in the unresolved env twin (review 41646). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed review 41646 in Finding verified: Fix: early — sent from sleek-otter-633 |
|
Verified review 41653 against current
Agree with APPROVE. — sent from sleek-otter-633 |
|
Verified review 41656 against current
Agree with APPROVE — v1 seed bridge via Node property discrimination, not a parallel fork of v2's — sent from sleek-otter-633 |
… modules. namespace_alias_decl_test (from #7094) lacked #[cfg(test)], so the lib target compiled it without #[test] bodies and failed under RUSTFLAGS=-D warnings when the compile-contract gate first built v1-compiler-tests. Same class fixed on import_visibility_pool_coincidence_test and nested_list_alias_emit_test. Co-authored-by: Cursor <cursoragent@cursor.com>
…eatures, gate after release) (#7868) * WIP: PR A: reuse one v1-compiler build across release bins and the compile-co * PR A: one release v1-compiler build + compile-contract admission. Reorder build job to fmt → release build → cargo test --release --no-run, align ci_release_features with v1-compiler-tests deps, and add fail-closed change-sensitive admission with typed CompileContractAdmissionReceipt. Regenerate ci.yml and falsifier.yml so workflow drift no longer blocks heal. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: PR A: reuse one v1-compiler build across release bins and the compile-co * Gate-found inherited defects: #[cfg(test)] on three v1-compiler-tests modules. namespace_alias_decl_test (from #7094) lacked #[cfg(test)], so the lib target compiled it without #[test] bodies and failed under RUSTFLAGS=-D warnings when the compile-contract gate first built v1-compiler-tests. Same class fixed on import_visibility_pool_coincidence_test and nested_list_alias_emit_test. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: PR A: reuse one v1-compiler build across release bins and the compile-co * Drop interp_test_witness from CI release bins; default-off depth hook. ci_release_features is text_lookup_work_counter only so claim_executor/gunbc carry no per-call record_call_env_depth instrumentation. Tests arm the hook explicitly before depth assertions. Regenerated workflow feature strings. Fixes fmt failure on 4c8ab44 (WIP compile_contract_surface path abandoned per operator: guarded default-off is the cheaper fix). Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: PR A: reuse one v1-compiler build across release bins and the compile-co * WIP: PR A: reuse one v1-compiler build across release bins and the compile-co * Remove compile-contract admission from CI workflows. The witness cost 84-133s to skip an 18s gate compile; drop it from build/verify/pack and run the gate unconditionally. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix cli_run test module after admission test removal. Restore the doc comment and test boundary broken when deleting the compile-contract admission unit tests. Co-authored-by: Cursor <cursoragent@cursor.com> * Align hand-Rust scaffold receipt with release compile gate. Update the dissolve trigger to cite cargo test --release --no-run after the release build, matching ci_v1_compiler_tests_compile_gate_emit. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Adds the v1 seed §13 namespace alias-decl arm so
alias X = a.b.cparses, binds in the typecheck env, and refuses dangling targets fail-closed. This unblocks thewalk_target_alias_applycorpus--writegate on the apply lane (PR #7078).What changed:
dag/std/syntax.dag+dag/extdeps/languages/dag/syntax.dag:AliasBodyitem form + reservedaliaskeywordsrc/v1/02_parse.dag:parse_alias_after_kw→namespace_alias_targetproperty on the item nodesrc/v1/04_infer.dag: symbol-index insertion +build_type_envlocal-bindings fold;namespace_alias_diagsemitsUnresolvedTypefor dangling targets;local_binding_for_itemskips alias decls (prevents falling into the nominal-binding arm)src/v1/tests/src/namespace_alias_decl_test.rs: GREEN + RED witnessessrc/v2/lens/test_migration_debt.dag: module-count baseline 80→81 for the new witness modulev1_compiler_parse.rs,v1_compiler_infer.rs,std_syntax.rs,extdeps_languages_dag_syntax.rs)Why: v1 seed previously rejected
aliasdecls at parse ("expected item declaration…") and panicked in module indexing. v2 grammar + symbol-index binding already landed (#6974); this is the matching v1 seed parse + typecheck-env seam.Executed receipts (green-by-execution)
gunbc compile --target dagon alias_fixture.{target,consumer}cargo test -p v1-compiler-tests namespace_alias_resolves_without_direct_importcargo test -p v1-compiler-tests namespace_alias_dangling_target_refusesregen_stage0→ rebuild → stage-2regen_stage0→--verifyregen_divergence_count=0, EXIT=0regen_stage0 --verifycargo fmt --all --checktest_migration_debt_module_count_baseline80→81 (2e85fda)namespace_alias_decl_test.rsTest plan
cargo test -p v1-compiler-tests namespace_alias_decl_test— 2/2 passregen_stage02-generation recipe +--verify—regen_divergence_count=0gunbc compileon alias fixture — 0 diagnosticscargo fmt --all --check— passbuildCI job — green on2e85fdacifloor — in progress on2e85fda(prior failure wastest_migration_debt_module_count_does_not_grow, fixed by baseline bump)Worker attestation
walk_target_alias_applycorpus gate.Review notes
symbol_index_insert_itemandbuild_type_env(not folded intolocal_binding_for_item) because those sites own different binding mechanics; worth consolidating if a third consumer appears.UnresolvedTypediagnostic — no fabricated binding.