Repository navigation
floor: precompute both-closure edges to dissolve per-entry bare-ref fixpoint - #7056
Merged
Merged
Conversation
briansrls
force-pushed
the
session/nimble-moth-292
branch
from
July 22, 2026 05:16
8defbc4 to
b8a22c5
Compare
gunbai-bot
Bot
changed the title
…ixpoint #6848's extend_sources_to_both_closure_fixpoint re-scanned every pool module's text and re-queried the census on each discovery entry (~140ms × ~2100 witnesses, ~5min batch-2 residual after #6999). Build a lazy BothClosureEdgeIndex once per MultiEntryIndex process; per-entry loads become graph BFS over precomputed edges. Rebased on main (#7045 bare_identifier_candidates binding tests retained). Oracle: both_closure_edge_index_built_once_per_pool Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
force-pushed
the
session/nimble-moth-292
branch
from
July 22, 2026 13:10
2d019f5 to
9ad2388
Compare
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/plans/floor-time-namespace-walk-regression-diagnosis.md§5).BothClosureEdgeIndexonce perMultiEntryIndexprocess: per-module bare/reference pull targets are computed at index-build time, then each entry'sextend_sources_to_both_closure_fixpointbecomes graph BFS over those edges instead of re-scanning text and re-querying the census (~140ms/witness × ~2100 entries).Test plan
ctrl-build -- cargo test -p v1-compiler-tests both_closure_edge -- --test-threads=1— PASS (41s)