Repository navigation
fix(ci): run doc-graph wall on docs-only PRs — retire documentation_only_skip bypass (#7023) - #7039
Merged
Merged
Conversation
…-doc-reachability-floor
…-doc-reachability-floor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosis (#7023): The doc-reachability witness was not misclassified —
dag/test/claim/doc_reachability_witness_test.dagalready declaresReadsLiveTree(since #6654). The escape was floor admission bypass: thedocumentation_only_skipshell shortcut ingunbc.ci_specexited beforeclaim_executor, so selection never ran and the never-predict-skip lane never engaged. Verified by execution:compile_clean_floor_skip_witnessreturnsdocumentation_only_skipon a docs-only injected diff.Fix (no hand selection edge): Remove the docs-only floor shortcut. Docs-only PRs now run the normal floor (
SelectionApplied); import-closure skips non-live-tree witnesses cheaply;ReadsLiveTreerows (doc-graph wall, corpus-read host-fed lenses) always run via the existing fail-closed lane.RED control:
floor_skip_discovery_witnessaddsdoc_reachability_runs_on_docs_only_diffanddoc_reachability_never_predicted_unaffected_on_docs_only_diff— proves by execution that a docs-only diff RUNS the doc-graph witness (skipped=0).Broader audit (report only — not fixed here)
Census of
SubstrateInputsOnlydiscovery entries with host-read builtin signals: 3 rows (none are doc-reachability):dag/test/claim/typed_witness_invocation_test.dag(WitnessBin.Run)src/v2/test/claim/extdeps_external_authority/corpus/live_clean_tree_anchor_drop_red_test.dagsrc/v2/test/claim/long/live_anchored_modules_clean_test.dagDurable fix for the class belongs to the module-identity-storage-binding lane (effect-reach census → derived
ReadsLiveTree).Falsifier backstop
The nightly falsifier runs the full floor cold (no
documentation_only_skipshortcut). #7023's orphan was caught on the merged-with-main floor (#7035), not on PR CI — confirming the falsifier works but PR CI was the gap this PR closes. No falsifier prediction-gap finding (the bypass prevented selection from running at all; falsifier would not have diverged on a row that never entered the corpus).Test plan
ctrl-build -- cargo build -p v1-compiler --release --bin floor_skip_discovery_witness && ./target/release/floor_skip_discovery_witness— all tests green (including new doc-reachability docs-only controls)ci.ymlupdated to matchgunbc.ci_specemission (documentation_only_skip block removed)