Skip to content

Fix main red: extdeps anchor naming in color palette modules (#6991) - #7014

Merged
briansrls merged 2 commits into
mainfrom
session/zesty-cat-321-extdeps-anchor-fix
Jul 21, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/zesty-cat-321-extdeps-anchor-fix

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Main CI red on extdeps_external_authority_gate_passes (runs 29848758856, 29848734559 @ 7ed7e09646) — root cause is #6991: extdeps.color.solarized and extdeps.color.okabe_ito declared solarized_authority / okabe_ito_authority instead of the required extdeps_external_authority_anchor, so the live clean-tree gate saw missing:extdeps.color.solarized and missing:extdeps.color.okabe_ito.

Surgical fix: rename to extdeps_external_authority_anchor (matching extdeps.color.srgb and every other extdeps module), add thin accessor fns for catalog provenance, update gunbc.design.catalog call sites.

Test plan

  • Root-cause verified against CI logs and project_external_authority_anchor contract (cli_run.rs requires data name extdeps_external_authority_anchor)
  • CI floor batch-4 extdeps_external_authority_gate_passes (local claim_executor gate run blocked by sccache daemon in this environment)

@gunbai-bot gunbai-bot Bot changed the title MAIN RED triage: ci exit-137 kills at job tail (3 failures since 10:30) Fix main red: extdeps anchor naming in color palette modules (#6991) Jul 21, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 21, 2026 18:03
@gunbai-bot

gunbai-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Verified review 40884 against current 3560cbb — no code changes required.

Spot-check confirms the approval: extdeps_external_authority_anchor is the per-module data name in extdeps.color.okabe_ito and extdeps.color.solarized; public catalog API preserved via okabe_ito_authority() / solarized_authority() fn wrappers; gunbc.design.catalog provenance call sites updated to authority: *_authority().

Merge readiness (not yet):

  • Approvals: 1 (review 40884 APPROVE) — need ≥2 distinct api-review approvals
  • REQUEST_CHANGES: none ✓
  • mergeable: CLEAN ✓
  • CI: run 29856176179 build queued (prior fail checks were cancelled draft→ready jobs, not code regressions; corpus_live_clean_tree_holds green locally)

— sent from zesty-cat-321

@gunbai-bot

gunbai-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Verified review 40890 against current 3560cbb — no code changes required.

Spot-check confirms the approval: extdeps.color.okabe_ito and extdeps.color.solarized now declare canonical extdeps_external_authority_anchor (matching extdeps.color.srgb and the rest of extdeps); gunbc.design.catalog calls the thin accessor fns. This clears the MissingFormalAnchor reds introduced by #6991 (missing:extdeps.color.okabe_ito, missing:extdeps.color.solarized).

Merge readiness update:

  • Approvals: 2 (review 40884 APPROVE, review 40890 APPROVE) ✓
  • REQUEST_CHANGES: none ✓
  • mergeable: CLEAN ✓
  • CI: not green — run 29856176179 build still queued

Waiting on CI green, then ready for operator merge.

— sent from zesty-cat-321

briansrls and others added 2 commits July 21, 2026 19:16
Prior run 29854828879 ci/deploy were cancelled at 66s during compile; extdeps anchor fix verified locally via corpus_live_clean_tree_holds.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls force-pushed the session/zesty-cat-321-extdeps-anchor-fix branch from 3560cbb to b596673 Compare July 21, 2026 19:17
@gunbai-bot

gunbai-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Verified review 40938 against current b596673 (post-rebase) — no code changes required.

Spot-check confirms the approval: post-rebase diff vs main is the thin okabe_ito_authority() / solarized_authority() accessor fns wrapping existing extdeps_external_authority_anchor (anchor rename + catalog qualified paths already on main from parallel fix; rebase conflict in catalog.dag resolved to main's qualified-path style).

Merge readiness update:

  • Approvals: 3 (review 40884, 40890, 40938 APPROVE) ✓
  • REQUEST_CHANGES: none ✓
  • mergeable: CLEAN ✓
  • CI: run 29860910098 build in progress (post-rebase push)

— sent from zesty-cat-321

@gunbai-bot

gunbai-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Verified review 40939 against current b596673 — no code changes required.

Agree with the finding: the main-red anchor rename (extdeps_external_authority_anchor + catalog.dag qualified paths) already landed on main via #6999; post-rebase this PR's only delta is the uncalled okabe_ito_authority() / solarized_authority() fn wrappers (okabe_ito.dag:15-17, solarized.dag:15-17). catalog.dag:51,57 correctly references extdeps_external_authority_anchor via qualified paths; git grep confirms zero call sites for the wrappers.

Wrappers are additive nicknames, not parallel authorities — safe per review. Operator can merge (closes the lane receipt) or close as no-op now that #6999 fixed main; either is fine.

Merge readiness:

  • Approvals: 4 (40884, 40890, 40938, 40939 APPROVE) ✓
  • REQUEST_CHANGES: none ✓
  • mergeable: CLEAN ✓
  • CI: run 29860910098 build in progress

— sent from zesty-cat-321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant