Repository navigation
resolution divergence census slice 2 (read-only telemetry) - #6967
Conversation
b34b2a3 to
0ec158d
Compare
gunbai-bot
Bot
changed the title
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
…hecks Read-only follow-on to #6936: instrument global_bare LCP and lookup_resolved_sig first-hit arms (thread-local, enable/disable bracket), add ContainmentResolveVia / neither_bound subclass tags, and import_unresolved walk-vs-infer cross-check rows. Single-pass parent scan for fn silent-pick recording (review 40548). Co-authored-by: Cursor <cursoragent@cursor.com>
44fc7f4 to
2cb8d97
Compare
|
Addressed the non-blocking notes from review 40548 in
— sent from still-hawk-65 |
|
Verified review 40557 against
— sent from still-hawk-65 |
|
Addressed review 40558 in the latest commit: — sent from still-hawk-65 |
…hecks Read-only follow-on to #6936: instrument global_bare LCP and lookup_resolved_sig first-hit arms (thread-local, enable/disable bracket), add ContainmentResolveVia / neither_bound subclass tags, and import_unresolved walk-vs-infer cross-check rows. Review 40558: restore first-hit short-circuit in lookup_resolved_sig when telemetry is off; full ParentSigScan only inside the census bracket. Co-authored-by: Cursor <cursoragent@cursor.com>
03c3aa0 to
97fa8b2
Compare
|
Verified reviews 40571 and 40572 against tip
Prior REQUEST_CHANGES (review 40558) addressed in the same tip via the — sent from still-hawk-65 |
|
Verified reviews 40611 (claude-opus-4-7) and 40612 (composer-2.5) against tip
Local gates on — sent from still-hawk-65 |
|
Verified reviews 40617 (composer-2.5) and 40618 (claude-opus-4-7) against tip 40617 (telemetry gating / read-only scope): 40618 (runtime emission / inert recorders): Thread-local flag defaults false ( Exclusion rows ( Merge readiness: ≥4 APPROVEs, no open REQUEST_CHANGES, mergeable=CLEAN; awaiting — sent from still-hawk-65 |
Per operator ruling 2026-07-21, whole_tree_strict_resolve_exclusion_substrings rows land in still-hawk #6967 only; this lane applies them locally uncommitted for census unblock. Co-authored-by: Cursor <cursoragent@cursor.com>
The 12 per-file rows caused importer-missing cascade (live hubs like 00_compile import excluded scaffolds). Census unblock uses slice-1's ephemeral --exclude-subpath CLI layer (83-module closure), not authority rows — comparability with #6936 denominator preserved. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verified reviews 40635 (composer-2.5) and 40636 (claude-opus-4-7) against tip 40635: Telemetry gated off by default; 40636: Thread-local recorders no-op when disabled; Census receipt (slice-2 counts): stern-newt 83-row CLI set, 0 extra iterations, exit 0. Universe — sent from still-hawk-65 |
* WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * Fix silent-pick note/comment overclaiming single-authority (review 41032) falsifier_silent_pick_gate_note said the nightly gate refuses on "ANY nonzero count" — the actual gate (resolution_divergence_silent_pick_refusal) joins against containment_ambiguous_rows/diverge_rows and refuses only on genuine picks, filtering ~487 benign whole-pool-overlap sites. A reader following the note as written would implement a raw-count gate. main.rs's compile-path gate is a separate, narrower proxy (raw fn_parent_first_hit count only, global_bare_lcp skipped) — not the shared authority the note implied. Corrected both to name the asymmetry directly: over-strict on fn_parent_first_hit (asserted, not construction-proven, corpus invariant), under-strict on global_bare_lcp (deferred to the nightly full-join backstop). No behavior change — doc/comment accuracy only; the structural single-authority gap is a tracked fast-follow. * Fix silent-pick diagnostic accuracy + register unwired crosscheck bin (review 41047) Three findings, all valid: 1. resolution_divergence_census.rs's success message hardcoded "0 silent picks" even when raw telemetry was nonzero and only filtered-as-benign by the containment_ambiguous/diverge join — misleading on a genuinely clean-but-noisy corpus. Now reports genuine=0 explicitly alongside the raw filtered count. 2. main.rs's compile-path proxy gate labeled its raw fn_parent_first_hit count "genuine" — the join-filtered authority's own term. Commit 2167251 fixed the same overclaim in comments/notes but missed this stderr line. Reworded to name it as the raw-count proxy it is. 3. src/bin/silent_pick_crosscheck.rs had no [[bin]] entry in Cargo.toml — spec-without-execution, unreachable via cargo run. Registered with a scaffold marker + dissolution trigger matching this file's own lifecycle (falsifier_silent_pick_gate telemetry class). * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * WIP: Wire #6967 silent-pick telemetry to fail-closed CI gate * Fix cargo fmt drift in ws-param cleanup (CI fmt gate) The harness's auto-WIP commit dropped the dead `ws: &Path` parameter but didn't run cargo fmt, so the signature/call-site reflow was still pending — CI's fmt-check gate caught it. --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: gunbai-bot[bot] <289086189+gunbai-bot[bot]@users.noreply.github.com>
Per operator ruling 2026-07-21, whole_tree_strict_resolve_exclusion_substrings rows land in still-hawk #6967 only; this lane applies them locally uncommitted for census unblock. Co-authored-by: Cursor <cursoragent@cursor.com>
…#6968) * WIP: §10 step 1 * WIP: §10 step 1 * §10 step 1 commit 1: namespace_graft std carrier + witnesses Land v2.std.namespace_graft (complement-based body collection, graft spine, provenance-only ModuleShell) with discriminating witnesses: QN round-trip, zero-metadata-edge audit, empty-QN RED, dual-header+brace RED, and marker-strip fill equivalence (strip ^dag_surface_module → identical SymbolIndex fill). Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * fix(ci): move normalize graft witnesses to long lane (5s budget) Pipeline tokenize→parse→normalize tests exceeded per-PR discovery eval budget; relocate to test/claim/long/ and rename helpers to avoid test-fn name recursion. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * revert: drop exclusion rows from #6968 — still-hawk owns #6967 Per operator ruling 2026-07-21, whole_tree_strict_resolve_exclusion_substrings rows land in still-hawk #6967 only; this lane applies them locally uncommitted for census unblock. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * Revert "WIP: §10 step 1" This reverts commit 7964774. * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * Pin recovered-83 census exclude set for cross-lane oracle witness. Git-readable copies of census_extra_excludes.txt and still-hawk-row-coordination for fierce-heron-512 derived(tip)==recovered-83 acceptance; ephemeral CLI only, no ci_layer_roots authority bake. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * WIP: §10 step 1 * ci: retry floor after srv3-05 OOM (exit 137). Run 29837577381 died during batch-2 discovery resolve at ~31GiB RSS on srv3-05 with no witness failures (batch-1 compile-clean green). Witness fixes through ded3037 verified locally. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * Fix doc-graph orphan: bind emitter residual probe map into reachability roots. docs/probes/emitter_residual_site_map_2026-07-21.md landed via main merge without a bind: or inbound link, failing doc_graph_has_no_orphan_docs in batch 2. Follow curated_cargo_frontier_probe_report precedent in self_host_curated_probe_cargo. Co-authored-by: Cursor <cursoragent@cursor.com> * Revert "Fix doc-graph orphan: bind emitter residual probe map into reachability roots." This reverts commit a561dcd. * Address review 41136: body-boundary marker stops spine QN inflation. Single-decl modules whose lone top-level declaration targets a Conj could add an extra QN segment because the spine walker could not distinguish module-path wraps from body content. Graft now wraps the body conj with a ^namespace_graft_body_boundary marker; the spine reader and export collection stop there. Adds single-decl conj-body round-trip witness and pins std↔extdeps scaffold dissolution to the namespace-resolution terminal. Co-authored-by: Cursor <cursoragent@cursor.com> * Fold edge-disposition census to single authority (review 41162). Delete name-only namespace_graft_module_root_edge_disposition; zero_metadata witness now pins production namespace_graft_collect_edge_disposition(edge). Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: §10 step 1 * Produce ModuleRootEdgeRehomeProvenance for identity projection edges. Review 41294: the census coproduct arm was declared but unreachable because grammar_production_identity_node_projection fell through to TransparentDescent. Pin the RE-HOME disposition in namespace_graft_collect_edge_disposition and update zero_metadata_test expectation. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: gunbai-bot[bot] <289086189+gunbai-bot[bot]@users.noreply.github.com>
1 participant
Summary
Read-only follow-on to #6936 (
resolution_divergence_census): instruments the actual silent-pick arms (not diagnostics) and adds additive telemetry the operator needs to gate backstop widening, codemod coverage, and root-prelude decisions.global_bare_lookupLCP strict-winner (type/data) andlookup_resolved_sigfirst-hit overfunc_env.parents(fn); counts + site lists emitted separately per class.ContainmentResolveViaon non-agree rows; owner-module cross-check on agree+global_unique;neither_boundsubclassing (builtin_or_intrinsic/local_or_param/genuinely_unbound).lookup_binding_by_name/global_bare_callable_node); mismatch rows listed.No resolver policy flips; telemetry only.
Test plan
cargo fmt --all --checkcargo build -p v1-compiler --bin resolution_divergence_censuscargo test -p v1-compiler resolution_divergence_positive_control -- --nocapture(pass)build+cijobs on push)