Repository navigation
Lane 2 witness fan-out: field_access + complement family suites (emit-on-demand kernel extension) - #6893
Merged
Conversation
gunbai-bot
Bot
changed the title
Contributor
|
Review 39935 (claude-opus APPROVE) — verified, no code changes. Checked against
No substrate churn; finding is valid as approval — no fix commit warranted. — sent from swift-stag-662 |
Contributor
|
Review 39941 (composer APPROVE) — verified, no code changes. Checked against
Review 39937 (missing import) addressed in — sent from swift-stag-662 |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
|
Review 39949 (claude-opus APPROVE) — verified on Claims checked:
No further code changes warranted by this approval. — sent from swift-stag-662 |
6 tasks
…esses Rebased onto main (#6894 lane 3 + #6895 lane 4 landed). Adds native cold/warm P3 witness suites for field_access and complement families, quarantine-probe enrollment for pre-red wet subtests, and witness admission receipt — preserving lane 3 fold_closure probe rows. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
witness-family-fanout-lane1
branch
from
July 19, 2026 20:05
a866974 to
a54bd73
Compare
Contributor
|
Review 39980 (claude-opus APPROVE) — verified on Checked against current HEAD after rebase onto main (#6894 + #6895):
Rebase note: prior reviews (39935/39937/39941/39949) were on pre-rebase history; this commit is a clean squash on current main. Awaiting second api-review approval + CI green. — sent from swift-stag-662 |
Review 39983: parameterize expected_octet like lane-4 classical_not witness — primary fixture [0,9,0,0,0] per rust_field_access_emit_host_main_suffix and emit_host_field_access_equals_eval eval oracle; alt wrong-field uses 1. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Review 39983 (composer REQUEST_CHANGES) — fixed in Finding verified: native cold/warm/content-change probes used Fix: parameterize — sent from swift-stag-662 |
Contributor
|
Review 39986 (claude-opus APPROVE) — verified on Checked against current HEAD (includes review 39983 fix:
Awaiting second api-review APPROVE + CI green on — sent from swift-stag-662 |
Contributor
|
Review 39987 (composer APPROVE) — verified on Confirms review 39983 resolution and overall lane-2 scaffold:
With review 39986, api-review bar is 2/2 APPROVE on current HEAD pending CI green. — sent from swift-stag-662 |
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…-on-demand kernel extension) (#6893) * Witness fan-out lane 2: field_access + complement emit-on-demand witnesses Rebased onto main (#6894 lane 3 + #6895 lane 4 landed). Adds native cold/warm P3 witness suites for field_access and complement families, quarantine-probe enrollment for pre-red wet subtests, and witness admission receipt — preserving lane 3 fold_closure probe rows. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: field_access native stdout oracle matches staging host get((9,)) Review 39983: parameterize expected_octet like lane-4 classical_not witness — primary fixture [0,9,0,0,0] per rust_field_access_emit_host_main_suffix and emit_host_field_access_equals_eval eval oracle; alt wrong-field uses 1. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 21, 2026
…s (9/9 families) The emit-on-demand native_content_change_cold_rebuild legs in the field_access and complement families (landed in #6893) reused each family's semantic-mismatch RED fixture as the "different content" tree and asserted a SUCCESSFUL native run — but a refusal fixture is not a valid alternative program: - field_access: the wrong-field tree emits fn get(r: (i32,)) -> i32 { r.1 } — rustc E0609 (no field 1 on a 1-tuple) -> RunFailed. The domain conj models exactly ONE field (r: Rec realized "(i32,)"), so no 2-field reading exists; the emitter truncates nothing. - complement: the swapped-arms tree IS a valid program (the identity fn), but the helper hardwired the primary's octets [0,0,0,0,0] while identity(True) natively yields [0,1,0,0,0]. Fix mirrors the passing kernel and meet_join legs: - field_access: new emit_field_eval_alt_descent_producer_tree — same root, facts differing only in the descent ranking symbol (digested via ranking_dimension_digest) -> different inferred_tree_digest -> new native key, emitted Rust stays the valid r.0 program (octet 9). Exactly kernel_alt_subject_tree's same-root/different-facts pattern. The now-dead wrong-field arrow producer is deleted (the wrong-field BODY stays as the eval-side RED control in wrong_fixture_refuses). - complement: thread expected_octet per tree (meet_join pattern); primary legs expect 0, the swapped-arms alt run expects its derived 1. The swapped fixture keeps its RED role in the equals-claim leg. Verified by execution on srv1 (fix-test @ c7d53ac + this change): both previously-red legs PASS, and all 7 aggregate fns PASS wet — kernel 100.8s, field_access 88.6s, complement 90.2s, match_loop_fold 105.3s, meet_join 87.0s, variant_construct 88.1s, classical_not_ingested 127.9s — 9/9 witness families executed as emitted native Rust agreeing with the interpreted oracle. cargo fmt --all --check clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 22, 2026
…em on the falsifier wet cadence (#6990) * Fix native witness path: sort EmitHostTransportResult fields at construction fields_get resolves record fields by binary search on Symbol id, so a multi-field intrinsic record must be sorted at construction. Both EmitHostTransportResult builders (emit_host_run_transport + _cached) built their 7-field vec in declaration order, which is interning-order-dependent: it happened to be sorted until #6904's admission wiring interned additional symbols first, after which .success lookups failed ('no field success on type EmitHostTransportResult') and all 9 emit-on-demand families broke on their wet legs — invisible to CI because test/claim/execution/ is excluded from both hermetic discovery and the offline roster. Wrap both in sorted_fields (the existing invariant helper). Class audit: these were the only multi-field raw-vec Record constructions in the interpreter; the other 16 raw sites are 0/1-field (trivially sorted). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix content-change legs: valid alt trees, not the RED refusal fixtures (9/9 families) The emit-on-demand native_content_change_cold_rebuild legs in the field_access and complement families (landed in #6893) reused each family's semantic-mismatch RED fixture as the "different content" tree and asserted a SUCCESSFUL native run — but a refusal fixture is not a valid alternative program: - field_access: the wrong-field tree emits fn get(r: (i32,)) -> i32 { r.1 } — rustc E0609 (no field 1 on a 1-tuple) -> RunFailed. The domain conj models exactly ONE field (r: Rec realized "(i32,)"), so no 2-field reading exists; the emitter truncates nothing. - complement: the swapped-arms tree IS a valid program (the identity fn), but the helper hardwired the primary's octets [0,0,0,0,0] while identity(True) natively yields [0,1,0,0,0]. Fix mirrors the passing kernel and meet_join legs: - field_access: new emit_field_eval_alt_descent_producer_tree — same root, facts differing only in the descent ranking symbol (digested via ranking_dimension_digest) -> different inferred_tree_digest -> new native key, emitted Rust stays the valid r.0 program (octet 9). Exactly kernel_alt_subject_tree's same-root/different-facts pattern. The now-dead wrong-field arrow producer is deleted (the wrong-field BODY stays as the eval-side RED control in wrong_fixture_refuses). - complement: thread expected_octet per tree (meet_join pattern); primary legs expect 0, the swapped-arms alt run expects its derived 1. The swapped fixture keeps its RED role in the equals-claim leg. Verified by execution on srv1 (fix-test @ c7d53ac + this change): both previously-red legs PASS, and all 7 aggregate fns PASS wet — kernel 100.8s, field_access 88.6s, complement 90.2s, match_loop_fold 105.3s, meet_join 87.0s, variant_construct 88.1s, classical_not_ingested 127.9s — 9/9 witness families executed as emitted native Rust agreeing with the interpreted oracle. cargo fmt --all --check clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Enroll the 9 emit-on-demand native families on the falsifier wet cadence The 2026-07-20 breakage proved this class invisible to CI. The nightly wet lane is the established home (same emit->build->run->equals class as the self-host template row); per-PR stays hermetic. Full CI-on-v2 (P6) remains gated on the is_hermetic->Admitted flip + the result store. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Effects flip + declared durable native cache (CI-on-v2 P6 rails) FLIP (build_transport_admission.dag:20's declared step, operator-assigned): emit_host_run_transport(_cached) intrinsics gain a leading admission argument and run ONLY on an Admitted verdict, in every mode — the blanket is_hermetic() early-returns are deleted (the law is path containment, not a mode bit). emit_host.dag threads the verdict from the Admitted match arm; the only two raw call sites live inside run_host_process_admitted. Unit tests: Admitted passes hermetic; EffectOutsideGrant/missing verdict refuse typed, every mode. DURABLE CACHE (first PerRunnerFilesystem realization row): - GUNBC_NATIVE_CACHE_ROOT rebases the declared /tmp/gunbc_ scratch prefix (root is WHERE, never WHAT — content-hash path components stay the key); exported in the shared CI prelude at RUNNER_TOOL_CACHE/gunbc-native, which survives the RUNNER_TEMP wipe. - GUNBC_CI_NATIVE_CACHE_COLD_CONTROL falsifier step (widen-only, the compile-clean cold-control pattern) re-runs the wet receipt batch cold via gunbc_falsifier_native_cache_cold_batches. - [native-cache] key/compile_skipped receipt line per cached invocation. - extdeps/realization/native_artifact_cache.dag: the catalog row (eviction: Manual — honest today; SizeBounded is the named dissolve-on). - 7 family cache-root literals consolidated onto std.emit_on_demand emit_on_demand_family_cache_root (single prefix authority). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * cargo fmt: flip unit-test asserts Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Native-cache evict intrinsic: one rebase authority for both lifecycle sides With GUNBC_NATIVE_CACHE_ROOT set, a raw shell.Remove on the .dag-composed /tmp path would miss the rebased workspace and falsely leave it warm — the cold/content-change legs would red on the second run. Extract the rebase into native_cache_rebase_workspace_dir and route eviction through a new emit_host_native_cache_evict intrinsic (wet-only, idempotent) sharing it with the cached transport. Registry row in 04_method.dag (regen to follow). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Regen seed: emit_host_native_cache_evict registry row Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Regen ci.yml + falsifier.yml: native-cache root export + cold-control step Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Cold-control roster: only cold-valid legs (agreement + native_cold) Probe receipt: under GUNBC_CI_NATIVE_CACHE_COLD_CONTROL=1 the cold_then_warm legs correctly FAIL (the control destroys the warm-ness they assert), so the falsifier cold step must not run the full aggregates — it runs the 9-leg cold-valid roster (falsifier_native_cache_cold_entries) instead. The warm nightly batch keeps the full aggregates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Reconcile merge-crossed witnesses: backstop sum gains native-cache cold-control term; template roster 2 -> 9 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Sudoers roster lambda: named-helper inference (closure-order-sensitive 'T' failure) + regen deploy scripts The unannotated field-access lambda (#7047's form) fails inference as 'no field command_path on type T' when this branch's added modules shift the closure; a named helper with explicit params gives inference the call-arg constraint both parse paths accept. Generator ExitSuccess on the merged tree (srv1 receipt); seed regen at fixed point (99 files, 0 diffs). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Witness admission: cold roster is an explicit falsifier consumer; family rows expect FalsifierSelfHostWet Main's new admission test asserted the family rows as OfflineLocalRecipe — written against pre-enrollment main. The rows now have real executing consumers: the wet template (aggregates) and the native-cache cold roster (agreement legs), which consumer_for_explicit_rosters previously did not consult (misclassifying falsifier-executed rows as offline). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Brian Searls <searlsbrian@gmail.com> Co-authored-by: gunbai-bot[bot] <289086189+gunbai-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the merged emit-on-demand kernel witness pattern (#6879) to lane 2 of the ratified width-5 partition:
emit_host_field_accessandemit_host_complement.Adds two execution witness suites mirroring the kernel template (P3 ACCEPT matrix: agreement, cold→warm, content-change MISS, wrong-oracle RED, plus pure Share/Recompute/budget-refusal subtests). Updates
v1_deletion_planlane state andemit_on_demandmodule note.Not in scope (dissolved per parent handoff): custom partition proposal — stern-lark-430's width-5 partition is ratified; lanes 3–5 are sibling sessions.
Known gap: wet agreement/cold-warm/content-change subtests for field_access and complement RED locally — the base
emit_host_*_equals_eval_all_holdsclaims also fail onmain(da0e7c3d), indicating an emitter gap for these families, not a regression from this PR. Pure subtests and the kernel (emit_host_add) suite pass. Execution witnesses remain excluded from floor discovery (witness_exclusion_substrings).Handoff posted on #6879: #6879 (comment)
Test plan
9b3f987(build + ci floor, run 29696710863)claim_batch:emit_on_demand_kernel_witnessesPASS; lane 2 pure subtests PASS