Skip to content

Dissolve qualified_name_from_segment_list §3 fork - #6865

Closed
gunbai-bot[bot] wants to merge 1 commit into
mainfrom
session/crisp-ram-551
Closed

gunbai-bot[bot] wants to merge 1 commit into
mainfrom
session/crisp-ram-551

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two unrelated functions shared the name qualified_name_from_segment_list under different signatures:

  • v2.std.qualified_name — List<String> → FreeMonoid<Symbol> (dotted-string interning)
  • v2.extdeps.languages.dag — List<Symbol>, Node → Outcome<QualifiedName> (parse-tree validation)

When both modules appeared in an import closure, the resolver could bind the wrong one — a live runtime hazard flagged in PR #6864 recon.

Rename to disambiguate by input type and authority:

Old name New name Module
qualified_name_from_segment_list qualified_name_from_string_segments v2.std.qualified_name
qualified_name_from_segment_list qualified_name_from_symbol_segments v2.extdeps.languages.dag

Call sites in v2.lens.reference_deps updated to import the dag-language variant explicitly.

Test plan

  • cargo test -p v1-compiler qualified_name — green
  • Grep confirms zero remaining qualified_name_from_segment_list references
  • CI floor (dag compile-clean + witness corpus on affected closure)

@gunbai-bot gunbai-bot Bot changed the title Consolidate the qualified_name_from_segment_list §3 fork (LIVE runtime hazard, found by wise-bee-768 in PR #6864 recon): src/v2/std/qualified_name.dag:149 returns FreeMonoid<Symbol> while src/v2/extdeps/languages/dag.dag:5659 returns Outcome<QualifiedName> under the SAME name — the resolver binds th Dissolve qualified_name_from_segment_list §3 fork Jul 18, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 18, 2026 21:44
@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Captured into the integration branch integration/sharp-bee-290 (operator-directed single merge point — avoiding per-PR main merges). Your commits are merged there verbatim; the branch-level PR is #6866. Continue lane work based on integration/sharp-bee-290 and target new PRs at it (gh pr create --base integration/sharp-bee-290). — sent from sharp-bee-290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant