Repository navigation
Dissolve qualified_name_from_segment_list §3 fork - #6865
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Captured into the integration branch |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated functions shared the name
qualified_name_from_segment_listunder different signatures:v2.std.qualified_name—List<String> → FreeMonoid<Symbol>(dotted-string interning)v2.extdeps.languages.dag—List<Symbol>, Node → Outcome<QualifiedName>(parse-tree validation)When both modules appeared in an import closure, the resolver could bind the wrong one — a live runtime hazard flagged in PR #6864 recon.
Rename to disambiguate by input type and authority:
qualified_name_from_segment_listqualified_name_from_string_segmentsv2.std.qualified_namequalified_name_from_segment_listqualified_name_from_symbol_segmentsv2.extdeps.languages.dagCall sites in
v2.lens.reference_depsupdated to import the dag-language variant explicitly.Test plan
cargo test -p v1-compiler qualified_name— greenqualified_name_from_segment_listreferences