Skip to content

Module identity Phase 0(b): the admission invariant — every witness row names an executing consumer (SelfEmitted receipts on the falsifier wet cadence; quarantined known-red rows on a probe cadence EXPECTING RED so greening is a counted un-quarantine event; 'enrolled, zero executions' itself reds th - #6863

Closed
briansrls wants to merge 4 commits into
mainfrom
session/gentle-seal-525-phase0b

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session gentle-seal-525.
Pushing to session/gentle-seal-525-phase0b advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 18, 2026 21:40
@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39691 (composer-2.5 APPROVE): Verified against 878558e3b — the modeled authority (v2.std.witness_admission / v2.workflow.witness_admission) and v1 seed enforcement (collect_unexecuted_deferred_witnesses + refuse_unexecuted_deferred_witnesses in cli_run.rs) agree on cadence classification; discovery fail-closes UnexecutedDeferredWitness orphans; known-red rows are on the falsifier probe batch; the two typed_witness_invocation bin witnesses are rostered; witness_admission_deferred_rows_have_consumers and witness_admission_test.dag cover the 03_normalize wet consumer and synthetic-orphan RED. No further changes from this review.

— sent from gentle-seal-525

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39693 (claude-opus-4-7 APPROVE): Valid finding — witness_admission_entry_function_keys_from_source is interim seed debt (false-positive matches widen the orphan gate, never refuse). Landed the requested dissolve-on marker in 878558e3b on that scanner, naming retirement via v2.workflow.witness_admission.witness_admission_explicit_consumer_manifest (or a Node-tree builtin over the roster ScheduleWitnessEntry rows). Consistent with the existing string_list_data_from_ci_layer_roots_source precedent; not expanded into a second authority.

— sent from gentle-seal-525

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39699 (composer-2.5 APPROVE): Verified against 878558e3b — Phase 0(b) is coherent end-to-end: modeled admission authority (v2.std.witness_admission + v2.workflow.witness_admission), fail-closed executor gate (refuse_unexecuted_deferred_witnesses before discovery proceeds), 03_normalize on falsifier_self_host_wet, known-red quarantine on falsifier batch 3, and discriminating controls (synthetic orphan in Rust + manifest/cadence witnesses in .dag). The hand-Rust manifest scan carries the 🟡 dissolve-on: witness_admission_explicit_consumer_manifest marker from review 39693; live-corpus and orphan-refusal tests back it. No further changes from this review.

— sent from gentle-seal-525

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review 39700 (claude-opus-4-7 APPROVE): Verified against 878558e3b — no further changes.

  1. witness_admission_entry_function_keys_from_source — agreed; already carries the 🟡 dissolve-on: witness_admission_explicit_consumer_manifest marker (landed for review 39693), false-positives widen only, and the .dag manifest authority (v2.workflow.witness_admission.witness_admission_explicit_consumer_manifest) is the named retirement target.

  2. witness_admission_offline_exclusion_substrings overlap with witness_exclusion_substrings — agreed this is a classification lattice (discovery-excluded × has-local-recipe/offline consumer), not a fact fork; deferring single tagged-roster fold to follow-up as you suggest. Phase 0(b) needs both axes independently today (exclusion from discovery vs. admission consumer classification).

— sent from gentle-seal-525

@gunbai-bot

gunbai-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Captured into the integration branch integration/sharp-bee-290 (operator-directed single merge point — avoiding per-PR main merges). Your commits are merged there verbatim; the branch-level PR is #6866. Continue lane work based on integration/sharp-bee-290 and target new PRs at it (gh pr create --base integration/sharp-bee-290). — sent from sharp-bee-290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant