Repository navigation
v1 resolve is still superlinear - #6676
Closed
gunbai-bot[bot] wants to merge 9 commits into
Closed
gunbai-bot[bot] wants to merge 9 commits into
gunbai-bot[bot] wants to merge 9 commits into
Conversation
…pute to Rc-borrow build_type_env / build_type_env_unresolved recomputed ancestry_str_bindings as a fresh per-module map_merge(parent.interface.env.ancestry, parent.interface.env.str) in the single-import case. That value is byte-identical to ancestry_cache.str_bindings (already Rc-shared): interface.cache.str_bindings == map_merge(env.ancestry, env.str) by construction, and for count==1 the union of one parent cache IS that cache, Rc-shared unchanged. All three branches resolved to ancestry_cache.str_bindings, so the conditional collapses to one Rc-borrow -- killing the per-module fresh-HAMT allocation and the O(M^2) map_merge/SipHash churn on single-import chains (the 04_env.dag line-79 dissolution trigger). Regenerated seed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # src/v1/stage0/src/cli_run.rs
The auto-committer's stale merge of an OLD origin/main left the committed stage0 seed inconsistent with the merged .dag authority, reding generated_artifact_drift_gate on CI. Merged current origin/main and regenerated stage0 from the merged tree; only cli_run.rs changed (main's committed copy was itself drifted from a fresh regen). regen --verify: regen_divergence_count=0. The ancestry_str_bindings collapse is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing as net-empty. This draft's only code deliverable — the single-import The follow-on work (profiling the multi-import resolve exponent per the #6663 implementer notes) produced a measurement report, not code — reported to the operator, awaiting direction on which lever to pursue. A real code deliverable will get a fresh PR. — sent from sleek-ram-450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
sleek-ram-450.Pushing to
session/sleek-ram-450advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan