Repository navigation
G1b: extend qualified projection parse+resolve to pattern, fn type-annotation, and let/data type-annotation positions (gentle-gull execution receipt: #6641 only type-alias RHS; match-arm Closed => FatArrow/Dot; blocks Wave-0 (c)) - #6662
Closed
briansrls wants to merge 4 commits into
Closed
briansrls wants to merge 4 commits into
briansrls wants to merge 4 commits into
Conversation
…nnotations Extend G1 (#6641, type-alias RHS only) to parse and resolve container.member qualified names in pattern constructors, typed let bindings, and v2 grammar positions (constructor_pattern → qualified_name; let_expr optional `: Type`). v1 lookup_variant_in_type routes dotted variant names through symbol_index_lookup. Compile-clean witness on import-less g1b fixture (fn return, data, let annotations). Unblocks Wave-0 (c) homonym qualification. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
session/neat-newt-628-g1b
branch
from
July 15, 2026 04:03
7ae1711 to
3ca7c6b
Compare
Contributor
|
Review feedback (claude + cursor APPROVE): Verified — no code changes required from either review. CI fix (b3ec352, synced to this branch): Same — sent from neat-newt-628 |
Contributor
|
Superseded by #6661. Canonical branch — sent from neat-newt-628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends Grammar lane G1 (#6641, which only wired qualified projection through type-alias RHS) to the remaining positions needed for Wave-0 (c) homonym qualification:
parse_dotted_identin match patterns (is_variant_pattern_start); typedlet x: Type = exprwith qualified type annotationsconstructor_patternusesqualified_name(match-arm closed by=>, dots in QN spines);let_exprgains optional: type_exprlookup_variant_in_typeroutes dotted variant names throughsymbol_index_lookup(fail-closed on miss)qualified_module_projection_g1b_fixture(fn return type, data annotation, let annotation) + enrollment claimFn/data type annotations already flowed through
parse_type_exprfrom G1; G1b completes pattern + let and aligns v2 formal grammar.Test plan
./target/release/regen_stage0— wrote 95 generated stage0 filescargo build -p v1-compiler— greencargo run -p v1-compiler --bin v1_src_dag_parse— 39 files parse-cleangunbc compile --source-root dag --source-root src/v2 --target dag— green (full dag tree)