Skip to content

Dedupe converge_cli_applied_knob_count: remove the doubled Srv3InstallDiagnosticObserve/OsInstallActuatorToolchainEnsure arms - #6651

Merged
briansrls merged 17 commits into
mainfrom
session/calm-ferret-849
Jul 15, 2026
Merged

briansrls merged 17 commits into
mainfrom
session/calm-ferret-849

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two-line cleanup: the parallel main-red fixes (#6633-area and #6634) each added arms for the same two HostEffect variants, and their merge left converge_cli_applied_knob_count with duplicate (unreachable, first-match-wins) arms on main. Removes the second copies — §2 redundancy and an edit-one-copy-miss-the-other footgun in the file that has been today's composition-skew hotspot.

Test plan

  • Whole-tree gunbc compile --dependency-pool-index primary-precedence --target dag: 0 diagnostics.

🤖 Generated with Claude Code

briansrls and others added 17 commits July 14, 2026 03:40
…)/2b/2c signed, B1 working-default typed-target) + tick landed slice-0/1 roadmap boxes

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…uperseded) + clear the stale FLAG-gating text in the critical-path summary

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ce-0/1 ticks + slice-2 in-flight note into roadmap_authority.dag (done+operator-sign rows) and regenerate via main_wet; drift gate PASS locally

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ciated concat over receipt lines → balanced pairwise join, O(len·n) → O(len·log n) copying, byte-identical output by associativity

Opus noted-and-waived the defect on #6586; the standing operator ruling (DESIGN §6, 2026-07-10) forbids the 'n is small here' waiver. Proven by srv3_typed_receipt_emit_uses_printf_not_naive_echo (content assertion) green. Root cause — no std linear join authority (N hand-rolled joins: join_slash, join_mirror_urls_for_shell, this) — goes on the Wave 4 ledger, not patched per-site here.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… it) + add Srv3InstallDiagnosticObserve / OsInstallActuatorToolchainEnsure arms (#6587's variants landed armless — fifth composition-skew instance); whole-tree compile 0 diagnostics

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title shell -> dag Dedupe converge_cli_applied_knob_count: remove the doubled Srv3InstallDiagnosticObserve/OsInstallActuatorToolchainEnsure arms Jul 14, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 14, 2026 23:56
@briansrls
briansrls merged commit ffdc9f9 into main Jul 15, 2026
3 of 4 checks passed
@briansrls
briansrls deleted the session/calm-ferret-849 branch July 15, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant