Skip to content

Wave 1 Gate 1 Stage D — general body producer subsumes the produce_* fixture family (by execution), then delete the bespoke flat-token grammar + StampBinding tables + fixture pass-throughs. Base on PR #6632 (C1). = the Wave-2 trigger. - #6649

Merged
briansrls merged 32 commits into
mainfrom
session/neat-wren-83-wave1-gate1-d
Jul 15, 2026

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session neat-wren-83.
Pushing to session/neat-wren-83-wave1-gate1-d advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls force-pushed the session/neat-wren-83-wave1-gate1-d branch from 6a1081c to 62f0d77 Compare July 15, 2026 00:36
briansrls and others added 14 commits July 15, 2026 01:01
Restore the broken dag_pick_arrow_with_body_node header, drop module-parse
smoke tests that exceed the 5s discovery budget, and dedupe eval test imports.

Co-authored-by: Cursor <cursoragent@cursor.com>
.dag modules do not accept C-style comments; use a data note instead so
discovery resolve succeeds.

Co-authored-by: Cursor <cursoragent@cursor.com>
Route slow provenance-producer and census parse witnesses to long/,
fix swapped-operand emit producers, and drop broken parse_binding long
copy that regressed after grammar migration.

Co-authored-by: Cursor <cursoragent@cursor.com>
…6649

Prefer let-in grammar before bare let assignment so `let x = 1 in x` parses
inside fn bodies, and register dag_loop_measure_sym as a canonical symbol so
resolve accepts loop bound edges from ingested fixtures.

Co-authored-by: Cursor <cursoragent@cursor.com>
Restore wave1_gate1_d_ingested_probe_test to the five family probes only;
census-ingest diagnostics belong in long/, not the 5s discovery lane.

Co-authored-by: Cursor <cursoragent@cursor.com>
wave1_gate1_d_ingested_probe_test duplicated the long-lane keystone at
~12s/eval; delete it — subsumption proof lives in long/ only.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review July 15, 2026 03:38
briansrls and others added 2 commits July 15, 2026 03:48
…#6649

Re-ground pbf helpers on normalized/resolved operand lexemes (not flat-token
branded atoms) and keep long-lane enrollment in commit_workflow.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Addressing @cursor/composer-2.5 REQUEST_CHANGES (verified against 734c15d5):

1. parse_binding_fidelity_test.dag — specification-without-execution
Valid. The fast-lane witnesses were dropped without a enrolled long replacement. Fixed in e75712 + 734c15d5:

  • Added long/parse_binding_fidelity_witness_test.dag with witness_parse_binding_fidelity_distinct_identifiers_holds and witness_resolve_distinct_param_bindings_holds.
  • Enrolled both in commit_workflow.dag (ExecutionWitnessKind, long lane).
  • Re-grounded pbf_* helpers for census ingest: checks now walk normalized/resolved add arrow operands by distinct lexemes (x/y), not flat-token branded atoms that no longer appear in the raw parse tree.

2. affected_set_provenance_producer — coverage removed from PR CI
Valid. The seven ingest witnesses were relocated to long/ without commit_workflow enrollment. Fixed in e75712: all seven lens_affected_set_provenance_producer_*_holds fns enrolled as ExecutionWitnessKind on long/affected_set_provenance_producer_witness_test.dag. Fast lane retains only the two selectivity witnesses (sub-ms).

3. body_lower_let_in_has_in_keyword — predicate dissolution
Valid. Dissolved the coproduct Present/Absent → Bool wrapper in e75712: body_lower_try_let_in_from_captured now matches directly on body_lower_let_in_body_capture_optional (Absent arm = absent let-in, Present arm = lowering path).

Re: @claude/claude-opus-4-7 APPROVE — acknowledged; no blocking items from that review.

— sent from neat-wren-83

briansrls and others added 5 commits July 15, 2026 04:10
… lhs

The fast-lane manual claims were retitled to census ingest while still
calling table_fixture_add_arrow_with_body; relabel to match the actual
producer and drop the duplicate resolved-bridge claim (census ingest
proofs live in long-lane wave1_gate1_d witnesses).

Co-authored-by: Cursor <cursoragent@cursor.com>
wave1_gate1_d_add_swapped_well_formed_holds exceeded the 5s discovery
budget via the ingested_fixture_arrows import closure; swapped variants
remain covered in long/wave1_gate1_d_mvp_subsumption_witness_test.dag.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls and others added 4 commits July 15, 2026 05:17
…sus ingest

The witness vacuously passed via parse rejection on the old MVP1 surface
ingest. With full parse_module, use a known diff path (path_mid) that has
no provenance row for the fixture read so resolve_edit_locus_from_provenance
refuses instead of widening to Holds.

Co-authored-by: Cursor <cursoragent@cursor.com>
…esses

Address RC #38264: long-lane census subsumption now asserts body behavior
kinds (Transform/Branch/Bind/Loop/Match), not just arrow-has-body; ingested
bind/loop execute through eval with wrong-value RED controls enrolled in
long/wave1_gate1_d_ingested_bind_loop_eval_witness_test.dag. Re-ground
ingested_fixture_arrows note with dissolve-on and witness routing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

RC #38264 — addressed in 97adf51915 + a7cfe273e4

Both findings were valid. Fixes:

1. Behavior-kind witnesses (not just arrow-has-body)

wave1_gate1_d_ingested_fixture_helpers.dag now has per-behavior checks (wave1_gate1_d_arrow_body_is_transform|branch|bind|loop|match) and wave1_gate1_d_census_ingested_behavior_kinds_holds() covering all census fixture variants. Long-lane witness wave1_gate1_d_census_subsumption_witness_holds composes well-formedness + behavior kinds (mirroring add's ComputationNode { behavior: Transform } pattern).

2. Ingested bind/loop execution + RED on census path

  • bind_census_ingested_executes_holds / bind_census_ingested_wrong_value_red_holds in bind_eval_by_execution_test.dag
  • loop_census_ingested_executes_holds / loop_census_ingested_wrong_value_red_holds in loop_eval_by_execution_test.dag
  • Enrolled in long/wave1_gate1_d_ingested_bind_loop_eval_witness_test.dag + commit_workflow.dag

Fast-lane keystone tests remain on table_fixture_* (5s budget); census-ingest execution proof is long-lane only. Local claim_batch green on all three long witnesses.

Note at :40 updated to match actual witness routing.

— sent from neat-wren-83

@briansrls
briansrls merged commit f62330d into main Jul 15, 2026
2 checks passed
@briansrls
briansrls deleted the session/neat-wren-83-wave1-gate1-d branch July 15, 2026 12:50
briansrls added a commit that referenced this pull request Jul 15, 2026
Rebased onto main after #6649 (f62330d) landed. That PR resolved the drift by
regenerating docs/plans/inert-layer-lens.md from its authority — which DISCARDED
the §8 sibling-family note #6638 had hand-added to the generated doc. main went
green by losing the content, not by homing it.

This PR's purpose therefore changes: it is no longer a main-unblock (main is
green), it RESTORES the lost note and puts it in the right home. The authority
carries the note; the generated doc is regenerated to match. Both agree, gate green.

Verified by execution on the merged head:
  - authority-only (pre-regen) -> FAIL run_generated_artifact_drift_gate
    (i.e. merging the prior version of this PR would have RE-RED main)
  - authority + regenerated doc -> PASS run_generated_artifact_drift_gate
  - the regen diff is exactly the 2 lines #6649 removed, no other doc churn

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant