Skip to content

Fix non-exhaustive HostEffect match in fleet_converge_cli converge knob count #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 2 commits into from
Jul 14, 2026
Merged

Fix non-exhaustive HostEffect match in fleet_converge_cli converge knob count #6625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa7203c
WIP: Prerequisite: fleet_converge_cli.dag non-exhaustive HostEffect m…
Jul 14, 2026
d9f829f
WIP: Prerequisite: fleet_converge_cli.dag non-exhaustive HostEffect m…
Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dag/gunbc/commit_workflow.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ data commit_gate_roster: List<CommitCheckEnrollment> = [
"wave1_gate1_b1_bare_call_resolves_end_to_end_witness_holds",
"wave1_gate1_b1_symbol_index_frontend_parity_no_regression_witness_holds"
],
kind: ExecutionWitnessKind,
kind: CorpusWitnessKind,
span: SpanUndeclared
},
surfaces: [GithubActionsCiJob]
Expand All @@ -388,7 +388,7 @@ data commit_gate_roster: List<CommitCheckEnrollment> = [
"wave1_gate1_a1_symbol_index_frontend_parity_witness_holds",
"wave1_gate1_a1_real_ingest_lowers_witness_holds"
],
kind: ExecutionWitnessKind,
kind: CorpusWitnessKind,
span: SpanUndeclared
},
surfaces: [GithubActionsCiJob]
Expand Down
1 change: 1 addition & 0 deletions dag/gunbc/fleet_converge_cli.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ fn converge_cli_applied_knob_count(intent: HostEffectIntent, fallback: Int) -> I
ConvergePlan { policy: p } => p.knobs.length()
ShellCommand { script: _ } => fallback
RedfishAction { action: _ } => fallback
SetHostnameCas { hostnamectl_path: _, base: _, desired: _ } => fallback
Srv3InstallReconcileObserve { include_git_meta: _ } => fallback
DurableApprovalGrantRecord => fallback
DurableApprovalGrantRead => fallback
Expand Down
Loading