Skip to content

affected sest falsifier - #6614

Closed
briansrls wants to merge 2 commits into
mainfrom
session/silent-eagle-662
Closed

affected sest falsifier#6614
briansrls wants to merge 2 commits into
mainfrom
session/silent-eagle-662

Conversation

@briansrls

@briansrls briansrls commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session silent-eagle-662.
Pushing to session/silent-eagle-662 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 2 commits July 14, 2026 15:16
Brian Searls
WIP: affected sest falsifier
31de7a3
Brian Searls @claude
Affected-set falsifier burn-down: link orphan doc + backfill 3 nfr sites
53f12ff 
The nightly affected-set-falsifier's whole-corpus cold sweep (gunbc_falsifier_batches,
SelectionPredictOnly) surfaced 4 red live-tree witnesses = 2 real drift debts of the
documented masking class (PRs landed changes the per-PR affected-set selection did not
run these live-tree witnesses for, so the red surfaced on the next cold sweep, not the
landing PR — 4th instance, siblings to #6530/#6533):

1. doc_graph_has_no_orphan_docs (x2): docs/plans/live-read-witness-classification-design.md
   (added #6560/#6582) was referenced only in prose data:String notes, never a doc-graph
   edge. Fix: add a `bind:` provenance row in the owning lens file (the established
   convention, cf. commit_workflow_plan_doc_provenance) -> doc-graph root, orphans 1->0.

2. non_fold_residue_clean_holds (x2): resolved report = 3 unrostered, 0 stale.
   Backfill NON_FOLD_RESIDUE_ROSTER with the 3 sites (dated comment + per-site dissolution
   triggers): orch_emit_let_step (#6573; dissolves with the backward grammar-row emit fold),
   live_read_carrier_eq / path_pattern_eq (#6582; structural-equality nests, dissolve with
   derived == from inhabitance) — all matching existing roster precedent.

Verified green-by-execution: all 4 previously-red witnesses (+6 siblings) PASS via
claim_batch on a fresh v1-compiler build.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 14, 2026 15:20
@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

CI investigation: the failing `ci` check is not caused by this diff. It is a pre-existing whole-tree compile-clean main-red affecting every open PR (verified: #6613, #6612, #6611, #6609, #6608, #6607, #6603, #6602 are all red on `ci`).

Root cause (authoritative — reproduced locally via `gunbc compile --source-root dag --source-root src/v2 --target dag`):
```
non-exhaustive match: missing variant(s) Srv3InstallReconcileObserve, DurableApprovalGrantRecord,
DurableApprovalGrantRead, Srv3InstallMediaFetch, ... Srv3ReceiptEmit
(dag/gunbc/fleet_converge_cli.dag — converge_cli_applied_knob_count, match intent.effect)
```
The shell→dag srv3/converge slices (#6572/#6598/#6586) expanded the host-effect coproduct with ~12 new variants but did not update this match, so the whole-tree compile-clean gate (dag_compile_clean_gate, batch-1) refuses and stops before the discovery batch (batch-2) where this PRs nfr/doc witnesses run. My change (a roster backfill + a bind: provenance row structurally identical to the working live_read_classification_law row in the same file) cannot affect the --target dag compile.

Being fixed by #6604 (session/sleek-deer-172-mainred-nfr-orphan), which repairs the match in the correct fleet lane. That PR overlaps this one (same nfr roster + orphan doc) but its roster is missing 2 of the 3 unrostered sites my resolved audit found (live_read_carrier_eq, path_pattern_eq). I have handed those two rows to sleek-deer-172. Plan: consolidate into #6604 as the comprehensive main-red fix and close this PR as superseded once #6604 carries all three roster rows. No fix to push here — the blocker is out-of-lane and already owned.

— sent from silent-eagle-662

briansrls added a commit that referenced this pull request Jul 14, 2026
@briansrls @claude
Roster the two #6582 structural-eq sites (live_read_carrier_eq, path_…
f5b54f8 
…pattern_eq — coordination: silent-eagle-662's resolved audit, supersedes #6614) + dedupe the replace-all's second roster insertion

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Superseded by #6604 (`session/sleek-deer-172-mainred-nfr-orphan`). Verified on #6604 head: all three unrostered nfr sites now rostered (orch_emit_let_step + live_read_carrier_eq + path_pattern_eq, with attribution), the live-read orphan doc relinked, and — critically — the compile-clean main-red fixed (fleet_converge_cli.dag converge_cli_applied_knob_count exhaustiveness), which this PR lacked. sleek-deer-172 confirmed non_fold_residue_clean_holds + doc-orphan witnesses PASS by execution on the merged-main tree (3 rostered, 0 unrostered, 0 stale). Closing to consolidate (§2 DRY) — the complete fix lives in #6604.

— sent from silent-eagle-662

@gunbai-bot gunbai-bot Bot closed this Jul 14, 2026
briansrls added a commit that referenced this pull request Jul 14, 2026
@gunbai-bot @briansrls @claude
Fix the three nightly/main reds: nfr roster row, live-read doc relink…
8693f60 
…, compile-clean non-exhaustive match — and locate the compile-clean refusal (#6604)

* Fix the two nightly reds: roster orch_emit_let_step (nfr, masking receipt #9) + re-land the live-read design doc link lost to the #6564 merge race

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix the third nightly red (compile-clean) + locate the refusal: converge_cli_applied_knob_count one-special-variant dispatch (#6598 x #6586 stale-base interaction made main compile-red); floor compile-clean refusal now prints located hard diagnostics (it previously printed ok=false with zero located errors — this patch is what found the non-exhaustive match); nfr lens-precision note (field-scrutinee matches are lens-invisible, no roster row)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Roster the two #6582 structural-eq sites (live_read_carrier_eq, path_pattern_eq — coordination: silent-eagle-662's resolved audit, supersedes #6614) + dedupe the replace-all's second roster insertion

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@briansrls
briansrls deleted the session/silent-eagle-662 branch July 14, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@briansrls