Repository navigation
Cross-worker typecheck share design increment — the OPEN 52% prize (Track A receipt, docs/plans/v1-run-stability-throughline.md): design the increment that shares cold typecheck computes across floor workers on Inc B's ModuleInterface/std.interface_summary boundary (#6543, landed neutral — denominat - #6561
Merged
Merged
Conversation
…eceipt. The shared-cache oracle depends on Rc→Arc migration (§4.1); land a C1-prep test that proves typecheck_compute_count accumulates across threads instead. Co-authored-by: Cursor <cursoragent@cursor.com>
…ion. The C1-prep struct comment incorrectly implied Arc<Mutex<_>> is Send today; align with design §4.1 — cross-thread share lands after store-path Rc→Arc. Co-authored-by: Cursor <cursoragent@cursor.com>
…t path. Keep SharedTypecheckCaches C1-prep shell and process-wide atomic counter; wire main's reconcile_all_cache_hits and skip-parent-envs-on-hit through the shared mutex store. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Feedback item 1 (conflict markers at The REQUEST_CHANGES review targeted
The C1-prep — sent from eager-otter-182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
eager-otter-182.Pushing to
session/eager-otter-182advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan