Skip to content

Cross-worker typecheck share design increment — the OPEN 52% prize (Track A receipt, docs/plans/v1-run-stability-throughline.md): design the increment that shares cold typecheck computes across floor workers on Inc B's ModuleInterface/std.interface_summary boundary (#6543, landed neutral — denominat - #6561

Merged
briansrls merged 11 commits into
mainfrom
session/eager-otter-182
Jul 14, 2026

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session eager-otter-182.
Pushing to session/eager-otter-182 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 6 commits July 14, 2026 02:07
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 14, 2026 02:59
Brian Searls and others added 3 commits July 14, 2026 03:23
…ion.

The C1-prep struct comment incorrectly implied Arc<Mutex<_>> is Send today; align with design §4.1 — cross-thread share lands after store-path Rc→Arc.

Co-authored-by: Cursor <cursoragent@cursor.com>
…t path.

Keep SharedTypecheckCaches C1-prep shell and process-wide atomic counter; wire main's reconcile_all_cache_hits and skip-parent-envs-on-hit through the shared mutex store.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Feedback item 1 (conflict markers at cli_run.rs:3552-3585) — already addressed in 92b944a65.

The REQUEST_CHANGES review targeted 5d2c031, which was an incomplete auto-merge that left <<<<<<< HEAD / >>>>>>> origin/main markers in the file. That commit never compiled.

92b944a65 resolves the conflict with an explicit merge decision (not mechanical marker deletion):

  • Collision-honesty: check_module_source_identity_map on shared_caches.module_source_identity (mutex-wrapped, same §6.3 wall as before)
  • Eliminate per-entry reconcile assembly rerun at 100% typed-cache hits #6562 fast path: was_cache_hit skips collect_parent_envs on typed-cache hits; reconcile_all_cache_hits wired through SharedTypecheckCaches
  • No conflict markers remain in cli_run.rs; build is green on 92b944a65

The C1-prep SharedTypecheckCaches shell is preserved; main's reconcile optimizations are integrated rather than dropped.

— sent from eager-otter-182

@briansrls
briansrls merged commit 4b4a388 into main Jul 14, 2026
3 checks passed
@briansrls
briansrls deleted the session/eager-otter-182 branch July 14, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant