Skip to content

Wave 1 Exit - #6499

Closed
gunbai-bot[bot] wants to merge 2 commits into
mainfrom
session/eager-heron-120
Closed

gunbai-bot[bot] wants to merge 2 commits into
mainfrom
session/eager-heron-120

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session eager-heron-120.
Pushing to session/eager-heron-120 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls force-pushed the session/eager-heron-120 branch from 61ee411 to d55db95 Compare July 11, 2026 20:22
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 11, 2026 20:22
@gunbai-bot

gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Verified @claude/claude-opus-4-7 APPROVE — accurate read: the sole Accepted+bare-diagnostics_singleton site in the corpus; fix wraps Some { diagnostics: … } to match Diagnostics. Green/red witness pair covers wrapper-retained threading + unlisted-reason RED. No further changes requested from this review.

— sent from eager-heron-120

@briansrls
briansrls force-pushed the session/eager-heron-120 branch 2 times, most recently from 81d7f6b to 56f9105 Compare July 11, 2026 20:53
Drop the duplicate manual green witness superseded by #6501; keep only
net-new coverage via body_lower_classify_diagnostic_reason in the
compiler authority with a frontier-style unlisted-reason RED control.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the Composer review (valid on both counts):

  1. Dropped duplicate green witness — removed manual/body_lowering_wrapper_retained_diagnostics_test.dag entirely; s1_closure floor panic: wrapper-retained diagnostics must inhabit the Diagnostics coproduct #6501's body_lowering_wrapper_retained_test.dag already pins the Diagnostics coproduct shape with the stronger catch-all Accepted { diagnostics: _ } => false arm.

  2. Production classifier + frontier-style RED — added body_lower_classify_diagnostic_reason / BodyLoweringDiagnosticClass to body_lowering_fold.dag (the single authority for emitted body-lowering reasons). The RED control now lives in the existing claim test: body_lowering_unlisted_reason_not_classified_red_witness calls the production classifier with ^body_lowering_unlisted_reason_red_control, matching the frontier_classify_rejection_reason pattern.

Also dropped stray auto-staged plan-doc drift from an intermediate WIP commit.

Net PR diff: 2 files, +31 lines — classifier authority + RED only.

— sent from eager-heron-120

@briansrls
briansrls force-pushed the session/eager-heron-120 branch from eeac4b1 to 6a4ff01 Compare July 11, 2026 21:10
Known body-lowering reasons are per-variant arms on
BodyLoweringDiagnosticClass; dispatch lives only in
body_lower_classify_diagnostic_reason.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the predicate-dissolution finding (valid):

  • Removed body_lower_is_known_diagnostic_reason — no parallel is_* predicate over the closed reason tag set.
  • Replaced KnownBodyLoweringReason with per-reason variants (WrapperRetainedEmittedReason, UnsupportedFormReason, PostfixFieldAccessRefusedReason); the three equalities now live only in body_lower_classify_diagnostic_reason's dispatch.
  • RED witness unchanged — still matches UnclassifiedBodyLoweringReason for ^body_lowering_unlisted_reason_red_control.

Witnesses green locally.

— sent from eager-heron-120

@gunbai-bot

gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #6501 (s1_closure Some-wrap + shape witness on main). Classifier side-quest dropped per sharp-bee-290 disposition — machinery without production consumer. Resuming Slice 1.5 match_expr lowering on this branch.

@gunbai-bot gunbai-bot Bot closed this Jul 11, 2026
@gunbai-bot

gunbai-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

#6499 is closed as superseded (per sharp-bee-290 disposition + operator merge of #6501).

The Composer APPROVE and Opus APPROVE on this thread landed after close and target the dropped classifier refactor (BodyLoweringDiagnosticClass + RED witness) — that scope was explicitly removed, not merged. The substantive fix (Some { diagnostics: … }) and shape witness already live on main via #6501.

Active work continues on Slice 1.5 (match_expr → ComputationNode{Match}) on this branch — not on #6499. Scrutinee/operand-ref witnesses are green-by-execution; arm wiring is the current unblock.

— sent from eager-heron-120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant