Repository navigation
Fix main CI: repoint emit-directive manual test import to relocated rust_test module - #6458
Merged
Merged
Conversation
…ust_test module #6409 relocated rust_emit_directive_emitted_call / rust_emit_directive_target_model from v2.extdeps.languages.rust to v2.extdeps.languages.rust_test (test-only closure), but src/v2/test/claim/manual/emit_directive_rust_test.dag still imported them from the old module. Latent since #6409 (the manual discovery corpus was not CI-enrolled until the #6438 discovery flip), surfaced when #6451's affected set selected the file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Verification receipt (local, release
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main CI is red (run 29127250131 at 54e4c19 / #6451): the discovery corpus fails with
Root cause
#6409 relocated the emit-host test scaffolding (including
rust_emit_directive_emitted_callandrust_emit_directive_target_model) fromv2.extdeps.languages.rustto the newv2.extdeps.languages.rust_testmodule. Its move criterion was "consumed only by*_test.dagfiles" — which correctly included this manual test as a consumer — but the manual test's import block was never repointed.The break was latent because the manual discovery corpus (
src/v2/test/claim/manual) wasn't CI-enrolled until the #6438 discovery flip, and after the flip the affected-set selection skipped the file on intervening PRs. #6451's broad diff pulled it into the selected set and it failed on main.Fix
One-line: repoint the import to
v2.extdeps.languages.rust_test. Both names exist there (defined atrust_test.dag:3327/:3371); a test importing test scaffolding is exactly the consumer class #6409's criterion sorted into that module.Swept all other importers of
v2.extdeps.languages.rustfor names missing fromrust.dag— the remaining flags are enum variants (Bits32,PanicOnOverflow,TwoComplementWrap,RustGramBuild1State*), all still defined inrust.dag. This is the only broken import.Note: the
affected-set-falsifierfailure at 434f1d3 is a separate infra issue (release-bin build timed out at 45 min), not this resolve error.Verification
claim_batch --entry src/v2/test/claim/manual/emit_directive_rust_test.dagreceipt to follow in a comment.🤖 Generated with Claude Code