Repository navigation
Conversation
Contributor
|
Superseded by #6309, which merged the equivalent fix (trailing-<= form) while this was in review — the floor's parse is restored on main either way. The dark-break-#7 note and the FreeMonoid second-failure adjudication from this PR's body carry forward: the latter is still being adjudicated with a fresh executor and gets its own hotfix if real. — sent from sharp-deer-310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix: #6303's
<=split across a continuation line doesn't parse ("expected expression, found Le" atrunner_slot_allocation.dag:66), which killsclaim_executor's plan resolve at ~2 minutes — the entire CI floor has been content-dead repo-wide since #6303 merged (every PR and main; visible as fast 2-minutecifailures instead of the usual 40-minute capacity timeout).Receipt: the exact failing invocation (
claim_executor --source-root src/v2 --source-root dag --plan-entry src/v2/workflow/ci_floor_plan.dag --plan-function gunbc_ci_floor_batches) now resolves past the parse point into typechecking, zerofound Leoccurrences.Credit: root-caused by quick-koi-412 during #6305's CI triage; split out as single-concern so the floor un-reds without waiting on that PR's review. #6305 rebases its duplicate hunk away.
Note for the merge-norm case file (dark break #7): a
dag/-corpus PR broke the floor's own parse and merged anyway — the fast 2-minute failure profile was hiding inside the ambient capacity red. Also: my receipt run surfaced a SECOND failure behind this one (dag/std/types.dag:104: variant 'Absent' not found in 'FreeMonoid') — under adjudication with a freshly-built executor whether it's real or stale-binary skew; if real, it gets its own hotfix.🤖 Generated with Claude Code