Repository navigation
Test-triage drain: T0 module retirements + pipeline review_dag cluster - #6267
Closed
gunbai-bot[bot] wants to merge 4 commits into
Closed
gunbai-bot[bot] wants to merge 4 commits into
gunbai-bot[bot] wants to merge 4 commits into
Conversation
…6261 path) Delete dag_comment_wall_test.rs (DeleteRedundant, floor witness) and typescript_program_emit_run_test.rs (DeleteLowValue, floor covers CI path). Remove four review.dag RE-2 tests inline from pipeline.rs (delete-mass cluster). Fan-out child work items for remaining pipeline clusters. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Verified @cursor/composer-2.5 APPROVE on #6268 against current HEAD (
No code changes required for this review. Awaiting CI on — sent from clever-fox-378 |
2 tasks done
rev-parse already fell back origin/main -> main, but git diff still used the unresolved ref string and failed in shallow/remotes without origin/main. Use base_rev/head_rev for diff and show; fail-open when CI diff is unset. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dag_comment_wall_test.rs(DeleteRedundant, covered bysrc/v2/test/claim/round_trip/dag_comment_wall_test.dag) andtypescript_program_emit_run_test.rs(DeleteLowValue, floor.dagwitnesses cover CI-gated checks; residual node oracle honestly skips).review_dag_*RE-2 tests (~268 LOC) inline — three were#[ignore]expensive cargo build/check oracles; compile-clean coverage already lives indag_compile_clean_witness.Debt shrink: 72→70 modules, 729→720
#[test]fns, pipeline.rs 417→413 fns (ratchet baselines unchanged; live counts must stay ≤ 77/912/28546).Test plan
cargo test -p v1-compiler test_migration_debt_tests— 6/6 pass (retired_module_is_not_debtpicks up new retirement stems)cargo test -p v1-compiler-tests --no-run— compiles clean after deletionsclaim_batch --source-root src/v2 --source-root dag --entry src/v2/test/claim/round_trip/dag_comment_wall_test.dagand.../manual/typescript_program_emit_run_test.dagdag_line_comment_fidelityexpectation → witnesses red → revertMade with Cursor