Skip to content

Test-triage drain: T0 module retirements + pipeline review_dag cluster - #6267

Closed
gunbai-bot[bot] wants to merge 4 commits into
mainfrom
session/quiet-dove-292
Closed

gunbai-bot[bot] wants to merge 4 commits into
mainfrom
session/quiet-dove-292

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Typed retirement path for test_migration_debt (model + guard union + first DeleteRedundant) #6261 retirement path: delete dag_comment_wall_test.rs (DeleteRedundant, covered by src/v2/test/claim/round_trip/dag_comment_wall_test.dag) and typescript_program_emit_run_test.rs (DeleteLowValue, floor .dag witnesses cover CI-gated checks; residual node oracle honestly skips).
  • pipeline.rs cluster (delete-mass, first): remove four review_dag_* RE-2 tests (~268 LOC) inline — three were #[ignore] expensive cargo build/check oracles; compile-clean coverage already lives in dag_compile_clean_witness.
  • Manager fan-out: spawned child work items for remaining pipeline clusters (scrambled_name_emit, transport_emit rest+shell, complexity bounds, self_host/self_gen8) and migrate-class tail modules.

Debt shrink: 72→70 modules, 729→720 #[test] fns, pipeline.rs 417→413 fns (ratchet baselines unchanged; live counts must stay ≤ 77/912/28546).

Test plan

  • cargo test -p v1-compiler test_migration_debt_tests — 6/6 pass (retired_module_is_not_debt picks up new retirement stems)
  • cargo test -p v1-compiler-tests --no-run — compiles clean after deletions
  • Floor witnesses green: claim_batch --source-root src/v2 --source-root dag --entry src/v2/test/claim/round_trip/dag_comment_wall_test.dag and .../manual/typescript_program_emit_run_test.dag
  • Perturb receipt (5-test-migration (1): delete v1 disposition_redundancy_lens_test — floor witnesses already cover it #6131 recipe): temporarily flip dag_line_comment_fidelity expectation → witnesses red → revert

Made with Cursor

…6261 path)

Delete dag_comment_wall_test.rs (DeleteRedundant, floor witness) and
typescript_program_emit_run_test.rs (DeleteLowValue, floor covers CI path).
Remove four review.dag RE-2 tests inline from pipeline.rs (delete-mass cluster).
Fan-out child work items for remaining pipeline clusters.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Verified @cursor/composer-2.5 APPROVE on #6268 against current HEAD (5d925f8):

No code changes required for this review. Awaiting CI on 28730820434.

— sent from clever-fox-378

briansrls and others added 3 commits July 5, 2026 05:48
rev-parse already fell back origin/main -> main, but git diff still used
the unresolved ref string and failed in shallow/remotes without origin/main.
Use base_rev/head_rev for diff and show; fail-open when CI diff is unset.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls briansrls closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant