Repository navigation
Unbreak regen after #6242: registry partition + .dag comment parse wall - #6260
Closed
gunbai-bot[bot] wants to merge 3 commits into
Closed
gunbai-bot[bot] wants to merge 3 commits into
gunbai-bot[bot] wants to merge 3 commits into
Conversation
… parked them hand-maintained) #6242 moved v1_compiler_dag_collect.rs and v1_compiler_dag_collect_support.rs to HAND_MAINTAINED_STAGE0_FILES (its in-line comment: the slot-map + fp/key memo lives only in the hand-edited seed until regen is unblocked) but left them in GENERATED_STAGO_FILES, so assert_registry_is_partitioned refuses: regen_stage0 fails on any tree — regen blocked repo-wide again, one merge after #6255 unblocked it. Deleting the two GENERATED rows enacts the author's documented intent; the partition assert itself is the witness (fails on origin/main, passes here). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… modules failed to load) .dag deliberately has no comment syntax; the six // lines #6242 added to dag_collect.dag / dag_collect_support.dag make both modules unparseable, so 'v1.compiler.dag_collect{,_support}' never register and regen fails with 65 cascade diagnostics (unresolved import + every json_quote / dag_node_key / collect_dag_nodes use across compile.dag). The rationale those comments held is already in #6242's commit message, which is where the repo keeps it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gunbai-bot
Bot
changed the title
Contributor
Author
|
Known follow-up (out of scope here, kept minimal per manager): the dag_collect fingerprint memo that makes #6242 fast lives only in the hand-edited seed, not in the .dag model — dag_collect_insert in the model still recomputes dag_node_surface_fingerprint_rec per node and re-derives the anchor 3x, so a clean regen from .dag reverts the O(M²) until the memo is modeled in dag_collect.dag (a §7 model↔seed fork). The hand-maintained parking this PR completes is the interim guard; modeling the memo is the dissolution. — sent from snappy-newt-504 |
Review note on this PR: the six removed // lines included two on-carrier dissolution markers (std.content_hash grounding for the fp memo; collision_errors threading drop condition). .dag cannot carry comments, so their nearest legal carrier is the HAND_MAINTAINED registry entry that already owns the #6242 parking rationale and dissolves at the same trigger. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two #6242 fallouts that re-blocked
regen_stage0repo-wide one merge after #6255 unblocked it — both mechanical, both enacting #6242's own documented intent:v1_compiler_dag_collect{,_support}.rsinHAND_MAINTAINED_STAGE0_FILES(its comment: the P1 slot-map/fp memo lives only in the hand-edited seed until regen unblocks) but left both inGENERATED_STAGE0_FILES;assert_registry_is_partitionedfails on any tree. Fix: delete the two GENERATED rows (regen then stops overwriting the hand-edited memo — the guard the comment asks for)..dagcomment parse wall: P1 emit fix: dag_collect O(n^2) fingerprint memo #6242 added six//lines todag_collect.dag/dag_collect_support.dag..dagdeliberately has no comment syntax, so both modules fail to parse and never register — regen dies with 65 cascade diagnostics (unresolved import: v1.compiler.dag_collect_support+ everyjson_quote/dag_node_key/collect_dag_nodesuse incompile.dag). Fix: strip the lines; their rationale already lives in P1 emit fix: dag_collect O(n^2) fingerprint memo #6242's commit message, the repo's convention for it.Test plan
regen_stage0fails at the partition assert on origin/main, then (with only fix 1) at the 65 parse-cascade diagnostics, and proceeds past both with this PR (--emit-freshreceipt in session snappy-newt-504).🤖 Generated with Claude Code