Skip to content

std.temporal_effect + gunbc.os_install_deduction T1 vocabulary (roadmap 2-temporal-effect-spine-a, 2-os-install-deduction-a) - #6187

Merged
briansrls merged 11 commits into
mainfrom
session/os-install-deduction-a
Jul 3, 2026
Merged

std.temporal_effect + gunbc.os_install_deduction T1 vocabulary (roadmap 2-temporal-effect-spine-a, 2-os-install-deduction-a)#6187
briansrls merged 11 commits into
mainfrom
session/os-install-deduction-a

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session zesty-bat-588.
Pushing to session/os-install-deduction-a advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

briansrls and others added 3 commits July 2, 2026 23:28
@briansrls @cursoragent
std: temporal realization spine vocabulary (temporal-effect-spine-a)
12089a8 
Define std.temporal_effect durable facts, receipt-derived fold, and RED
witnesses so effects can resume/retry without a bespoke workflow engine.
Roadmap dispatches 2-temporal-effect-spine-a under zesty-bat-588.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(std): fail-closed lease regression and grant expiry in temporal fold
a603325 
Consult lease observation even when prior receipt converged; bound
GrantActive with observed_at <= expires_at; add RED witnesses and
dissolution marker for approval_grant_covers_intent.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
gunbc: os-install deduction preflight vocabulary (os-install-deductio…
9818e49 
…n-a)

Add AutoinstallStoragePolicy, TargetDiskState, preflight/runtime
diagnostic verdicts, KvmOperatorAttestation, and RED witnesses so
fully_automated installs without storage policy fail closed before boot.
Roadmap dispatches 2-os-install-deduction-a under zesty-bat-588.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 2, 2026 23:53
@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review responses — af5c3fb (CI + operator semantics)

Review #34830 (claude-opus-4-7 APPROVE) — acknowledged

Finding Action
autoinstall_has_storage_policy / preflight_verdict_allows_ready_to_boot predicate helpers Partially inlined: fold_os_install_preflight_verdict now matches storage_policy directly; preflight_verdict_allows_ready_to_boot kept as the single ready-to-boot gate (one caller site). autoinstall_has_storage_policy remains in extdeps for emit/tests only.
🟡 grant_not_expired_at lexicographic Timestamp No change — marker already present; agree this is honest v0 scaffold.
Verdict APPROVE noted — thank you.

Operator 5-surface review — scope for this PR (#6187)

In scope (this branch): std.temporal_effect + gunbc.os_install_deduction only.

Not in this PR:

Operator os_install_deduction request-changes — fixed in af5c3fb

Issue Fix
!fully_automated => CompleteForUnattended NotUnattendedByPolicy + RefuseNotUnattendedByPolicy; witness non_automated_is_not_unattended_ready
LoginPrompt => OsInstalled too strong KvmSuggestsOsBooted; OsInstalled reserved for router/SSH read-back; witness kvm_login_prompt_is_weak_not_os_installed
FirmwareSetup => FirmwareIdleBenign context-free KvmFirmwareIdleObserved (weak KVM-only); benign-vs-failure needs Redfish/elapsed fold in reconcile-a
T1 only / not wired to diagnostic fold Doc + roadmap updated to say T1; consumer is 2-srv3-install-reconcile-a

Operator temporal_effect follow-ups — addressed in af5c3fb

Issue Fix
Stringly verdict_label / plan_label effect_step_receipt_label_dissolution_marker (🟡)
fold_next_step_plan overclaims list fold Renamed plan_next_step_from_prior_receipt_and_lease; doc clarifies single prior+lease
derived_pending_step_id not progression cursor derived_pending_step_id_dissolution_marker (🟡)
Consumed grant witness Already present: consumed_grant_does_not_authorize_destructive → PlanAwaitApproval

CI fix (c2ab4c7)

  • witness_observed_at: Timestamp (was String — 13 type errors in compile-clean gate)
  • os_install_deduction multiline == parse error → match

— sent from zesty-bat-588

@gunbai-bot gunbai-bot Bot changed the title srv3-bringup — finish prefix:os-install-actuated + first subsumption checks. BMC Redfish alive (192.168.1.192, HTTP 200); router shows srv3 OS never on network. PREP everything runnable-by-command; live mount+boot+install is OPERATOR-GATED and the operator is available NOW — coordinate live steps th std.temporal_effect + gunbc.os_install_deduction T1 vocabulary (roadmap 2-temporal-effect-spine-a, 2-os-install-deduction-a) Jul 3, 2026
briansrls and others added 2 commits July 3, 2026 00:32
@briansrls
WIP: srv3-bringup — finish prefix:os-install-actuated + first subsump…
71c8e93 
…tion che
@briansrls @cursoragent
fix(gunbc): dissolve os_install_deduction test-only predicate helpers
c214395 
Delete unused runtime_verdict_implies_installer_awaiting_storage and the
hand-rolled boolean projections over coproducts; witnesses match verdict
variants directly (review #34841 non-blocking).

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review #34840 (composer-2.5 APPROVE) — verified

Finding is accurate: T1 vocabulary only, discriminating witnesses, honest 🟡 scaffolds, lease/read-back fix in place. No code change required.

Review #34841 (claude-opus-4-7 APPROVE) — fixed in latest commit

Finding Action
Predicate-dissolution smell (preflight_verdict_allows_ready_to_boot, runtime_verdict_implies_*) Fixed: deleted all three helpers; witnesses use direct match on verdict variants
Unused runtime_verdict_implies_installer_awaiting_storage Deleted (zero in-tree consumers)
Tracked scaffolds / fold direction No change — acknowledged as bounded 🟡 discipline

— sent from zesty-bat-588

@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review #34845 (claude-opus-4-7 APPROVE) — verified

T1 scope, coproduct folds, 🟡 scaffolds with dissolve-on triggers, discriminating witnesses, storage policy coproduct — all match current code. Predicate helpers dissolved in c214395. No code change required.

Review #34846 (composer-2.5 APPROVE) — verified

Storage policy coproduct, tracked scaffolds, unwired T1 deduction doc, witness suite — confirmed on changed lines. autoinstall_has_storage_policy remains extdeps test helper only (emit path matches policy directly). No code change required.

— sent from zesty-bat-588

briansrls and others added 3 commits July 3, 2026 01:32
@briansrls
Merge remote-tracking branch 'origin/main' into session/os-install-de…
5b400b2 
…duction-a
@briansrls
WIP: srv3-bringup — finish prefix:os-install-actuated + first subsump…
72e8510 
…tion che
@briansrls @cursoragent
fix(gunbc): scope os_install preflight fold to NBD-proxy actuator path
ab11efb 
Rename fold_os_install_preflight_verdict → fold_nbd_proxy_os_install_preflight_verdict
and seed-delivery helper to nbd_proxy_actuator_seed_delivery_is_local so
NoCloudNet incompleteness is not read as universal OS-install policy (operator
review 2026-07-03).

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Operator review 2026-07-03 — addressed

Surface Action
Deduction: NoCloudNet not universally incomplete Fixed: fold_nbd_proxy_os_install_preflight_verdict + nbd_proxy_actuator_seed_delivery_is_local; module doc + roadmap name NBD-proxy/on-ISO actuator scope
Temporal spine T1 No change — already marked vocabulary-only; workflow fold deferred to 2-srv3-install-reconcile-a per 🟡 markers
StoragePolicyDirectLayout destructive policy Acknowledged — T1 minimal enum arm; grow toward explicit destruction policy before live unattended use

— sent from zesty-bat-588

@briansrls @cursoragent
fix(gunbc): dissolve coproduct Bool predicates in os_install deductio…
aeaf82b 
…n path

Delete autoinstall_has_storage_policy and nbd_proxy_actuator_seed_delivery_is_local;
inline match on storage_policy and delivery in fold/witness (review #34864).

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review #34864 (composer-2.5 REQUEST_CHANGES) — fixed in latest commit

Finding Action
autoinstall_has_storage_policy predicate dissolution Deleted from ubuntu_autoinstall.dag; witness direct_layout_storage_is_complete_for_unattended matches storage_policy directly
nbd_proxy_actuator_seed_delivery_is_local predicate dissolution Deleted; fold_nbd_proxy_os_install_preflight_verdict now matches payload.delivery inline (NoCloudNet → IncompleteSeedDelivery, NoCloudLocal → storage/disk fold)

— sent from zesty-bat-588

@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review #34871 (claude-opus-4-7 APPROVE) — verified

Findings match aeaf82b8:

  • std.temporal_effect + gunbc.os_install_deduction T1 vocabulary; storage-policy coproduct + YAML emit arm
  • 🟡 dissolution markers on grant expiry, stringly receipt labels, derived cursor
  • Witness RED set: storage flips ReadyToBoot, KVM login ≠ OsInstalled, lease/grant gates
  • Predicate helpers dissolved in aeaf82b8 (addresses prior composer #34864 REQUEST_CHANGES)

No code change required.

— sent from zesty-bat-588

@gunbai-bot

gunbai-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Review #34872 (composer-2.5 APPROVE) — verified

Findings accurate on aeaf82b8:

  • T1 vocabulary only: std.temporal_effect, gunbc.os_install_deduction, storage-policy coproduct + emit
  • 🟡 markers on grant expiry, stringly receipt labels, derived cursor
  • Predicate dissolution from #34864 landed: no autoinstall_has_storage_policy / nbd_proxy_actuator_seed_delivery_is_local (inline match in fold + witness)
  • Discriminating witnesses for approval, lease, read-back, KVM weakness, storage preflight

No code change required.

— sent from zesty-bat-588

@briansrls
briansrls merged commit c0baa1c into main Jul 3, 2026
1 of 2 checks passed
@briansrls
briansrls deleted the session/os-install-deduction-a branch July 3, 2026 02:35
@gunbai-bot gunbai-bot Bot mentioned this pull request Jul 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@briansrls