Repository navigation
Derive T2 test-migration debt from live state instead of hand-maintained seed-shrink-census.md 5B table (dissolve the parallel ledger) - #6181
Conversation
…table docs/plans/seed-shrink-census.md §5B hand-listed v1 test modules with no floor witness equivalent — a parallel ledger that drifted from the tree (DESIGN §6). Replace it with a live derivation: - cli_run.rs: test_migration_debt_* builtins diff src/v1/tests/src/*.rs modules containing #[test] against the floor *_test.dag witness roster (via corpus_dag_files(), the same witness_layer_roots corpus the CI floor discovers from) by stem. - v2.lens.test_migration_debt: shrink-only ratchet over the live counts (module count / total LOC / total test-fn count), baselined at the values measured when the static table dissolved (66 / 13,441 / 418). - src/v2/test/claim/manual/test_migration_debt_test.dag: floor-discovered witnesses gating the ratchet. - seed-shrink-census.md §5B now points at the live builtins/lens instead of carrying the table. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ge always false Review caught a real §5 fail-open: test_migration_debt_stem only stripped ".rs" then "_test", so floor filenames (which end "_test.dag") never lost their .dag suffix and could never equal a v1 stem. Every #[test]-bearing v1 module was reported as debt regardless of floor coverage; the 66/13441/418 baseline was actually "all v1 test files", not a real diff. Also tightens the matcher (per a separate review comment) from fuzzy substring matching to exact stem equality: substring matching let "pipeline" (the single largest debt module) false-match the unrelated floor stem "typescript_import_pipeline", hiding rather than counting debt. Adds a discriminating red witness: witness_option_bridge_test.rs has a real floor counterpart and must never appear in the debt roster (this witness would have caught the regression above). Re-measured baselines with the fixed matcher: 77 modules / 28,546 LOC / 912 #[test] fns (83 total v1 test modules with tests, 6 genuinely floor-covered). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Both review findings addressed, pushed in 3d75bc6: Stem-matching real bug (claude-opus-4-7, CHANGES REQUESTED): confirmed — Fuzzy substring matching (claude-opus-4-7, APPROVE, non-blocking): also fixed, since I was in the matcher anyway and it's the same failure family — switched to exact stem equality. The substring version let Re-measured baselines with the corrected matcher against the live tree: 77 modules / 28,546 LOC / 912 — sent from witty-ant-890 |
|
Investigated the "1 failing" report on `3d75bc6`. It is not a code failure: the `ci` job's "gunbc ci (.dag witnesses + gates)" step ran the full CI floor for ~24 minutes (through compile + into batch-1 host-effects) and was killed by the workflow's 30-minute `timeout-minutes` job cap — the log ends with Corroborating: at the same time, every queued run on `main` itself (5/5 checked) is sitting in `queued`/not-yet-started — repo-wide runner congestion, consistent with the documented "CI slow = runner-slot count not saturation" pattern for this project, not something introduced by this PR's diff. Will re-trigger once the current run finishes (GitHub won't let me rerun while it's still "running" — the `rust_tests` job hasn't started yet). No fix commit needed here. — sent from witty-ant-890 |
|
Investigated the
— sent from witty-ant-890 |
Resolve seed-shrink-census.md conflict by keeping the derived-live 5B section (this branch's change) over the reverted hand-maintained table main had continued updating in parallel.
…deletes #6181 landed the live debt roster; this closes the remaining §5 gap where the shrink-only ratchet could be satisfied by deleting an uncovered v1 #[test] module. The guard diffs origin/main...HEAD for deleted src/v1/tests/src/*.rs files with line-anchored #[test] and requires an exact-stem floor *_test.dag witness on HEAD before each delete is allowed. Floor witness: test_migration_delete_guard_holds in test_migration_debt_test.dag. Co-authored-by: Cursor <cursoragent@cursor.com>
…tes (#6208) * feat(test-migration): add diff-based delete guard for v1 test module deletes #6181 landed the live debt roster; this closes the remaining §5 gap where the shrink-only ratchet could be satisfied by deleting an uncovered v1 #[test] module. The guard diffs origin/main...HEAD for deleted src/v1/tests/src/*.rs files with line-anchored #[test] and requires an exact-stem floor *_test.dag witness on HEAD before each delete is allowed. Floor witness: test_migration_delete_guard_holds in test_migration_debt_test.dag. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(test-migration): repair delete-guard two-dot diff argv and clippy unused bindings Address review on #6208: - Two-dot mode (GUNBC_CI_DIFF_MERGE_BASE=0) now passes base/head as separate git diff argv entries, matching floor_diff_observe.dag — the prior single "origin/main HEAD" string was unparseable. - Rename unused Err(e) bindings in the non-CI-diff fallback arms to Err(_). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Auto-opened by session-dashboard for session
witty-ant-890.Pushing to
session/witty-ant-890advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan