Repository navigation
De-fork coproduct_reflection: route concept_decl_facts through decl_facts substrate - #6163
Merged
Merged
Conversation
gunbai-bot
Bot
changed the title
Contributor
|
Verified both dashboard reviews against
Merge readiness (this session): 2 distinct APPROVE reviews, no REQUEST_CHANGES, — sent from vivid-dove-309 |
…e on main After #6158 dissolved decl_facts_project.rs, re-home the Chunk G de-fork in coproduct_reflection.rs: type_decls_parse_only_fail_closed (fail-closed build_module_path_index walk for concept reflection) and concept_decl_record shared by live/parse-only paths. Keeps decl_facts_corpus_walk separate — that path skips test .dag files and tolerates parse failure for decl_facts. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
force-pushed
the
session/vivid-dove-309
branch
from
July 2, 2026 21:41
42bdd06 to
22764f8
Compare
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
…d builders Continue Chunk G after #6163's concept_decl_facts substrate: extract for_each_live_registry_item for all *_decl_facts_live builtins, plus fn_arrow_decl_record and data_init_decl_record shared by live evaluators. fn_item_param_names is now single authority for param extraction. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks done
briansrls
added a commit
that referenced
this pull request
Jul 3, 2026
…d builders (#6173) * De-fork coproduct_reflection: share live-registry walk and decl record builders Continue Chunk G after #6163's concept_decl_facts substrate: extract for_each_live_registry_item for all *_decl_facts_live builtins, plus fn_arrow_decl_record and data_init_decl_record shared by live evaluators. fn_item_param_names is now single authority for param extraction. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(coproduct_reflection): cargo fmt for for_each_live_registry_item call sites CI rust_tests gate failed cargo fmt --check on the single-line for_each_live_registry_item closures in concept/data_init live evaluators. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: retrigger after 30m runner timeout (no code change) Prior run 28633571847: rust_tests and ci jobs were cancelled at timeout-minutes:30 while fmt/clippy passed and nextest/gunbc-ci were still running — infra timeout under fleet load, not a test failure. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(test): func_env semantic oracle archives dsl/ from pre-rename baseline rust_tests failed: git archive db559b4 dag — pathspec 'dag' did not match any files. Baseline commit predates #6165 (dsl → dag rename); use the historical tree name for archive, cache probe, and corpus roots. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: retrigger on 9f66470 (full dsl baseline archive fix) Prior dashboard failure @ ab2f9d2 was a partial WIP (comment-only); superseded by 9f66470 which fixes archive/cache/roots to use dsl/ from pre-#6165 baseline. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6159 (parse-only structural marshaler de-fork).
eval_concept_decl_facts(pool_roots)duplicated the parse-only corpus walk (build_module_path_index+ per-file parse +TypeItemfilter) that belongs indecl_facts_projectalongside the #5966decl_factscarrier.type_decls_parse_only_fail_closedandqualified_name_fulltodecl_facts_projectas the single parse-only substrate for type-decl reflectioneval_concept_decl_factsthrough it; shareconcept_decl_recordbetween live and parse-only pathsfn_arrow_decl_facts_live/data_init_decl_facts_livequalified names at the same authoritycoproduct_reflection.rsremains HAND_MAINTAINED: structural marshalers, wiring-liveness skeleton projection, and host bridge dispatch are still genuine realization bridges.Test plan
cargo test -p v1-compiler --lib decl_facts(3 tests, incl. new scoped-pool substrate witness)cargo test -p v1-compiler-tests coproduct_reflection(intercept wiring residual)cargo test -p v1-compiler-tests whole_tree_wiring(fn_arrow_decl_facts_live corpus anchor)cargo clippy -p v1-compiler -- -D warningscargo fmt --all --check