Repository navigation
2-emit-partition (b1a follow-up): scaffold markers + naming for the bash whole-program serializer - #6152
Merged
Conversation
…fold markers - Layering: bash_program_fold.dag was in extdeps but imports v2.compiler.emit (extdeps->compiler inversion). Moved to src/v2/workflow/bash_program_emit.dag (workflow may import compiler+extdeps; all imports point toward std). - Finding 1 (medium-as-string): the set-e prefix + newline stmt-join are String literals composed via concat. Added on-carrier SCAFFOLD marker (bash_program_serialize_medium_join_scaffold) naming the dissolution trigger: program-join + set-e become bash grammar productions emitted through the fold (mirror orch_construct_seq2 / orch_seq2_target_model), so bash_program_serialize emits with zero concat. Tracked as (b1b). - Finding 2 (single authority): added reconciliation marker (bash_program_serialize_single_authority_reconciliation) declaring bash_program_serialize THE single v2 ShellProgram->String authority and serialize_bash the scaffold-to-delete; dissolution = (b3) consumer migration + serialize_bash deletion. The test oracle is the git-historical byte-reference. - Finding 3: renamed facts_lookup/atom bash_program_fold_* -> bash_program_emit_* for module consistency; it is a fail-closed sentinel mirroring orch_emit_facts_lookup (direct-variant emit never consults facts, proven green). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…83-b-bash-defork # Conflicts: # src/v2/workflow/bash_program_emit.dag
gunbai-bot
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6149 (merged early, before the review-fix commit landed). Carries the review fixes claude-opus-4-7 requested on #6149 to main:
bash_program_serialize_medium_join_scaffold— the set-e prefix + newline stmt-join are String literals viaconcat; marker names the dissolution trigger (they become bash grammar productions emitted through the fold, mirroringorch_construct_seq2/orch_seq2_target_model, so serialization runs with zeroconcat). Tracked as (b1b).bash_program_serialize_single_authority_reconciliation— declaresbash_program_serializeTHE v2ShellProgram→Stringauthority andserialize_bashthe scaffold-to-delete (dissolves at (b3) consumer migration).bash_program_fold_*→bash_program_emit_*(facts_lookup + atom + serialize_stmt) for module consistency; fail-closed sentinel mirroringorch_emit_facts_lookup.Byte-oracle witnesses (
bash_program_serialize_matches_oracle_holds+ set_e teeth) re-verified green against current main.🤖 Generated with Claude Code