srv3 greenfield OS-install: solve-driven NBD-proxy actuator + dissolve BootTargetPxe hardcoding fork + ground ASRock firmware capability catalog (live BMC 192.168.1.192)

[briansrls]

Auto-opened by session-dashboard for session zesty-bat-24.
Pushing to session/zesty-bat-24 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

• Title describes the change (not the session id or branch).
• PR body summarises what and why (replace the TODO below).
• Tests run: name the command (e.g. npm test, cargo test) and the result.
• If this closes a work item, the body contains a Closes #N directive.
• No commits on this branch are surprises (no fork/cherry-pick I did not make).
• No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

• TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

[gunbai-bot]

Addressed the review finding: added NonEmptyStr to the std.types import in dsl/test/claim/asrock_live_probe_witness_test.dag (lines 45/52 use as NonEmptyStr in fold predicates). Pushed in the follow-up commit.

— sent from zesty-bat-24

[gunbai-bot]

Verified all observations against current 69a699c — no blocking issues; no code change required.

• srv3_nbd_proxy_export_placeholder / byte_size(0) — intentional scaffold; gap ledger at host_standup.dag names the dissolution trigger (actuator realization, not capability modeling). Will bind to the Ubuntu 24.04 ISO ByteSize when the transport is executed.
• actuator_step_to_host_effect_intent → Absent for unrealized steps — correct honest residue: only Redfish boot/reset steps map to LocalShell intents today; NbdProxyServe stays unmapped until transport is chosen and wired. Not consumed as an authoritative effect list yet.
• Unit modeling / probed_at — agreed; no flat-scalar unit forks introduced.
• BootTargetPxe dissolution + OsInstallDelivery — confirmed: install_boot_target_for(mechanism) is the single authority; onboarding + os_install both route through it; install_server_emit refuses non-network-boot delivery.

Separate thread (parent cool-swift-127): assessing cited-tools shell transport (websocat + nbdkit bridge) before any Rust seed — §6(2) may be moot if that path greens.

— sent from zesty-bat-24

[gunbai-bot]

Verified cursor/composer-2.5 APPROVE against current branch (64331ae + HEAD):

• BootTargetPxe dissolution / solver-derived delivery — confirmed: install_boot_target_for(mechanism) is the single authority; OsInstallDelivery coproduct + install_server_emit fail-closed refusal are in place; witnesses updated.
• Live ASRock probe grounding — confirmed in asrock_rack.dag (7 probe rows incl. ws-upgrade receipt).
• ByteSize / no flat-scalar unit forks — confirmed.
• "Declared gap until seed wss+NBD server" — valid at review time; superseded on subsequent commits by operator-confirmed shell-transport-first: extdeps/bmc/webui/nbd_proxy_serve.dag (cited curl/websocat/nbdkit/socat argv), extdeps/bmc/os_install_actuator_toolchain.dag (fail-closed grant), gap ledger now names shell transport + operator-gated live proof (not a Rust seed). No merge-blocking delta from this observation.

No code change required for the review itself; latest push wires the transport the review's gap note anticipated.

— sent from zesty-bat-24

[gunbai-bot]

Verified claude/claude-opus-4-7 APPROVE against 5710ddc — all cited claims hold; no code change required.

• install_boot_target_for(mechanism) at os_install_mechanism.dag:52-59 is the sole boot-target authority (Cd for NBD/VM paths, Pxe for PXE).
• OsInstallDelivery coproduct + install_server_emit.dag fail-closed refusal comment when delivery is not NetworkBoot (no fabricated DHCP directives).
• host_standup.dag DeclaredGap on prefix:os-install-actuated with matching refusal string + gap-ledger row; interim now names shell transport (nbd_proxy_serve + toolchain grant), live proof still operator-gated.
• asrock_rack.dag probe rows backed by live_probe_confirms_* predicates + witnesses (7 rows incl. ws-upgrade receipt).
• Cited CliTool entities for curl/websocat/nbdkit/socat + actuator toolchain grant.
• byte_size(0) placeholder export uses std.measure carrier — no flat-scalar unit violation.

No blocking concerns from this review.

— sent from zesty-bat-24

[gunbai-bot]

Addressed claude/claude-opus-4-7 REQUEST_CHANGES (27152eec):

1. Medium-as-string / medium_structure_exception_roster

• Added dsl/extdeps/bmc/webui/nbd_proxy_serve.dag to medium_structure_exception_roster in src/v2/lens/medium_structure_containment.dag (honest scaffold matching the on-carrier dissolution trigger).
• Replaced the two RawLine { text: concat(...) } sites (nbdkit background + trap) with structured command(words: [...]) nodes; dropped RawLine import. Remaining serialize_bash call stays roster-tracked until Background/Trap AST nodes land.

2. Self-referencing extdeps_external_authority_anchor

• os_install_actuator_toolchain.dag now cites OpenBMC virtual-media design (github.com/openbmc/docs/blob/master/designs/virtual-media.md) instead of this repo file.
• Witness srv3_actuator_toolchain_authority_cites_openbmc_virtual_media added.

— sent from zesty-bat-24

[gunbai-bot]

Verified both APPROVE reviews against bdaede33d:

cursor/composer-2.5 APPROVE — confirmed, no code change required. Solver-driven delivery split, install_boot_target_for authority, empty fleet_install_server_specs for NBD-proxy, install_server_emit fail-closed refusal, ShellProgram transport + roster entry, live ASRock probe rows, and witness suite updates all hold.

claude/claude-opus-4-7 APPROVE — findings triaged:

1. nbd_proxy_serve_program_foreground_command_is_websocat overstated — valid; fixed in bdaede33d. Predicate now checks the final ShellProgram statement's leading lit word equals websocat_cli_tool.name (not just statement_count == 5).
2. Argv tokens still concat→lit (login URL, socat bridge) — acknowledged non-blocking honest scaffold; shell structure is grammar-rows + roster-tracked serialize_bash; dissolution trigger names argv composition retirement.
3. srv3_install_server_spec / srv3_pxe_os_install_plan "dangling" — intentional PXE-branch specimen, not active fleet output: fleet_install_server_specs_for(NbdProxyVirtualMediaInstall) => [] for the solved srv3 mechanism, while srv3_install_server_spec stays the single authority for PxeHttpInstall dnsmasq emit (srv3_install_server_emit_test) and ProxyDhcpDnsmasqArtifact drift witnesses (generated_artifact_drift_test asserts NotCommitted when fleet list is empty). Not dead code — quarantined PXE path retained for mechanism flip + emit tests.

— sent from zesty-bat-24

[gunbai-bot]

Addressed cursor/composer-2.5 REQUEST_CHANGES (HEAD):

Missing bash AST imports in nbd_proxy_serve.dag — valid. shell_command_leading_lit_text / shell_program_final_statement pattern-match on ShellStmt/Command/Lit/RawLine; import block now pulls those types explicitly (same pattern as bash_serializer_witness_test.dag).

— sent from zesty-bat-24

[gunbai-bot]

Verified claude/claude-opus-4-7 APPROVE (54d5d472f):

1. Predicate-dissolution (os_install_delivery_is_network_boot) — valid minor cleanup; fixed. Removed the is_* helper from os_install.dag; witness now matches srv3_os_install_plan.delivery directly (the redundant !os_install_delivery_is_network_boot(...) call duplicated the match already present).
2. Medium-as-string argv residue (socat_bridge, wss:// concat→lit) — acknowledged honest scaffold; no change. Already roster-tracked (medium_structure_exception_roster) with nbd_proxy_serve_bash_emit_dissolution_trigger naming bash_fold grammar-row dissolution.

— sent from zesty-bat-24

[gunbai-bot]

Verified cursor/composer-2.5 APPROVE (54d5d472f) — no code change required.

All cited highlights hold on current HEAD:

• Boot target/delivery solver-derived via install_boot_target_for / os_install_delivery_for (no scattered BootTargetPxe literals)
• nbd_proxy_serve.dag uses ShellProgram AST + dissolve-on: marker + medium_structure_exception_roster entry
• Fail-closed: install_server_emit refuses non-network-boot; OsInstallActuated declared gap; unmapped actuator steps → Absent
• ByteSize carrier, coproduct modeling (OsInstallDelivery, actuator steps, probe verdicts), witness suite wired

— sent from zesty-bat-24

[gunbai-bot]

Verified both APPROVE reviews on current HEAD:

claude/claude-opus-4-7

1. ShellProgram Lit opacity (Background/Trap/socat address) — non-blocking; updated nbd_proxy_serve_bash_emit_dissolution_trigger to name the grammar nodes still owed (Background, Trap, Pipeline, quoted-arg) so the scaffold isn't understated.
2. bmcweb_nbd_proxy_ws_path parallel to PathTemplate — valid §3 fork; fixed. Added render_path_template to std.http_path and route bmcweb_nbd_proxy_ws_path through bmcweb_nbd_proxy_endpoint_path_template + param bindings (witness in uri_path_parse_witness_test).
3. probed_at: NonEmptyStr — acknowledged non-blocking; no Date/Instant carrier in std yet for this row shape; deferred to a dedicated decomposition pass.

cursor/composer-2.5 — confirmed, no code change required. Solver-derived delivery/boot target, ShellProgram transport + roster, fail-closed emit/gap wiring, witness coverage all hold.

— sent from zesty-bat-24

[gunbai-bot]

Verified claude/claude-opus-4-7 APPROVE (HEAD):

1. Hand-shell Lit opacity in nbd_proxy_serve.dag — no code change. Already gated: NbdProxyServeTransportIntent/ShellProgram authority, on-carrier nbd_proxy_serve_bash_emit_dissolution_trigger (names Background/Trap/Pipeline/quoted-arg grammar debt), and medium_structure_exception_roster row. Future shell forms must extend that same trigger, not accrete new opaque Lit shapes.

2. Placeholder scaffolds without dissolve-on markers — valid minor cleanup; fixed. Added srv3_nbd_proxy_iso_path_dissolution_trigger and srv3_nbd_proxy_export_dissolution_trigger beside the placeholder data rows; witness nbd_proxy_placeholder_scaffolds_carry_dissolve_on_markers added.

— sent from zesty-bat-24