Skip to content

fix(ci-floor): delete white-box/tautological spawn-width witnesses (MAIN-RED) #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 1 commit into from
Jul 1, 2026
Merged

fix(ci-floor): delete white-box/tautological spawn-width witnesses (MAIN-RED) #6087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/v2/test/claim/ci_floor_plan_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,10 @@ import v2.workflow.ci_floor_plan {
witness_floor_no_corpus_resource_edge_to_compile_anchor,
witness_floor_tight_budget_backs_off_envelope,
witness_floor_fail_open_would_exceed_budget,
witness_floor_unreadable_budget_uses_conservative_envelope,
witness_floor_width_governed_by_budget_tree,
witness_floor_width_derived_from_tree_is_positive,
witness_floor_spawn_width_tight_budget_backs_off,
witness_floor_spawn_width_zero_budget_falls_back,
witness_corpus_effective_widths_fit_runner_cap,
witness_execution_corpus_spawn_width_at_runner_cap,
witness_plan_spawn_width_is_floor_width_at_runner_cap,
witness_floor_derived_width_leaves_headroom_at_cap,
}
import gunbc.ci_layer_roots { witness_discovery_scan_dirs, witness_layer_roots }
Expand Down Expand Up @@ -159,8 +155,7 @@ test fn ci_floor_plan_witnesses() -> Bool {

test fn ci_floor_run_envelope_witnesses() -> Bool {
witness_floor_tight_budget_backs_off_envelope() &&
witness_floor_fail_open_would_exceed_budget() &&
witness_floor_unreadable_budget_uses_conservative_envelope()
witness_floor_fail_open_would_exceed_budget()
}

test fn ci_floor_spawn_width_from_budget_tree_witnesses() -> Bool {
Expand All @@ -169,13 +164,10 @@ test fn ci_floor_spawn_width_from_budget_tree_witnesses() -> Bool {
}

test fn ci_floor_spawn_width_live_budget_witnesses() -> Bool {
witness_floor_spawn_width_tight_budget_backs_off() &&
witness_floor_spawn_width_zero_budget_falls_back()
witness_floor_spawn_width_tight_budget_backs_off()
}

test fn ci_floor_honest_width_fold_witnesses() -> Bool {
witness_corpus_effective_widths_fit_runner_cap() &&
witness_execution_corpus_spawn_width_at_runner_cap() &&
witness_plan_spawn_width_is_floor_width_at_runner_cap() &&
witness_floor_derived_width_leaves_headroom_at_cap()
}
26 changes: 0 additions & 26 deletions src/v2/workflow/ci_floor_plan.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,14 +509,6 @@ fn witness_floor_fail_open_would_exceed_budget() -> Bool {
demand_envelope_fits_budget(envelope: blind_envelope, budget: byte_size(tight_budget)) == false
}

fn witness_floor_unreadable_budget_uses_conservative_envelope() -> Bool {
let envelope = gunbc_ci_floor_run_envelope(memory_budget_bytes: 0)
demand_envelope_thread_count(envelope: envelope) == int_min(
a: gunbc_ci_floor_conservative_fallback_width,
b: execution_corpus_spawn_width()
)
}

fn witness_floor_width_governed_by_budget_tree() -> Bool {
let tree_width = hardware_thread_count_value(t: gunbc_ci_floor_spawn_width_from_tree())
let cpu_only_width = hardware_thread_count_value(t: bounded_host_spawn_width(shard_count: gunbc_ci_floor_breadth(), hardware_threads: gunbc_ci_floor_hardware_threads()))
Expand All @@ -534,11 +526,6 @@ fn witness_floor_spawn_width_tight_budget_backs_off() -> Bool {
width < gunbc_ci_floor_breadth()
}

fn witness_floor_spawn_width_zero_budget_falls_back() -> Bool {
let width = hardware_thread_count_value(t: gunbc_ci_plan_spawn_width(memory_budget_bytes: 0))
width == gunbc_ci_floor_conservative_fallback_width
}

fn floor_batch_heavy_gate_resolve_count(batch: List<Runnable>) -> Int {
fold(batch, init: 0, f: fn(acc, r) {
match r {
Expand Down Expand Up @@ -597,19 +584,6 @@ fn witness_corpus_effective_widths_fit_runner_cap() -> Bool {
floor_committed <= cap && exec_committed <= cap
}

fn witness_execution_corpus_spawn_width_at_runner_cap() -> Bool {
execution_corpus_spawn_width() == 3
}

fn witness_plan_spawn_width_is_floor_width_at_runner_cap() -> Bool {
let cap_budget = byte_size_count(b: gunbc_ci_runner_cgroup_memory_cap)
let plan_w = hardware_thread_count_value(t: gunbc_ci_plan_spawn_width(memory_budget_bytes: cap_budget))
let floor_w = hardware_thread_count_value(
t: gunbc_ci_floor_spawn_width_for_budget(memory_budget: gunbc_ci_runner_cgroup_memory_cap)
)
plan_w == floor_w
}

fn witness_floor_derived_width_leaves_headroom_at_cap() -> Bool {
let width = gunbc_ci_floor_memory_derived_width(cap: gunbc_ci_runner_cgroup_memory_cap, cpu_bound: 128)
let committed = byte_size_count(b: gunbc_ci_floor_per_shard_peak_rss_bytes()) * width
Expand Down