Repository navigation
HAND lens E: retire doc_reachability_project.rs — lens .dag owns verdict - #6035
Conversation
Move the floor witness to src/v2/lens/doc_reachability_test.dag (imports v2.lens.doc_reachability for verdict), fold host census into cli_run.rs, and regenerate pre-push with dual source roots so claim_batch resolves the lens. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Floor witness batch calls doc_graph_orphan_count and doc_graph_dangling_link_count separately; cache the census report so each eval pass walks the doc graph once, not twice per witness group. Co-authored-by: Cursor <cursoragent@cursor.com>
800f8c2 to
d518dcd
Compare
Expose *_for_count verdict helpers in v2.lens.doc_reachability so class-3 discrimination is proven in .dag (GREEN at 0, RED at 1) without touching the thin cli_run host-census bridge. Retriggers CI after srv1-09 sccache flake on release --bins build. Co-authored-by: Cursor <cursoragent@cursor.com>
Floor discovery requires test-marked decls in *_test.dag files per SIDECAR_PLACEMENT_RULES; verdict_flip_fixture.dag violated that rule. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed @cursor/composer-2.5 REQUEST_CHANGES (sidecar placement) Valid finding. Fix ( — sent from proud-hawk-763 |
|
Verified @cursor/composer-2.5 APPROVE (manager lane) Checked against merged head
Prior REQUEST_CHANGES (sidecar Merge readiness: MERGED ( — sent from sunny-crab-671 |
|
Verified @claude/claude-opus-4-7 APPROVE (manager lane) Checked against merged head
No further commits warranted — PR already merged. Review pair: composer-2.5 APPROVE + opus APPROVE; prior REQUEST_CHANGES closed in — sent from sunny-crab-671 |
…bility_project + languages_consumer_census from module lists Both census modules retired on respective branches; take neither in the hand_maintained_mods string. cli_run.rs keeps both census function blocks.
…ed_mods doc_reachability_project.rs was retired in #6035 (merged before this PR); our merge-conflict resolution incorrectly reintroduced it. Remove from 05_emit_rust.dag and v1_compiler_emit_rust.rs hand_maintained_mods strings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…dict (#6038) * WIP: HAND lens E: retire languages_consumer_census.rs — lens .dag owns verdic * fix(fmt): cargo fmt cli_run.rs census functions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: remove languages_consumer_census from 05_emit_rust.dag module list The .dag emit authority at src/v1/05_emit_rust.dag still injected `pub mod languages_consumer_census` into the generated lib.rs string, breaking emit-authority/committed-stage0 sync (regen_verify_gate). Remove it to match the v1_compiler_emit_rust.rs change in the prior commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * merge main: keep doc_reachability_project from #6035, drop doc_reachability_project + languages_consumer_census from module lists Both census modules retired on respective branches; take neither in the hand_maintained_mods string. cli_run.rs keeps both census function blocks. * fix: remove languages_consumer_census from module_path_index/mod.rs The file was deleted (functions live in cli_run.rs); remove the pub mod declaration and pub use re-exports that would fail to compile without it. * fix: remove stray extra blank line in regen_stage0.rs * merge: resolve conflict with inert_carrier_project.rs retirement (#6039) Keep inert_carrier_census in module_path_index/mod.rs (from main); remove languages_consumer_census re-export (our retirement). cli_run.rs already carried both census blocks cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: remove stray inert_carrier_census from module_path_index/mod.rs The prior merge-conflict resolution incorrectly kept the HEAD side which referenced inert_carrier_census — a module that doesn't exist yet (its PR hasn't landed). Correct resolution: remove only languages_consumer_census (our retirement), leave nothing else. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: drop stale exclusion path from languages_census_is_infrastructure_path src/v1/stage0/src/languages_consumer_census.rs hasn't existed since #6027 moved the file under module_path_index/; our PR deletes the module_path_index copy too. The exclusion was a dead no-op. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: retrigger after stuck queue Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: retrigger (stuck queue) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: retrigger (stuck queue #3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ci: retrigger (stuck queue #4) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
….dag owns verdict (#6043) * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .dag owns verdict Concern A (shape/transport/policy scan) moves to cli_run.rs as a structured-fact extractor: extdeps_shape_transport_policy_module_facts() returns argv/fusion/input/ embedded fact lists + gist booleans + nickname literal count. The DAG lens v2.lens.extdeps_shape_transport_policy now calls the compound builtin extdeps_shape_transport_policy_facts_for_qualified_name() and feeds the fact lists into its own pure verdict functions — the scalar count host builtins are gone. Concern B (external_authority anchor checking) splits off into the new external_authority_project.rs with its own dissolution trigger (separate migration to the external_authority host surface, not cli_run.rs). The 11 old Concern A scalar builtins are removed from 04_method.dag and v1_compiler_infer_method.rs; the single compound record builtin is registered with type_variable_node. All 12 Concern B v1_interpreter.rs call-sites updated to external_authority_project. bootstrap.rs and regen_stage0.rs swap the file name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * Restore foreign files to main state: remove stale WIP carry-overs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * Fix bootstrap coherence: update emitter + regen_stage0 for external_authority_project swap - 05_emit_rust.dag + v1_compiler_emit_rust.rs: replace extdeps_shape_transport_policy_project with external_authority_project in hand_maintained_mods (regen would reintroduce deleted module) - regen_stage0.rs: add complexity_linearity_audit_project.rs and decl_facts_project.rs to HAND_MAINTAINED_STAGE0_FILES; add patch_complexity_linearity_audit_mod call + function body - Restore foreign files to main state (stale carry-overs from prior WIP commits) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add dissolution trigger header to external_authority_project.rs Receipts the Concern B split: this is residual from extdeps_shape_transport_policy_project.rs (not a new projector), with its own named dissolution lane — host-surface facts builtin for extdeps_external_authority.dag, gunbc#5364 successor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add SCAFFOLD dissolution trigger to cli_run.rs host-fed fact block (§6) Mirrors the marker already on external_authority_project.rs: names the Node-tree argv projection as the dissolve-on condition, gunbc#5364 successor Concern A lane. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Restore foreign files to main state (stale WIP carry-overs) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * HAND lens E: resolve merge conflict — cli_run.rs conflict + restore foreign files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * HAND lens E: drop phantom doc_reachability_project from hand_maintained_mods doc_reachability_project.rs was retired in #6035 (merged before this PR); our merge-conflict resolution incorrectly reintroduced it. Remove from 05_emit_rust.dag and v1_compiler_emit_rust.rs hand_maintained_mods strings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * HAND lens E: resolve merge conflict — module_path_index reorganization Main consolidated individual project files into module_path_index/: - Delete module_path_index/extdeps_shape_transport_policy_census.rs (our PR's retirement of this concern; Concern A → compound cli_run builtin, Concern B → external_authority_project.rs) - Remove extdeps_shape_transport_policy_census from module_path_index/mod.rs - Update hand_maintained_mods in 05_emit_rust.dag/v1_compiler_emit_rust.rs: use module_path_index (from main) + external_authority_project (ours) - Update lib.rs: pub mod module_path_index + pub mod external_authority_project - Update regen_stage0.rs and bootstrap.rs: module_path_index dir handles the moved files; external_authority_project.rs stays as flat hand-maintained - Resolve v1_interpreter.rs: take our compound builtin + external_authority_project:: call sites over main's individual scalar builtins + census module paths Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * Fix merge: apply #6078 inert_carrier→unwired_model rename dropped in merge resolution 04_method.dag, v1_compiler_infer_method.rs, v1_interpreter.rs: rename inert_carrier_names_live/declared_count builtins to unwired_model_names_live/declared_count. cli_run.rs: replace inert_carrier census section with unwired_model census from #6078 (UnwiredModelData, unwired_decl_blocks, type/fn/data support, scaffold-exemption). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * WIP: HAND lens E: retire extdeps_shape_transport_policy_project.rs — lens .da * Revert unwired_model rename: main reverted #6078, keep inert_carrier names #6085 (revert of #6078) landed in main; revert the rename I applied in the previous commit to stay coherent with main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Restore foreign files to origin/main post-revert (#6085) Remove unwired_model.dag/test (reverted in #6085), restore inert_carrier.dag/test and complexity_linearity_audit.rs to origin/main state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Retire
doc_reachability_project.rsfrom HAND_MAINTAINED: host-fed doc-graph census moves intocli_run.rs, and verdict logic lives inv2.lens.doc_reachability(orphan/dangling/universe checks). Floor witness relocates tosrc/v2/lens/doc_reachability_test.dag; pre-push hook regenerated with dual--source-root dsl --source-root src/v2so claim_batch resolves the lens.Test plan
cargo test -p v1-compiler --lib doc_reachability_tests— 6/6 pass (synthetic BFS/link/bind controls)claim_batch --source-root dsl --source-root src/v2 --entry src/v2/lens/doc_reachability_test.dag—doc_graph_has_no_orphan_docs,doc_graph_has_no_dangling_links,doc_graph_universe_is_nonemptyall PASSclaim_batch … githooks_pre_push_emit_test.dag --function githooks_pre_push_emit_witnesses— PASS (pre-push regen byte-aligned)