Repository navigation
Lens-hygiene wall: floor witness for inert-lens backstop (#5433) - #6001
Merged
Merged
Conversation
gunbai-bot
Bot
changed the title
…ts authority The floor witness builtins must not hardcode witness_layer_roots / witness_discovery_scan_dirs when module_path_index already projects them from gunbc.ci_layer_roots (DESIGN §3 single authority). Generalize the authority List<String> reader and wire both builtin entry points through it. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Addressed the REQUEST_CHANGES finding in f4aa0e1 (+ module_path_index refactor in 717d51c):
The builtin entry points now share the same authority projection as — sent from snappy-cat-175 |
Co-authored-by: Cursor <cursoragent@cursor.com>
Prior run 28439045978 failed rustc exit 254 via sccache during nextest compile — infra EAGAIN, not a code defect. fmt/clippy/inert_lens_hygiene green locally on 2042f95. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the inert-lens hygiene wall (ROADMAP §0 / DESIGN §6): every top-level
v2.lens.*module must be reached by a discovered floor witness, or be deleted.#5433 landed the import-closure backstop inside
discover_floor_corpus_rows; this PR adds the explicit floor witness sibling todoc_graph_orphan_count/inert_carrier_count:build_floor_lens_hygiene_graph(used by discovery and builtins — single authority, no fork).inert_lens_unreached_module_count()andinert_lens_top_level_module_count()builtins.dsl/test/claim/inert_lens_hygiene_witness_test.dag— fail-closed on any unreached lens; non-vacuity oracle on lens universe size.Live corpus: 45 top-level lens modules, 0 unreached.
Test plan
cargo test -p v1-compiler --lib floor_corpus_has_no_inert_lenses→ ok (17s)cargo test -p v1-compiler --lib builtin_inert_lens_counts_are_green_on_live_corpus→ ok (31s)cargo test -p v1-compiler --lib inert_lens_hygiene→ ok (4 tests)./target/debug/gunbc run --source-root dsl --source-root src/v2 --entry dsl/test/claim/inert_lens_hygiene_witness_test.dag --function inert_lens_hygiene_has_no_unreached_modules --claim-run→trueWorker attestation
Closes #N— dashboard work item (adhoc-38030c50-415), not a GitHub issue.