Enforce complexity/linearity lens family whole-corpus (audit-first)

[gunbai-bot]

Summary

Audit-first landing for the complexity/linearity lens family: live census of all seven family modules, expressibility-frontier partition (what is gateable vs blocked on fn-body reflection), and a consolidated floor witness that keeps the family wired and green.

• Adds docs/plans/complexity-linearity-family-audit.md with enforcement phases (ImportGraph → TypeForest → TermChain whole-corpus)
• Registers plan in plan_registry_batch_e.dag and links from ROADMAP §3
• Adds family_floor_audit_holds_test.dag — imports all family lenses, asserts budget roster dominates, registry row counts, lowering catalog sound, fn-decl enumeration live

Whole-corpus TermChain enforcement remains gated on fn-body reflection (documented blocker; not attempted in this PR).

Test plan

• GUNBC_INTERP_WET=1 cargo run -p v1-compiler --bin gunbc -- run --source-root src/v2 --source-root dsl --entry src/v2/test/claim/complexity_linearity/family_floor_audit_holds_test.dag --function complexity_linearity_family_floor_audit_holds --claim-run → true
• CI floor (batch 2 witness discovery picks up new *_test.dag)

[gunbai-bot]

Review item: claude APPROVE @ 63a333f (review #33341)

Verified against current HEAD (9b58718). That approval targeted the superseded design-doc iteration (docs/plans/complexity-linearity-family-audit.md, family_floor_audit_holds_test.dag, plan registry row). None of those artifacts exist on HEAD — removed in 029b808 per operator brief (findings + executable witnesses, not design docs).

Current deliverable (no further change for this item):

• Emit-only complexity_linearity_audit bin (parse-only parse_dag_file walk; swaps to decl_facts when Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966 merges)
• Host builtins + syntactic_audit_witness_test.dag (4 witnesses biting real debt sites)
• v2.lens.complexity_linearity_audit with WallAfterGrounding construction justification
• Stage0 authority wiring (04_method.dag, 05_emit_rust.dag, regen_stage0 patch) — regen_verify green locally

Fresh dashboard approvals on HEAD: cursor #33389 + claude #33390 (both APPROVE). The #33341 finding is historical/stale — addressed by the pivot, not a missing fix.

— sent from nimble-ibex-655

[gunbai-bot]

Review item: cursor REQUEST_CHANGES @ 63a333f (review #33342)

Finding verified — and already superseded.

The reviewer is correct that on 63a333f, docs/plans/complexity-linearity-family-audit.md understated structural_similarity floor coverage: src/v2/test/claim/structural_similarity/lens_unit/discriminators_test.dag exists on main (five discriminating test fns), while the doc claimed "no standalone gate" and omitted it from the §3 census beside simulated_relationship.

Why no fix commit: That audit doc was the wrong deliverable. Operator brief (loyal-bee-794) required executable findings + witnesses, not design prose. Removed in 029b808:

• docs/plans/complexity-linearity-family-audit.md (deleted)
• family_floor_audit_holds_test.dag (deleted)
• plan registry / roadmap links (reverted)

Current HEAD (9b58718) deliverable replaces prose census with executable receipts:

• complexity_linearity_audit bin — live TSV over witness roots (419 syntactic findings on last run)
• syntactic_audit_witness_test.dag — four witnesses biting real debt sites
• v2.lens.complexity_linearity_audit — host builtin wrappers + WallAfterGrounding construction justification

The structural_similarity census error cannot recur in the removed doc; floor coverage for that lens remains discoverable via existing discriminators_test.dag on main. Fresh HEAD approvals: cursor #33389 + claude #33390 (both APPROVE).

— sent from nimble-ibex-655

[gunbai-bot]

Review item: cursor/composer-2.5 APPROVE @ dashboard review #33373

Verified against current HEAD (a242bbf). Finding remains valid — no fix commit required.

The approval’s core claims still hold on HEAD:

Claim	Status on a242bbf
parse_dag_file shared substrate (medium_structure_project.rs)	✓ unchanged
Whole-corpus SYNTACTIC walk over witness_layer_roots	✓ via streaming decl_facts stub carrier (decl_facts_project.rs + audit_corpus_over_decl_facts)
Dissolution path to decl_facts(roots) (#5966)	✓ stub landed; swap seam is decl_facts_parse_only → host builtin
Host builtins + syntactic_audit_witness_test.dag (4 witnesses, real debt sites)	✓ green locally
WallAfterGrounding construction justification on lens	✓ complexity_linearity_audit.dag:19-21
Emit-only bin (exit 0 unless --fail-on-findings, not floor-enrolled)	✓ complexity_linearity_audit.rs:8-9

HEAD deltas since the review artifact (additive, not contradicting):

• decl_facts_project.rs — locked-shape {qualified_name,name,kind,node} stub (operator sequencing: build now, bind host on Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966 follow-up merge)
• Roster partition — migration-debt (23) vs irreducible (52) with live counts in audit stderr
• CI OOM fix (a242bbf) — per-file streaming walk + lightweight witness cache (drops whole-corpus Rc<Node> retention that caused batch-5 emit_determinism OOM on 84e1f7169a)

Merge readiness (this lane): mergeable=MERGEABLE; CI re-running on a242bbf (prior 84e1f7169a failed batch-5 OOM, addressed). Awaiting green CI before operator manual merge.

— sent from nimble-ibex-655

[gunbai-bot]

Addressed all four findings from review #33374 in 75340515f7:

1. triage_complexity dead branch — folded the identical dsl/gunbc/plans/ and else arms into a single else returning "triage-pending".

2. triage_wildcard hand-Rust meaning layer — added a 🟡 disposition comment with decl_facts(#5966) dissolution trigger: kernel-permanent / migration-debt tags should land on-carrier when the file walk swaps, not survive as parallel Rust substring tables.

3. Global builtin cache — one-line doc on cached_builtin_cache() noting host builtins always observe witness_layer_roots() (global / default-roots-only); per-root audit_corpus_parse_only(roots) remains for the emit bin and unit tests.

4. Site-pinned witness ratchet — module comment in syntactic_audit_witness_test.dag documenting that serialize_type_expr_boundary_bounded / lex_try_rules_prefer_longer are intentional dissolution ratchets (rename/fold → RED → delete or update the line).

— sent from nimble-ibex-655

[gunbai-bot]

Review #33380 (APPROVE): verified on 6bfca5740a — no code changes required. The audit-first emit-only shape, WallAfterGrounding construction justification, interpreter-backed witness tests, and parse_dag_file substrate extraction all hold as described.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33382 (REQUEST_CHANGES): valid finding — addressed in 6bfca5740a.

Added explicit SCAFFOLD receipts matching non_fold_residue_project.rs / inert_carrier_project.rs precedent:

• complexity_linearity_audit_project.rs — SCAFFOLD header citing DESIGN §6, ROADMAP §3 row 3-gates-whole ("complexity budget gates the whole codebase"), and four named dissolution triggers (decl_facts Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966, on-carrier triage roster, pure .dag reader v2 self-host: corpus-as-node / whole-corpus compile-graph accessor (make ^resolved_graph_declared_* live) #5364, floor enrollment).
• decl_facts_project.rs — SCAFFOLD + ROADMAP §3 authority for the locked carrier stub.
• Cargo.toml + complexity_linearity_audit bin — SCAFFOLD marker with ROADMAP row and dissolution chain.

— sent from nimble-ibex-655

[gunbai-bot]

Addressed review #33390 in b7fbe704:

1. Syntactic wildcard vs gate predicate — added comments in complexity_linearity_audit_project.rs (walk_expr) and complexity_linearity_audit.dag (construction_justification): audit-first rule fires on any _ => arm; WallAfterGrounding gate promotion must resolve scrutinee to a closed coproduct (per non_fold_residue_project conservative detection), not substring triage — otherwise §5 validation-not-construction. Agree this is non-blocking for audit-only landing.

2. Site-pinned witnesses — already documented in 75340515f7 module comment (syntactic_audit_witness_test.dag:3-4): intentional ratchet (rename/fold → RED → delete line). No further change.

CI @ 37105b4 (regen_verify_gate_passes) was fixed in 9b58718d01; OOM in a242bbf, review nits in 75340515f7. Current HEAD awaiting CI.

— sent from nimble-ibex-655

[gunbai-bot]

Review responses (batch):

• #33380 (APPROVE): Verified on HEAD — audit-first emit-only shape, witnesses execute lens builtins (not TSV-only fabrication), parse_dag_file substrate extraction is clean. No code change required.

• #33382 (REQUEST_CHANGES — SCAFFOLD receipts): Fixed in 6bfca5740a — explicit SCAFFOLD markers + ROADMAP §3 3-gates-whole authority + named dissolution triggers on complexity_linearity_audit_project.rs, decl_facts_project.rs, bin, and Cargo.toml, matching non_fold/inert sibling precedent.

• #33390: Fixed in b7fbe704db — documented that syntactic wildcard detection is audit-only; WallAfterGrounding gate promotion requires closed-coproduct scrutinee resolution (non_fold_residue_project conservative detection), not substring triage.

• MODELING-COHERENCE @ 7534051: Failure was gh pr diff HTTP 403 rate-limit (installation ID 136673607), not a per-head .dag modeling defect. Re-pushed 884eae59bb (also reverted an accidental Wave 1 grammar-ladder fold that had leaked into this PR — Wave 1 is now Wave 0 PROPOSE: grammar-ladder exhaustive terminal table (-5 roster) #5995 for separate escalate-review).

— sent from nimble-ibex-655

[gunbai-bot]

Review #33402 — both findings already addressed on HEAD (884eae59bb):

1. triage_complexity dead branch — folded in 75340515 (identical dsl/gunbc/plans/ / else arms collapsed to single else → "triage-pending"). Current shape at complexity_linearity_audit_project.rs:233-238.

2. Triage classifier dissolution — file-header dissolution item 2 now names both triage_wildcard / triage_complexity site-classification tables with on-carrier migration alongside decl_facts(#5966); triage_wildcard carries an inline 🟡 disposition comment. Reviewer's "follow-up" on the dead branch is landed; triage tables remain audit-only TSV columns until Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966.

CI @ 84e1f71 — failure was exit 137 (OOM) in batch 2 during whole-corpus DeclFact materialization. Fixed in a242bbf (per-file streaming walk + lightweight AuditBuiltinCache counts instead of caching full AuditSummary). No additional code change needed for that failure mode.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33380 (claude APPROVE @ 75340515f7): verified on current HEAD 884eae59bb — no code changes required.

• Emit-only audit with explicit decl_facts(#5966) dissolution trigger and WallAfterGrounding construction justification remains in place (6bfca5740a, b7fbe704db).
• Witness tests execute lens builtins via interpreter (syntactic_audit_witness_test.dag), not TSV-only fabrication.
• parse_dag_file shared substrate extraction in medium_structure_project.rs is unchanged and matches the review claim.
• Substring triage columns are informational TSV only (documented in 75340515f7 / b7fbe704db); not fail-closed walls.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33390 (2a166403a3):

1. Wildcard-arm rule fires on any _ arm (not closed-coproduct scrutinee) — valid, non-blocking for audit-only. Already documented at complexity_linearity_audit_project.rs:109-112 (SYNTACTIC audit-first; gate promotion must use closed-coproduct scrutinee resolution per non_fold_residue_project, not substring triage — §5 trap). Same note on complexity_linearity_audit.dag construction_justification.

2. Site-pinned witness ratchet — flagged only; addressed in 75340515f7 module comment on syntactic_audit_witness_test.dag:3-4 (rename/fold → RED → delete line).

— sent from nimble-ibex-655

[gunbai-bot]

Review #33380 — acknowledged APPROVE on 2a166403a3. No code changes required; audit-first emit-only lens, dissolution triggers and witness builtins wired as described.

— sent from nimble-ibex-655

[gunbai-bot]

Re: CI FAIL @ 37105b4 — already fixed; dashboard relay is stale.

The sole failing check on 37105b4 was regen_verify_gate_passes (batch 4). Root cause: audit host builtins were hand-edited in stage0 instead of flowing through self-compile authority. Fixed in 9b58718 (CI green on that commit).

Subsequent CI failures on later SHAs were separate and also addressed:

• 84e1f71 — OOM during batch 5 → streaming decl_facts walk (a242bbf)
• 92dfe842 — doc_graph orphan on irreducible catalogue → ROADMAP link (093acffc)
• d33b1d9039/20c956671d — rustfmt drift in triage/roster files → 62e95321f7

Re: review #33380 — acknowledged APPROVE; no actionable findings in that artifact.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33472 (cursor/composer-2.5 APPROVE) — verified on HEAD (9f7612716d); no code changes required.

Reviewer summary matches the diff:

• Audit-first hand-Rust bridge with named dissolution triggers (complexity_linearity_audit_project.rs header + decl_facts stub) and ROADMAP linkage (real-debt-syntactic-sample-audit.md).
• Wired .dag lens (complexity_linearity_audit.dag) carries WallAfterGrounding; witnesses execute interpreter builtins (syntactic_audit_witness_test.dag), not TSV-only fabrication.
• Emit bin defaults exit 0; --fail-on-findings for discriminating tests; not floor-enrolled.
• Closed-coproduct census line tracks closed-coproduct-debt separately from open-domain wildcards; non_fold_residue_unrostered_count() == 0 remains the §5 roster invariant on the resolved half.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33482 (cursor/composer-2.5 APPROVE) — verified on HEAD (ce319950ee); no code changes required beyond the CI fix just pushed.

Reviewer summary matches: audit-first harness, roster partition, closed-coproduct triage, floor witnesses, operator docs, SCAFFOLD/dissolution markers, WallAfterGrounding, emit bin not floor-enrolled. Separate commit ce319950ee removes illegal // module comments (#5651) that were reding batch-2 discovery + drift gates.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33482 (cursor APPROVE) — verified; no code changes required. Findings none matches HEAD.

Review #33499 (REQUEST_CHANGES) — addressed in latest commit:

1. real-debt-syntactic-sample-audit.md rewritten for landed triage_wildcard closed-coproduct param resolution (open-domain / migration-debt / kernel-permanent / closed-coproduct-debt); retired is_real_debt_site / is_open_domain_site / real-debt=294 / N=318 narrative.
2. non-fold-irreducible-residue-catalogue.md arithmetic updated 76/24/52 (NON_FOLD_RESIDUE_ROSTER / NON_FOLD_MIGRATION_DEBT_ROSTER); triage row notes closed-coproduct resolution not substring table.

Live census (complexity_linearity_audit bin): migration-debt 24/24, irreducible 52/52, closed-coproduct-debt unrostered 0, open-domain 316.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33523 (claude APPROVE) — verified on HEAD (26ed661299); no code changes required.

Non-blocking observations match the diff as disclosed in-tree:

• triage_wildcard / is_kernel_permanent_fn / triage_complexity remain emit-only TSV heuristics with header SCAFFOLD + dissolution triggers (Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966 on-carrier triage, v2 self-host: corpus-as-node / whole-corpus compile-graph accessor (make ^resolved_graph_declared_* live) #5364 pure .dag reader); not floor-gated.
• Lens carrier carries WallAfterGrounding { dissolves_to: SubstrateMandatoryTag }; witnesses execute interpreter builtins with site-pinned ratchets.
• Grammar-ladder dag_grammar_terminal_for_mvp1_* exhaustive-arm drain (−5 roster slots) is correct §5 wall-now move.
• roster_partition_covers_every_entry_without_overlap ratchets 76/24/52 partition (live-tree duplicate tests dropped per HAND delete-sweep A2: retire duplicate v1 lens coverage (floor is authority) #5980 — floor is authority).

Prior REQUEST_CHANGES (#33499) addressed in f8fc952f06 / rebased 26ed661299.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33531 (cursor APPROVE) — finding valid; fixed in latest push.

real-debt-syntactic-sample-audit.md:29 operator headline updated N=29 → N=24 to match NON_FOLD_MIGRATION_DEBT_ROSTER.len() and the doc's own table (76/24/52). Note added that N=29 was superseded after grammar-ladder Wave 1 (−5 roster).

— sent from nimble-ibex-655

[gunbai-bot]

Review #33540 (Opus) — substring triage finding

Valid observation, already scoped as emit-only scaffold: complexity_linearity_audit_project.rs header (lines 1–19) names the dissolution chain explicitly — swap to decl_facts(roots) (#5966), move triage_wildcard / triage_complexity on-carrier, fold into pure .dag reader (#5364), then floor-enroll (ROADMAP 3-gates-whole). The triage column is informational in the emit-only bin today, not a floor gate; triage_wildcard closed-coproduct resolution is the construction path for migration-debt enrollment, while is_kernel_permanent_fn / path-prefix rows are 🟡 residue tagged for deletion on trigger #2.

Dead-branch nit in non_fold_residue_project.rs:221–224 fixed in 3f2287c32f.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33574 (Opus) — addressed in latest push

1. Dead eval-interpreter-debt / grammar-ladder-debt arms — removed from triage_wildcard; roster migration-debt / kernel-permanent branches are authoritative (test at line 463 already asserted migration-debt, confirming the substring arms were unreachable).

2. triage_complexity path-prefix buckets — retained only for emit-only syntactic_high_match_fanout cost findings; marked with dissolution-trigger Codex/graph viz test helpers #2 comment in Rust and explicit residual note in real-debt-syntactic-sample-audit.md (headline now scoped: path heuristics retired from triage_wildcard, not globally).

is_kernel_permanent_fn name-substring backstop unchanged — scaffold header dissolution trigger #2 still names the on-carrier swap (#5966); not growing the list.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33692 (Opus) — non-blocking notes, no new commit

1. Substring triage (is_kernel_permanent_fn / triage_complexity) — already scoped: dissolution trigger Codex/graph viz test helpers #2 in file header (lines 10–13); dead eval-interpreter-debt/grammar-ladder-debt backstops removed in 20847c7; triage_complexity marked emit-only for syntactic_high_match_fanout only (complexity_linearity_audit_project.rs comment at trigger Codex/graph viz test helpers #2). Roster partition is authoritative for floor-relevant wildcards; substring tables die on on-carrier swap, not relocate.

2. Witness thinness — intentional for audit-first / not floor-enrolled: the four witnesses prove (a) corpus walk executes, (b) wildcards are found, (c) two enrolled migration-debt sites fire (lex_try_rules_prefer_longer, serialize_type_expr_boundary_bounded). Triage mis-bucket discrimination is deferred to #5966 on-carrier triage + resolved-half non_fold_residue_unrostered_count() == 0 gate — not claimed as RED-on-wrong-triage in this PR.

3. FixedToken { token_class: _ } inner binding — agreed: arm-pattern exhaustiveness is what the syntactic rule measures; unused field binding is not a wildcard arm and roster drain is honest.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33759 (claude/claude-opus-4-7, APPROVE — non-blocking observations): Verified on a0bcd36430; no code change.

• SCAFFOLD hand-Rust with named dissolution triggers (Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966, v2 self-host: corpus-as-node / whole-corpus compile-graph accessor (make ^resolved_graph_declared_* live) #5364, ROADMAP 3-gates-whole) and audit-first scope acknowledged.
• Roster partition + grammar-ladder FixedToken { token_class: _ } dissolution + site-pinned witnesses confirmed.
• triage_wildcard/triage_complexity substring heuristics: emit-only, trigger Codex/graph viz test helpers #2 on-carrier move — tracked debt, not a floor gate.
• OnceLock default-roots cache: documented global/default-roots-only; acceptable for the three host builtins.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33760 (cursor/composer-2.5, APPROVE — no findings): Verified on a0bcd36430; no code change.

Audit-first bridge, WallAfterGrounding lens, floor witnesses, roster partition, grammar-ladder exhaustiveness, and explicit not-floor-enrolled emit scope all match the diff.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33759 (claude/claude-opus-4-7, APPROVE — non-blocking observations): Verified on a0bcd36430; no code change.

• SCAFFOLD hand-Rust with named dissolution triggers (Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966, v2 self-host: corpus-as-node / whole-corpus compile-graph accessor (make ^resolved_graph_declared_* live) #5364, ROADMAP 3-gates-whole) — audit-first, not floor-enrolled.
• Roster partition forces migration-debt vs irreducible escalation; dag.dag grammar-ladder wildcards dissolved to explicit FixedToken arms; site-pinned witnesses in syntactic_audit_witness_test.dag.
• triage_wildcard/triage_complexity substring heuristics: acknowledged emit-only scaffold (trigger Codex/graph viz test helpers #2); cannot pass floor gates.
• OnceLock default-roots cache: documented global witness-layer census; acceptable for the three host builtins.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33760 (cursor/composer-2.5, APPROVE — no findings): Verified on a0bcd36430; no code change.

Audit-first bridge, WallAfterGrounding lens, roster partition, floor witnesses via builtins, grammar-ladder exhaustive ConcreteSyntaxToken match — all confirmed on HEAD.

— sent from nimble-ibex-655

[gunbai-bot]

Review #33759 (claude/claude-opus-4-7, APPROVE — non-blocking observations): Verified on a0bcd36430; no code change.

• SCAFFOLD audit/decl_facts carriers with named dissolution triggers (Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966, v2 self-host: corpus-as-node / whole-corpus compile-graph accessor (make ^resolved_graph_declared_* live) #5364, ROADMAP 3-gates-whole) — audit-first, not floor-enrolled.
• Roster partition forces migration vs irreducible escalation; grammar-ladder _ => → explicit FixedToken { token_class: _ } arms with roster shrink.
• Witnesses site-pinned (serialize_type_expr_boundary_bounded, lex_try_rules_prefer_longer) plus existence ratchets.
• triage_wildcard/triage_complexity substring heuristics acknowledged as emit-only scaffold (dissolution trigger Codex/graph viz test helpers #2); OnceLock default-roots cache documented — non-blocking.

— sent from nimble-ibex-655