Skip to content

Relocate NetworkLocality family to product/network_topology.dag - #5909

Merged
briansrls merged 2 commits into
mainfrom
session/eager-pike-543
Jun 28, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/eager-pike-543

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jun 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Makes product.network_topology self-hosting for the network locality vocabulary relocated from compute_fabric per the connector migration plan. Defines inline:

  • NetworkLocality (+ variants)
  • NetworkAddressability
  • NetworkEgressClass
  • LatencyClass
  • NetworkInterface

Leaf consumers repointed:

  • dsl/gunbc/fleet_intent_network.dag
  • dsl/test/claim/access_iam_validation_test.dag

compute_fabric.dag and all hub files left untouched.

Test plan

  • Compile-clean gate: gunbc compile --source-root dsl --source-root src/v2 --dependency-pool-index primary-precedence --target rust → 622 files, 0 diagnostics
  • access_iam_validation_test.dag witness tests pass
  • fleet_intent_network_witness_test.dag witness tests pass

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review June 28, 2026 18:58
@briansrls
briansrls force-pushed the session/eager-pike-543 branch from 53d47a1 to 9f5d306 Compare June 28, 2026 19:00
@gunbai-bot
gunbai-bot Bot marked this pull request as draft June 28, 2026 19:00
Make network_topology self-hosting: define NetworkLocality,
NetworkAddressability, NetworkEgressClass, LatencyClass, and
NetworkInterface inline. Repoint leaf consumers (fleet_intent_network,
access_iam_validation_test). compute_fabric.dag and hub files untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot gunbai-bot Bot changed the title Relocate NetworkLocality into product network_topology and repoint consumers per migration plan Relocate NetworkLocality family to product/network_topology.dag Jun 28, 2026
@briansrls
briansrls force-pushed the session/eager-pike-543 branch from 9f5d306 to 02ae4b6 Compare June 28, 2026 19:02
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review June 28, 2026 19:02
Branch is current with origin/main (no conflicts). Dashboard was
reporting stale head 77b2418 from pre-correction history.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Response to REQUEST_CHANGES (duplicate authority)

The finding is accurate as a steady-state §3 read, but the requested fix (delete the type rows from compute_fabric.dag) is out of scope for this leaf PR by explicit migration sequencing from the hub manager (vivid-wren-440).

What this PR does (leaf slice)

Per the compute_fabric connector vocabulary relocation plan, this is a staged leaf relocation:

  1. network_topology.dag becomes self-hosting — removes import product.compute_fabric { NetworkLocality, … } and defines the network vocabulary inline.
  2. Leaf consumers repointed — fleet_intent_network.dag, access_iam_validation_test.dag now import from product.network_topology.
  3. compute_fabric.dag intentionally untouched — hub serial PR owns deletion/re-export there; touching it from this leaf PR would conflict with parallel hub work (fleet_intent.dag, ci_fleet.dag, etc. are explicitly off-limits here).

Current consumer split (transient, not permanent)

Consumer Authority after this PR
network_topology.dag, fleet_intent_network.dag, access_iam_validation_test.dag product.network_topology
Hub files (fleet_intent.dag, ci_fleet.dag, fleet_container.dag, …) still product.compute_fabric (unchanged)

No file imports NetworkLocality from compute_fabric anymore; the remaining compute_fabric rows are used only by hub-internal types (ExecutionSurface.network, NetworkRequirement, etc.) until the hub serial PR deletes them.

Why not delete from compute_fabric.dag here?

Deleting the upstream rows in the same PR would require either:

  • editing hub files that still reference compute_fabric's copy (forbidden in this leaf), or
  • leaving hub files broken against a compute_fabric that no longer declares those types.

Both violate the agreed sequencing: leaf PR lands new home + repoints leaf consumers; hub PR removes originals and repoints hub consumers; final connector PR lands the slim compute_fabric.

The transient duplication is the deliberate scaffold state — same pattern as other RELOCATE rows in the migration tracking sheet — not a permanent fork.

Dissolution trigger

Deletion of NetworkLocality/NetworkAddressability/NetworkEgressClass/LatencyClass/NetworkInterface from compute_fabric.dag (and hub consumer repoint) is tracked as a separate hub serial slice, not this leaf.

— sent from eager-pike-543

@briansrls
briansrls merged commit ac6250e into main Jun 28, 2026
2 checks passed
@briansrls
briansrls deleted the session/eager-pike-543 branch June 28, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant