Skip to content

Create extdeps/gpu/types.dag; add MemoryKind/MemoryFacts to extdeps/memory/types.dag - #5906

Merged
briansrls merged 2 commits into
mainfrom
session/eager-ram-309
Jun 28, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/eager-ram-309

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add dsl/extdeps/gpu/types.dag with GpuFacts, AcceleratorFacts, and supporting GPU capability types (GpuComputeCapability, GpuRuntime, gpu_compute_capability_sm_label) relocated from product.compute_fabric.
  • Add MemoryKind and MemoryFacts to dsl/extdeps/memory/types.dag as the single-authority home for memory fact vocabulary.

These are the extdeps authority homes for compute_fabric vocabulary relocation; consumers can migrate imports in follow-on work.

Test plan

  • gunbc compile --source-root dsl --target rust — no errors in new/modified modules
  • Parent session wires compute_fabric and witness imports to the new extdeps homes

Made with Cursor

@gunbai-bot
gunbai-bot Bot marked this pull request as draft June 28, 2026 18:47
…emory/types.dag

Relocate GPU and memory fact vocabulary to extdeps authority homes and repoint
extdeps_round2_grounding_witness_test to the new modules. compute_fabric and hub
files untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot force-pushed the session/eager-ram-309 branch from 86ceb20 to 0a6d52b Compare June 28, 2026 18:49
@gunbai-bot gunbai-bot Bot changed the title extdeps: GpuFacts/AcceleratorFacts + MemoryKind/MemoryFacts authority homes Create extdeps/gpu/types.dag; add MemoryKind/MemoryFacts to extdeps/memory/types.dag Jun 28, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review June 28, 2026 18:49
…copy debt.

Named SCAFFOLD + dissolve-on triggers document the intentional interim duplicate
with product.compute_fabric until the connector PR consolidates (leaf PR scope
forbids touching compute_fabric or hub files).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Review response (parallel definitions)

Finding verified: GpuRuntime, GpuComputeCapability, GpuCapabilityLabelOutcome, gpu_compute_capability_sm_label, GpuFacts, AcceleratorFacts, MemoryKind, and MemoryFacts still exist in product.compute_fabric.dag alongside the new extdeps homes.

Why not option (a) in this PR: Parent manager scope (vivid-wren-440, serial hub migration) explicitly forbids touching compute_fabric.dag or any hub file from this leaf PR. Deleting the compute_fabric copies here would conflict with the in-flight hub serial PR and the final connector PR that re-models compute_fabric as the thin need↔opportunity connector.

Fix applied — option (b): Added named SCAFFOLD + dissolve-on: debt carriers:

  • gpu_types_compute_fabric_parallel_copy_debt in dsl/extdeps/gpu/types.dag
  • memory_types_compute_fabric_parallel_copy_debt in dsl/extdeps/memory/types.dag

Both name the bounded trigger: product.compute_fabric connector PR deletes local copies and imports from extdeps.

Consumer migration in this PR: extdeps_round2_grounding_witness_test.dag already repointed to the extdeps homes (one witness consumer; hub files remain on compute_fabric imports until the hub serial PR).

gpu_compute_capability_sm_label dispatch: Copied verbatim from the existing compute_fabric shape (not a new fork). Vendor-table dissolution is separate debt; this PR does not harden a new pattern.

Compile-clean on HEAD: 623 files, 0 diagnostics.

— sent from eager-ram-309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant