Skip to content

Share one empty Rc<Vec<Rc<Node>>> singleton across Node list-fields (-43.7 MiB / -11.7% whole-tree compile RSS) #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 1 commit into from
Jun 27, 2026
Merged

Share one empty Rc<Vec<Rc<Node>>> singleton across Node list-fields (-43.7 MiB / -11.7% whole-tree compile RSS) #5878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/v1/stage0/src/v1_compiler_dag_collect_support.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,10 @@ mod fingerprint_tests {
params: Rc::new(params),
inferred: None,
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down
8 changes: 4 additions & 4 deletions src/v1/stage0/src/v1_compiler_emit_rust.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,15 +1474,15 @@ pub fn type_variable_node(id: String) -> Rc<Node> {
name: "".to_string(),
span: make_span(0, 0),
ident_span: None,
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::TypeVariable { id: id })),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down
160 changes: 80 additions & 80 deletions src/v1/stage0/src/v1_compiler_infer.rs
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions src/v1/stage0/src/v1_compiler_infer_method.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ pub fn type_variable_node(id: String) -> Rc<Node> {
name: "".to_string(),
span: make_span(0, 0),
ident_span: None,
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::TypeVariable { id: id })),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down
50 changes: 25 additions & 25 deletions src/v1/stage0/src/v1_compiler_infer_patterns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ pub fn synthesize_optional_present_variant(scrut: Rc<Node>) -> Rc<Node> {
name: "value".to_string(),
span: scrut.span.clone(),
ident_span: Some(kernel_span("value".to_string())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved { node: inner })),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -101,13 +101,13 @@ pub fn synthesize_optional_present_variant(scrut: Rc<Node>) -> Rc<Node> {
ident_span: Some(kernel_span("Present".to_string())),
children: Rc::new(vec![value_field]),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: None,
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -129,15 +129,15 @@ pub fn synthesize_witness_holds_variant(scrut: Rc<Node>) -> Rc<Node> {
name: "value".to_string(),
span: scrut.span.clone(),
ident_span: Some(kernel_span("value".to_string())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved { node: inner })),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -151,13 +151,13 @@ pub fn synthesize_witness_holds_variant(scrut: Rc<Node>) -> Rc<Node> {
ident_span: Some(kernel_span("Holds".to_string())),
children: Rc::new(vec![value_field]),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: None,
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -174,15 +174,15 @@ pub fn synthesize_witness_violates_variant(scrut: Rc<Node>) -> Rc<Node> {
name: "Diagnostic".to_string(),
span: scrut.span.clone(),
ident_span: Some(kernel_span("Diagnostic".to_string())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: None,
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -194,17 +194,17 @@ pub fn synthesize_witness_violates_variant(scrut: Rc<Node>) -> Rc<Node> {
name: "diagnostic".to_string(),
span: scrut.span.clone(),
ident_span: Some(kernel_span("diagnostic".to_string())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: diagnostic_type,
})),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -218,13 +218,13 @@ pub fn synthesize_witness_violates_variant(scrut: Rc<Node>) -> Rc<Node> {
ident_span: Some(kernel_span("Violates".to_string())),
children: Rc::new(vec![diagnostic_field]),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: None,
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down
48 changes: 24 additions & 24 deletions src/v1/stage0/src/v1_compiler_infer_resolve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ pub fn resolve_node_bounded(
ident_span: n.ident_span.clone(),
children: target_result.resolved.clone().children.clone(),
connective: target_result.resolved.clone().connective.clone(),
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: target_result.resolved.clone().inferred.clone(),
return_cardinality: n.return_cardinality.clone(),
uses: n.uses.clone(),
Expand All @@ -1149,7 +1149,7 @@ pub fn resolve_node_bounded(
ident_span: n.ident_span.clone(),
children: resolved_args.clone(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: expanded_node,
})),
Expand Down Expand Up @@ -1195,7 +1195,7 @@ pub fn resolve_node_bounded(
ident_span: n.ident_span.clone(),
children: substituted_children,
connective: decl.connective.clone(),
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: n.inferred.clone(),
return_cardinality: n.return_cardinality.clone(),
uses: n.uses.clone(),
Expand All @@ -1216,7 +1216,7 @@ pub fn resolve_node_bounded(
ident_span: n.ident_span.clone(),
children: resolved_args.clone(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: expanded_node,
})),
Expand Down Expand Up @@ -1290,17 +1290,17 @@ pub fn resolve_node_bounded(
name: key_param_name,
span: key_child_node.span.clone(),
ident_span: key_child_node.ident_span.clone(),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: key_resolved,
})),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand All @@ -1312,17 +1312,17 @@ pub fn resolve_node_bounded(
name: val_param_name,
span: val_child_node.span.clone(),
ident_span: val_child_node.ident_span.clone(),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: val_resolved,
})),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down Expand Up @@ -1384,17 +1384,17 @@ pub fn resolve_node_bounded(
name: el_param_name,
span: child_node.span.clone(),
ident_span: child_node.ident_span.clone(),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::Resolved {
node: el_resolved,
})),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down Expand Up @@ -1650,15 +1650,15 @@ pub fn resolve_optional_node(
name: tv.clone(),
span: kernel_span(tv.clone()),
ident_span: Some(kernel_span(tv.clone())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::TypeVariable { id: tv.clone() })),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down Expand Up @@ -2955,17 +2955,17 @@ pub fn resolve_item_types(item: Rc<Node>, env: Rc<TypeEnv>, module_name: String)
name: tp_name.clone(),
span: kernel_span(tp_name.clone()),
ident_span: Some(kernel_span(tp_name.clone())),
children: Rc::new(vec![]),
children: crate::v1_std_core::empty_node_list(),
connective: Connective::NoConnective,
params: Rc::new(vec![]),
params: crate::v1_std_core::empty_node_list(),
inferred: Some(Rc::new(InferredNode::TypeVariable {
id: tp_name.clone(),
})),
return_cardinality: Cardinality::Required,
uses: Rc::new(vec![]),
uses: crate::v1_std_core::empty_node_list(),
body: None,
transport: None,
properties: Rc::new(vec![]),
properties: crate::v1_std_core::empty_node_list(),
type_annotation: None,
is_self_recursive: false,
has_non_tail_self_call: false,
Expand Down
Loading