Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b0f4150
WIP: URI de-fork (ROW3): migrate URI string handling to a grounded ex…
briansrls Jun 25, 2026
2039075
URI de-fork (ROW3): migrate URI string handling to grounded extdeps/u…
briansrls Jun 25, 2026
d473a37
Fix uri_grounding_witness_test: remove invalid type annotation in let…
briansrls Jun 25, 2026
9353bab
WIP: URI de-fork (ROW3): migrate URI string handling to a grounded ex…
briansrls Jun 25, 2026
9a7c46b
Drop unused NonEmptyStr import from uri_grounding_witness_test
briansrls Jun 25, 2026
f04e244
WIP: URI de-fork (ROW3): migrate URI string handling to a grounded ex…
briansrls Jun 25, 2026
4515020
Fix uri_grounding_witness_test: remove RestTransportConfig (unrostere…
briansrls Jun 25, 2026
02ea2ef
WIP: URI de-fork (ROW3): migrate URI string handling to a grounded ex…
briansrls Jun 25, 2026
090065a
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 25, 2026
23e93eb
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 26, 2026
ed20737
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 26, 2026
ba7222f
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 26, 2026
e98ccc4
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 26, 2026
f8f6b0d
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 26, 2026
e64f7e6
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 27, 2026
144fffe
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 27, 2026
5657e0c
Merge remote-tracking branch 'origin/main' into session/bold-dove-644
briansrls Jun 27, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dsl/ctrl/code_change_workflow.dag
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import ctrl.process_algebra { ProcessNodeId }
import ctrl.pr_digests { MergeReadinessVerdict, Ready, NotReady }
import ctrl.review_verdict { MergeReadinessTally }
import extdeps.github.pulls { PullRequest, Open, Closed }
import std.types { CommitSha, NonEmptyStr, Timestamp, Url }
import std.types { CommitSha, NonEmptyStr, Timestamp }

type CodeChangeActiveStage
= ChangeOpen
Expand Down
4 changes: 2 additions & 2 deletions dsl/ctrl/pr_digests.dag
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ module ctrl.pr_digests

import extdeps.github.pulls { PullRequest, PullReview, ReviewComment }
import extdeps.github.errors { GitHubErrorShape }
import std.types { Url }
import std.types { NonEmptyStr }

type MergeReadinessVerdict
= Ready
| NotReady { first_reason: String, more_reasons: List<String> }

type AttachedUrl {
url: Url
url: NonEmptyStr
container: AttachedUrlContainer
context: AttachedUrlTextContext
}
Expand Down
4 changes: 2 additions & 2 deletions dsl/ctrl/review_verdict.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module ctrl.review_verdict

import std.types { ArtifactId, CommitSha, ContentHash, NonEmptyStr, Timestamp, Url }
import std.types { ArtifactId, CommitSha, ContentHash, NonEmptyStr, Timestamp }

type ReviewProvider
= OpenaiPro
Expand Down Expand Up @@ -99,7 +99,7 @@ type ReviewArtifact {
pr_number: Int

source_commit_sha: CommitSha?
source_url: Url?
source_url: NonEmptyStr?
body_hash: ContentHash?
body_text: String
observed_at: Timestamp?
Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/cloud/gcp/sts.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.cloud.gcp.sts

import std.types { Url, HttpMethod, AuthScheme }
import std.types { NonEmptyStr, HttpMethod, AuthScheme }
import extdeps.cloud.gcp.errors { GcpErrorShape, GcpOAuth2ErrorShape }
import extdeps.github.errors { GitHubErrorShape }

Expand Down Expand Up @@ -34,7 +34,7 @@ type MetadataRuntime {}

data metadata_runtime: MetadataRuntime = {}

data sts_endpoint: Url = "https://sts.googleapis.com/v1/token"
data sts_endpoint: NonEmptyStr = "https://sts.googleapis.com/v1/token"

data default_grant_type: String = "urn:ietf:params:oauth:grant-type:token-exchange"

Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/git/git.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.git

import std.types { CommitSha, Email, FilePath, GitRef, Timestamp, Url }
import std.types { CommitSha, Email, FilePath, GitRef, NonEmptyStr, Timestamp }

import extdeps.external_authority { ExternalAuthority }
import extdeps.uri { Uri, Https }
Expand Down Expand Up @@ -28,7 +28,7 @@ type GitBranch {

type GitRemote {
name: String
url: Url
url: NonEmptyStr
fetch_refspec: String
}

Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/git/versioning.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.git.versioning

import std.types { Url }
import std.types { NonEmptyStr }
import std.integer { NonNegativeInt }
import std.algebra { Ordering, Equal, Greater }
import std.nat { nat_compare }
Expand Down Expand Up @@ -36,7 +36,7 @@ data git_2_0_release: GitReleaseVersion = {
patch: 0
}

data git_release_versioning_spec_url: Url = "https://git-scm.com/docs/BreakingChanges.html"
data git_release_versioning_spec_url: NonEmptyStr = "https://git-scm.com/docs/BreakingChanges.html"

type GitVersionConstraint = VersionConstraint where brand("GitVersionConstraint")

Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/github/checks.dag
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module extdeps.github.checks

import extdeps.github.github { default_api_base, default_per_page }
import std.types { CommitSha, Timestamp, Url }
import std.types { CommitSha, NonEmptyStr, Timestamp }
import extdeps.github.errors { GitHubErrorShape }
import std.credentials { EnvVar }
import extdeps.external_authority { ExternalAuthority }
Expand Down Expand Up @@ -104,7 +104,7 @@ type CheckRun {
started_at: Timestamp?
completed_at: Timestamp?
output: CheckOutput
html_url: Url
html_url: NonEmptyStr
}

type CheckRunList {
Expand Down
3 changes: 1 addition & 2 deletions dsl/extdeps/github/errors.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module extdeps.github.errors

import std.types { Url }
import extdeps.external_authority { ExternalAuthority }
import extdeps.uri { Uri, Https }

Expand All @@ -13,7 +12,7 @@ data extdeps_external_authority_anchor: ExternalAuthority = ExternalAuthority {

type GitHubErrorShape {
message: String
documentation_url: Url?
documentation_url: String?
}

data github_error_example: GitHubErrorShape = {
Expand Down
6 changes: 3 additions & 3 deletions dsl/extdeps/github/gists.dag
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module extdeps.github.gists

import extdeps.github.github { GitHubUser, default_api_base }
import std.types { Timestamp, GistId, Url, HttpMethod, AuthScheme }
import std.types { Timestamp, GistId, NonEmptyStr, HttpMethod, AuthScheme }
import extdeps.github.errors { GitHubErrorShape }

import extdeps.external_authority { ExternalAuthority }
Expand Down Expand Up @@ -29,7 +29,7 @@ type Gist {
owner: GitHubUser
created_at: Timestamp
updated_at: Timestamp
html_url: Url
html_url: NonEmptyStr
}

service github.Gist {
Expand All @@ -53,7 +53,7 @@ service github.Gist {
}
output {
id: GistId
html_url: Url
html_url: NonEmptyStr
}
transport rest {
method: POST,
Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/github/github.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.github.github

import std.types { Timestamp, Url }
import std.types { NonEmptyStr, Timestamp }

import extdeps.external_authority { ExternalAuthority }
import extdeps.uri { Uri, Https }
Expand Down Expand Up @@ -49,7 +49,7 @@ type Pagination {

type GitHubPermission = PermRead | PermWrite | PermAdmin

data default_api_base: Url = "https://api.github.com"
data default_api_base: NonEmptyStr = "https://api.github.com"

data default_per_page: Int = 30

Expand Down
14 changes: 7 additions & 7 deletions dsl/extdeps/github/pulls.dag
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module extdeps.github.pulls

import extdeps.github.github { GitHubUser, default_api_base, default_per_page }
import std.types { CommitSha, FilePath, GitRef, Timestamp, Url, HttpMethod, AuthScheme }
import std.types { CommitSha, FilePath, GitRef, NonEmptyStr, Timestamp, HttpMethod, AuthScheme }
import extdeps.github.errors { GitHubErrorShape }
import std.credentials { CredentialSource, EnvVar }
import std.serialization { WireFormat, Text }
Expand Down Expand Up @@ -38,7 +38,7 @@ type PullRequest {
title: String
body: String?
state: PullRequestState
html_url: Url
html_url: NonEmptyStr
user: GitHubUser
head: PullRequestRef
base: PullRequestRef
Expand All @@ -50,7 +50,7 @@ type PullRequest {

type IssueComment {
id: Int
html_url: Url
html_url: NonEmptyStr
body: String
created_at: Timestamp
}
Expand Down Expand Up @@ -150,7 +150,7 @@ service github.Pulls {
}
output {
id: Int from "id"
html_url: Url from "html_url"
html_url: NonEmptyStr from "html_url"
}
transport rest {
method: POST,
Expand Down Expand Up @@ -202,7 +202,7 @@ service github.Pulls {
}
output {
id: Int from "id"
html_url: Url from "html_url"
html_url: NonEmptyStr from "html_url"
}
transport rest {
method: POST,
Expand Down Expand Up @@ -246,7 +246,7 @@ type PullReview {
body: String
state: ReviewState
commit_id: CommitSha
html_url: Url
html_url: NonEmptyStr
}

data structural_coverage_gap_github_pull_review_response_residual: List<CoverageClosureEntry> = [
Expand All @@ -271,5 +271,5 @@ type ReviewComment {
line: Int?
original_line: Int?
body: String
html_url: Url
html_url: NonEmptyStr
}
4 changes: 2 additions & 2 deletions dsl/extdeps/github/workflow_runs.dag
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module extdeps.github.workflow_runs

import extdeps.github.github { GitHubUser, default_api_base, default_per_page }
import extdeps.github.errors { GitHubErrorShape }
import std.types { CommitSha, Timestamp, Url }
import std.types { CommitSha, NonEmptyStr, Timestamp }
import std.credentials { EnvVar }
import extdeps.external_authority { ExternalAuthority }
import extdeps.uri { Uri, Https }
Expand Down Expand Up @@ -48,7 +48,7 @@ type WorkflowRun {
conclusion: WorkflowRunConclusion?
workflow_id: Int
run_number: Int
html_url: Url
html_url: NonEmptyStr
created_at: Timestamp
updated_at: Timestamp
}
Expand Down
4 changes: 2 additions & 2 deletions dsl/extdeps/transports/rest.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.transports.rest

import std.types { HttpMethod, Url }
import std.types { HttpMethod }
import std.serialization { WireFormat }
import std.fidelity { TransportFidelity }
import extdeps.external_authority { ExternalAuthority }
Expand All @@ -16,7 +16,7 @@ data extdeps_external_authority_anchor: ExternalAuthority = ExternalAuthority {
data rest_transport_fidelity: TransportFidelity = TransportFidelity { depth: L, hermetic: false }

type RestTransportConfig {
base_url: Url
base_url: Uri
auth_token: String?
auth_header: String?
headers: Map<String, String>
Expand Down
2 changes: 1 addition & 1 deletion dsl/extdeps/uri.dag
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module extdeps.uri

import std.types { NonEmptyStr, Url }
import std.types { NonEmptyStr }

type UriScheme
= Http
Expand Down
6 changes: 3 additions & 3 deletions dsl/gunbc/digest_render.dag
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ module gunbc.digest_render

import extdeps.github.pulls { PullRequest, PullReview, PullRequestState, ReviewState, Open }
import std.render { kv_pair, list_block }
import std.types { Url }
import std.types { NonEmptyStr }

type PullRequestDigestSubject {
number: Int
title: String
url: Url
url: NonEmptyStr
state: PullRequestState
draft: Bool
head_sha: String
Expand Down Expand Up @@ -117,7 +117,7 @@ fn render_pull_request_digest_line(view: PullRequestDigestView) -> String {
fn render_pull_request_digest_block(view: PullRequestDigestView) -> String {
let entries = [
kv_pair(key: "PR", sep: ": ", value: "#\{view.subject.number\} \{view.subject.title\}"),
kv_pair(key: "URL", sep: ": ", value: view.subject.url as String),
kv_pair(key: "URL", sep: ": ", value: view.subject.url),
kv_pair(key: "Base", sep: ": ", value: view.subject.base_ref),
kv_pair(key: "Head", sep: ": ", value: view.subject.head_sha),
kv_pair(key: "State", sep: ": ", value: render_pull_request_state(state: view.subject.state)),
Expand Down
12 changes: 6 additions & 6 deletions dsl/gunbc/workflow/types.dag
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ import std.types {
FilePath,
Milliseconds,
NonEmptyStr,
Timestamp,
Url
Timestamp
}
import extdeps.cloud.gcp.gcp { GcpProjectId, ServiceAccountEmail }
import extdeps.uri { Uri }

type ArtifactKind = Design | Review | Plan | CiReport
type AuthorSource = Llm | Human
Expand Down Expand Up @@ -49,7 +49,7 @@ type TrackedIssue {
title: String
body: String
stage: IssueLifecycleStage
url: Url?
url: NonEmptyStr?
author: String?
labels: List<String>
created_at: Timestamp?
Expand Down Expand Up @@ -113,7 +113,7 @@ type PipelineArtifact {
stage: IssueLifecycleStage
kind: ArtifactKind
content: String
url: Url?
url: NonEmptyStr?
}

type IssueState = Open | Closed
Expand Down Expand Up @@ -191,7 +191,7 @@ type ArtifactType

type ArtifactPayload
= Inline { body: String }
| BlobRef { uri: Url, size_bytes: Int }
| BlobRef { uri: Uri, size_bytes: Int }

type Artifact {
artifact_id: NonEmptyStr
Expand Down Expand Up @@ -240,7 +240,7 @@ type RuntimeProfile
type LaunchConfig {
worker_count: Int
drain_flag_path: String?
drain_flag_url: Url?
drain_flag_url: NonEmptyStr?
}

type InfraIntent {
Expand Down
2 changes: 0 additions & 2 deletions dsl/std/types.dag
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ type GistId = String
type Secret nominal_opaque = String
type SecretValue = Secret where non_empty

type Url = String

type SemVer = String
type NonEmptyStr = String where non_empty
type LanguageId = String where non_empty
Expand Down
4 changes: 2 additions & 2 deletions dsl/test/claim/code_change_workflow_witness_test.dag
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ import extdeps.github.pulls {
PullRequest, PullRequestRef, PullRequestState, Open, Closed,
}
import extdeps.github.github { GitHubUser, User }
import std.types { CommitSha, NonEmptyStr, Timestamp, Url }
import std.types { CommitSha, NonEmptyStr, Timestamp }

data witness_repo: NonEmptyStr = "gunb-ai/gunbc"
data witness_pr_url: Url = "https://github.com/gunb-ai/gunbc/pull/1"
data witness_pr_url: NonEmptyStr = "https://github.com/gunb-ai/gunbc/pull/1"
data witness_head_sha: CommitSha = "abc1234def5678901234567890abcd1234567890"
data witness_merged_at: Timestamp = "2026-06-18T01:00:00Z"
data witness_node: ProcessNodeId = "session-calm-swift-738"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module test.claim.extdeps_github_errors_url_grounding_witness

import extdeps.github.errors { GitHubErrorShape, github_error_example }
import std.types { Url }
import std.types { NonEmptyStr }

data sample_docs_url: Url = "https://docs.github.com/rest"
data sample_docs_url: NonEmptyStr = "https://docs.github.com/rest"

fn w_github_error_shape_documentation_url_grounded() -> Bool {
let row = GitHubErrorShape {
Expand Down
Loading