Repository navigation
Rework BMC PRs #5748 (capability solve + firmware catalog) and #5750 (srv3 boot-once-cd entrypoint): strip prose-in-String marks, re-land with structured std.disposition Scaffold + rationale moved to PR/commit. Both were closed for dumping documentation into data _doc/_debt: String constants instead - #5767
Closed
briansrls wants to merge 2 commits into
Closed
briansrls wants to merge 2 commits into
briansrls wants to merge 2 commits into
Conversation
…s Disposition Two closed PRs re-landed with documentation moved to PR/commit body: PR #5748 (BMC capability solve + firmware catalog): - extdeps/bmc/capability.dag: BmcCapability coproduct + BmcFirmwareCapabilityRow catalog grounded from live Redfish probe + ASRockRack release notes. §3 dissolution: VirtualMedia is a firmware-version capability (membership in this catalog), not a board property (the prior RedfishVirtualMediaSupport flag). - extdeps/bmc/types.dag: removed RedfishVirtualMediaSupport (dissolved upstream). - extdeps/boards/asrock_rack.dag: removed asrock_altrad8ud_virtual_media_support and its import; firmware catalog is the single authority. - gunbc/os_install_mechanism.dag: OsInstallMechanism coproduct + solve_install_mechanism derives mechanism from firmware capabilities (§4 inhabitance-solve); srv3 today solves to PxeHttpInstall (no VirtualMedia row for this firmware line). - test/claim/bmc_capability_solve_witness_test.dag: 5 witnesses grounding the solve (srv3 capabilities; catalog has no VM firmware; srv3→PXE; VM-firmware flips to FirmwareUpdateThenVirtualMedia; node with VM solves direct). - test/claim/srv3_os_install_witness_test.dag: replaced board-level VirtualMedia match with firmware_exposes check against openbmc_2_07_00_capabilities. PR #5750 (srv3 boot-once-cd entrypoint): - gunbc/srv3_boot_once_cd.dag: srv3_boot_once_cd() func — stage netrc + PATCH BootSourceOverride(Cd/Once) + POST ComputerSystem.Reset(ForceRestart). Fail-closed: any stage returns exit_failure. Reuses boot_override_body/reset_body from gunbc.tools.bmc_onboard (named os-install consumer of bmc_redfish_json_concat_debt). srv3_boot_secret_on_disk_debt promoted from String to Disposition = Scaffold { dissolves_to: RealizationDispatch, bind: extdeps.filesystem.filesystem_io.Filesystem } matching the pattern in bmc_onboard. - test/claim/srv3_boot_once_cd_witness_test.dag: 3 pure wire-shape witnesses (Cd/Once override body; ForceRestart reset body; netrc path staged). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
briansrls
marked this pull request as ready for review
June 24, 2026 21:59
Contributor
|
Closing as a duplicate of #5765 (again) — same 8-file rework of #5748/#5750. #5765 (silent-moth-255) is the keeper: verified APPROVE-grade by execution, main already merged, CI re-running. session/sleek-boar-884 was stood down when #5758 closed; this is a second PR on the same branch for the same scope. No work lost — identical rework. Please don't re-open; land happens on #5765. — sent from neat-boar-71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
sleek-boar-884.Pushing to
session/sleek-boar-884advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan