Repository navigation
Fix fleet main-red: jobserver anchor under §3 nickname → canonical extdeps_external_authority_anchor - #5685
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
Fix fleet main-red: jobserver anchor under §3 nickname → canonical extdeps_external_authority_anchor#5685gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
extdeps.ctrl.jobserver (new in #5663) declared its ExternalAuthority as `data ctrl_jobserver_authority`; the anchor projection (read_external_authority_anchor_from_items) reads ONLY a decl named `extdeps_external_authority_anchor`, so jobserver projected Absent → extdeps_external_authority_live_clean_tree_holds() = false → corpus_live_anchored_modules_clean / extdeps_external_authority_gate RED fleet-wide. Rename to the canonical single-authority decl name (the form every sibling uses, e.g. extdeps.git). No consumers; scheme+locator were already valid. By-execution: host test external_authority_live_clean_tree_holds_via_host green over fixed tree; full-tree projection-replica scan shows zero unanchored live modules. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded — closing as redundant. The jobserver anchor §3-fix this PR carried (ctrl_jobserver_authority → extdeps_external_authority_anchor) ALREADY LANDED ON MAIN via #5687 (5dbf840, commit msg: 'Fix main-red extdeps_external_authority_gate: jobserver anchor name'). dsl/extdeps/ctrl/jobserver.dag on this branch is now byte-identical to main; the only remaining diff vs main is stale-behind (#5682/#5664 not yet merged in). Nothing to merge. The anchor-completeness main-red (corpus_live_anchored_modules_clean / extdeps_external_authority_gate) is resolved on main. The separate #5682 ROADMAP drift is also resolved on main via #5688 (fe36970). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet main-red fix: jobserver anchor declared under a §3 nickname
Symptom (on
main). The anchor-completeness floor witnesses are RED on currentmain:corpus_live_anchored_modules_clean_holds/corpus_live_clean_tree_holds(=extdeps_external_authority_live_clean_tree_holds()) and theextdeps_external_authority_gate. One drifted module reds the gate fleet-wide, so every PR's floor batch-2 inherits this red.Root cause (by execution). The live anchor roster is
derived_extdeps_module_paths()=build_module_path_index()keys underextdeps.— a static source-tree index. For each module,project_external_authority_anchorreads only a data decl namedextdeps_external_authority_anchor(read_external_authority_anchor_from_items,extdeps_shape_transport_policy_project.rs:578).extdeps.ctrl.jobserver(added new in #5663) declared itsExternalAuthorityunder the nicknamectrl_jobserver_authorityinstead of the canonical single-authority name every sibling uses (e.g.extdeps.git). So it projectsAbsent→live_violation_module_paths()=["missing:extdeps.ctrl.jobserver"]→ gate red. It is the sole violation (verified: full-tree projection-replica scan overdsl/extdeps/**+src/v2/extdeps/**shows exactly one unanchored live module before this fix, zero after).This is a §3 single-authority violation (a nickname for a concept that already has one canonical name) — not #5670 (a v1-interpreter runtime service-op change that never touches the static roster).
Fix. Rename the decl to the canonical
extdeps_external_authority_anchor(1 line). No consumers — the decl was referenced only at its own declaration site. TheHttpsscheme +github.com/...locator were already valid; only the decl name the projection keys on was wrong.Verification (by execution).
external_authority_live_clean_tree_holds_via_host(runs the exact host projection over the fixed tree): green + roster count > 150.Follow-ups (not in this hotfix):
: ExternalAuthority) instead would make the nickname-violation unwritable, or a fail-closed authoring-time diagnostic should name it. Same name-keyed-fail-open family as the resolver collision wall.🤖 Generated with Claude Code