Repository navigation
Converge construction_justification onto std.disposition (Phase 1: typed dissolves_to + prose fold; interim, bind deferred) - #5647
Merged
Conversation
…ed rationale (37 marks) Cosmetic follow-up to claude-opus-4-7's non-blocking note on #5647. The fold already had a period before 'Grounding authority:' (the rationale's terminal sentence); this adds the missing one before 'Dissolves on:' so both folded clauses read as '. <Label>: ...'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Addressed the cosmetic note in 54e6aea: added the missing sentence separator before |
This was referenced Jun 23, 2026
briansrls
added a commit
that referenced
this pull request
Jun 23, 2026
…hub typed-projection snapshots (#5668) Fix 1 (§3 single-authority): #5647 added a std.disposition (dsl/) import into construction_justification.dag. 8 lens test files INLINED a forked `vec![workspace_root().join("src/v2")]` that omits dsl, so any subject importing a dsl module fails to resolve. Route all 8 to the existing `crate::helpers::v2_layer_roots()` (src/v2 + dsl), matching the 4 files that already do — collapsing all 12 sites onto one authority so no future lens re-trips. Fix 2 (#5644 typed restructure snapshots): #5644 modeled the pipe-delimited coverage closure DSL as the typed CoverageClosureFact/CoverageClosureEntry. Two pipeline snapshots asserted the old string form (`json_pending:user`, `declared_metadata:scopes`); the typed restructure renders these as serde JSON `{"field": "..."}`. Verified the typed projection is correct (typed `__rest_wire: Rc<PullReview>` deserialize + field projection assertions pass), so updated the residual-tracking assertions to the new typed form. Co-authored-by: Brian Searls <briansrls@gunb.ai> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 1 of converging the
construction_justificationmarks onto the existingstd.dispositiontyped carrier (CONVERGE, do not mint — bright-stag-194 owns the Disposition carrier; B-ruling).The
v2.lens.common.construction_justificationcarrier'sWallAfterGroundingvariant changes from two anemic prose Strings:to the typed mechanism half of the brief-target
Disposition::Scaffold:All 37
WallAfterGroundingmarks acrosssrc/v2/lens/*.dagare migrated:dissolves_totyped as the classifiedConstructionMechanism(SingleAuthority|RealizationDispatch|SubstrateMandatoryTag);grounding_authority+dissolve_onprose folded verbatim into the existingConstructionJustification.rationale: String(nothing lost);grounding_authorityString authority is dropped (§3 grounding upgrade: string authority → typed mechanism), removing the parallel-representation debt againstScaffold.bind.WallNow/RatchetForevermarks are untouched (they have nodissolve_on).Why this is an interim (marked in the carrier)
The brief target is
WallAfterGrounding { dissolve_on: Disposition }(a fullScaffold{dissolves_to, bind}).Scaffold.bindis mandatory and its type is in flux:DeclLocatoris being deleted and replaced by cool-carp-699's neutral locator (std.decl_ref.DeclarationRef), with the bind target widening to aScaffoldAuthoritycoproduct (decl + non-decl cases). Sobindis deferred to Phase 2 (on top of cool-carp's slice-3 core), anddissolves_tocarries straight into the eventualScaffold. The carrier carries an explicit INTERIM note so it is not read as the final shape.Phase-2 grounding input (the non-decl census)
Enumeration of the 37 marks: ~16 are clean decl targets; ~21 are non-decl authorities (future-capability / process-arc / concept-ref) that would be lossy if forced into a decl locator. This grounded bright-stag's ruling that the neutral locator is a coproduct over authority kinds, and the proposed
ScaffoldAuthorityshape sent to cool-carp.Tests
No functional consumer reads
ConstructionClass(pure authored data), so no behavior changes. Verified bygunbc compile --source-root src/v2 --source-root dsl(the floor's compile surface) — typechecks clean.