Repository navigation
Sync non-fold-residue roster to #5581 yaml rename (unblock main) - #5613
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
PR #5581 collapsed the yaml serializer into a render fold, renaming `emit_yaml_value` into two YamlValue-coproduct projectors (`block_sequence_element_doc`, `project_yaml_to_doc`) — both keep the same `match <YamlValue param> { ... _ => ... }` residue shape — but did not update the #5566 NON_FOLD_RESIDUE_ROSTER. Result: `non_fold_residue_no_unrostered_or_stale` has been RED on main (2 unrostered + 1 stale) and inherited by every PR's merge tree. Mechanical roster sync (the lens's own designed maintenance path): drop the stale `emit_yaml_value` entry, add the two renamed projectors as category-(a) un-migrated modeling. No lens-logic change. `live_tree_*` hygiene tests now pass (11 ok); fmt clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #5612, which already landed on main and dissolves the two yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
non_fold_residue_no_unrostered_or_stale(the #5566 fail-closed wall) is RED on main and inherited by every PR's merge tree — 2 unrostered + 1 stale:dsl/extdeps/formats/yaml.dag::block_sequence_element_doc,…::project_yaml_to_docdsl/extdeps/formats/yaml.dag::emit_yaml_valueRoot cause
PR #5581 ("collapse yaml/gitignore/runner_deploy serializers into one
std.layoutrender fold") renamedemit_yaml_valueinto the twoYamlValue-coproduct projectors above. Both retain the samematch <YamlValue param> { … _ => … }residue shape, so they are the same category-(a) un-migrated-modeling residue the roster already accepted foremit_yaml_value— but #5581 did not update the #5566 roster. Classic fleet-red unrostered-module desync.Fix
Mechanical roster sync — the lens's own designed maintenance path (its error message instructs "add to
NON_FOLD_RESIDUE_ROSTER"). Drop the stale entry, add the two renamed projectors. No lens-logic change.Verification
live_tree_no_unrostered_non_fold_residue+live_tree_residue_roster_has_no_stale_entriesnow pass (cargo test -p v1-compiler --lib non_fold_residue→ 11 ok, 0 failed).cargo fmt --all --checkclean.🤖 Generated with Claude Code