Repository navigation
Ban source comments — dsl/test + src/v2/test .dag (deletion-only) - #5542
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips all source comments (
//line +/* */block) fromdsl/test/**andsrc/v2/test/**.dagfiles. Part of the codebase-wide comment ban (sibling of pilot #5534): source comments are a parallel-ledger / dual-representation anti-pattern (DESIGN §2 no dual representation, §6 the mark on the carrier is the authority).Deletion-only, no logic changes. Applied the shared string-literal-aware stripper
scripts/strip_dag_comments.py(preserves//inside URL strings, multi-line strings, char literals). The few+lines are code lines that merely had a trailing comment removed — code is token-for-token identical (verifiedgit diff).Verification (by execution)
cargo build --release --bin gunbcgreen.--source-root src/v2 --source-root dsl --target rust): exactly 2 diagnostics, both the pre-existing intentionally-broken negative fixtures (layering_scan/dsl_extdeps_v4_exact/extdeps/plant.dag,layering_scan/parse_level_pre_resolve/std/plant.dag) — the baseline, not a regression. No other errors.test fndeclarations before == 224 after. (Raw "test fn" grep dropped 247→242 only because 5 were prose mentions inside deleted comments.)bind:provenance refs in test comments).🤖 Generated with Claude Code