Skip to content

main CI is failing - PTAL and fix #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gunbai-bot wants to merge 1 commit into from
Closed

main CI is failing - PTAL and fix #5326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions dsl/std/realization_width.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import std.measure {
hardware_thread_count,
hardware_thread_count_value,
}
import std.verification {
NanosecondDuration,
nanosecond_duration,
}
// nanosecond_duration is homed at the timing-authority consumer (std.verification),
// NOT std.measure — the scale-fixed nanosecond CHOICE lives where it is decided
// (DESIGN §3).
import std.verification { nanosecond_duration }
import std.pareto { AxisGoal, LowerIsBetter }
import std.realization_schedule {
Schedule,
Expand All @@ -39,14 +39,10 @@ import std.realization_schedule {
CostAccount,
CostBasis,
schedule_eq,
cost_account_measured,
cost_account_predicted_zero,
cost_account_time_count,
}
import std.realization_measurement { cost_account_measured_from_time }

fn cost_account_predicted_zero_nano() -> CostAccount<Nano> {
cost_account_predicted_zero()
}

fn int_min(a: Int, b: Int) -> Int {
if a < b { a } else { b }
Expand Down Expand Up @@ -78,25 +74,27 @@ fn width_fold_objective_goals() -> List<AxisGoal> {
[LowerIsBetter, LowerIsBetter]
}

type WidthBoundedRealization {
plan: RealizationPlan<Nano>
type WidthBoundedRealization<S> {
plan: RealizationPlan<S>
spawn_width: HardwareThreadCount
}

// Width is peripheral: the schedule topology is unchanged (§3 invariant).
fn width_bounded_realization(
plan: RealizationPlan<Nano>,
// Scale-agnostic over the carried cost ledger's time scale `<S>` (the plan itself
// names no scale; a consumer pins it, e.g. RealizationPlan<Nano>).
fn width_bounded_realization<S>(
plan: RealizationPlan<S>,
shard_count: Int,
hardware_threads: HardwareThreadCount
) -> WidthBoundedRealization {
) -> WidthBoundedRealization<S> {
WidthBoundedRealization {
plan: plan
spawn_width: bounded_host_spawn_width(shard_count: shard_count, hardware_threads: hardware_threads)
}
}

fn witness_width_fold_preserves_schedule_topology(
plan: RealizationPlan<Nano>,
fn witness_width_fold_preserves_schedule_topology<S>(
plan: RealizationPlan<S>,
shard_count: Int,
hardware_threads: HardwareThreadCount
) -> Bool {
Expand Down Expand Up @@ -139,9 +137,9 @@ fn shard_balance_slot_for_cost(cost: CostAccount<Nano>, baseline: CostAccount<Na

// RED guard (b): asymmetric measured costs must yield different slot assignments.
fn witness_measured_cost_affects_shard_balance() -> Bool {
let high = cost_account_measured_from_time(time: nanosecond_duration(count: 100))
let low = cost_account_measured_from_time(time: nanosecond_duration(count: 10))
let baseline = cost_account_predicted_zero_nano()
let high = cost_account_measured(time: nanosecond_duration(count: 100))
let low = cost_account_measured(time: nanosecond_duration(count: 10))
let baseline = cost_account_predicted_zero()
let left = shard_balance_slot_for_cost(cost: high, baseline: baseline)
let right = shard_balance_slot_for_cost(cost: low, baseline: baseline)
left != right
Expand Down
7 changes: 1 addition & 6 deletions dsl/test/claim/realization_width_witness_test.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import std.realization_schedule {
RealizationObjective,
Runnable,
RunnableSingleClaim,
CostAccount,
cost_account_predicted_zero,
}
import std.realization {
Expand All @@ -35,10 +34,6 @@ fn witness_threads_4() -> HardwareThreadCount {
hardware_thread_count(4)
}

fn synthetic_plan_total() -> CostAccount<Nano> {
cost_account_predicted_zero()
}

fn synthetic_plan() -> RealizationPlan<Nano> {
RealizationPlan {
target: "width-witness-target"
Expand All @@ -49,7 +44,7 @@ fn synthetic_plan() -> RealizationPlan<Nano> {
RunnableSingleClaim { entry: gate_entry, function: "rust_monolith_gate_passes" }
]
]
total: synthetic_plan_total()
total: cost_account_predicted_zero()
}
}

Expand Down