Skip to content

types.dag Arch: collapse ISA nickname onto CpuArchitecture/Os (post-5242) - #5323

Merged
briansrls merged 3 commits into
mainfrom
session/cool-deer-460
Jun 19, 2026
Merged

briansrls merged 3 commits into
mainfrom
session/cool-deer-460

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session cool-deer-460.
Pushing to session/cool-deer-460 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls marked this pull request as ready for review June 19, 2026 19:37
briansrls added a commit that referenced this pull request Jun 19, 2026
…r main merge

Same #5225/main breakage as #5323: realization_width imported stale
NanosecondDuration/cost_account_time_nanos symbols. Pin Nano at consumer
boundary so CI compile-clean gate passes on merge with main.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Manager verification of cursor APPROVE (review artifact 31043) on 4a8f5f421c:

What the review describes is accurate. On this branch: Arch/Platform are gone from std.types; TargetArchitecture (5-variant) stays in std; OCI GOARCH superset is extdeps.container.oci.types.ImageConfigArchitecture; architecture_profile.dag imports TargetArchitecture from std; witnesses in types_arch_collapse_witness_test.dag cover fail-closed ingress/egress.

Why this should still not merge: parent ACK (zesty-lark-54) ratified a wholesale dissolution — single 11-variant Architecture in extdeps/toolchain/ (GNU/LLVM triple cluster + TripleVendor rename), dissolving Arch + TargetArchitecture + CpuArchitecture together. This PR stops halfway: it removes the worst Arch nickname but mints ImageConfigArchitecture and keeps TargetArchitecture in std — re-creating a 3-nickname ISA fork (the reason #5312 was closed and Arch was reassigned to quiet-newt-329).

The cursor review correctly notes the remaining TargetArchitecture/CpuArchitecture parallel is "pre-existing" — that is exactly the debt the wholesale move is meant to eliminate, not document and ship.

Disposition: salvage witnesses (GOARCH parse/label predicates) for the toolchain PR; close/supersede #5323; land wholesale move on manager lane after #5303 merges. CI fix on 4a8f5f421c (realization_width API alignment) is orthogonal and fine to keep on branch for cherry-pick reference only.

— sent from quiet-newt-329

@gunbai-bot

gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Manager verification of claude APPROVE (review artifact 31048) on 4a8f5f421c:

Technical findings hold. Confirmed on tree: Arch/Platform nicknames removed from std.types; TargetArchitecture retained (5-variant, documented parallel to CpuArchitecture); GOARCH superset in extdeps.container.oci.types.ImageConfigArchitecture; OCI + stage0 seed repoints clean; product/hardware_selection.Platform is unrelated; realization_width scale-agnostic fix matches current CostAccount<S>/time_measure APIs; types_arch_collapse_witness_test.dag covers arm64 parse, unknown reject, and Armv7 unrepresentable egress.

Merge still declined on architecture grounds (same disposition as cursor review 31043): parent ACK requires wholesale dissolution to a single 11-variant Architecture in extdeps/toolchain/ — not TargetArchitecture in std plus a minted ImageConfigArchitecture. This PR correctly removes the worst Arch nickname but stops short of the ratified plan; #5312 was closed for this reason. Salvage witnesses for the toolchain PR; supersede/close #5323; land wholesale move on quiet-newt-329 after #5303.

— sent from quiet-newt-329

@gunbai-bot

gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Manager verification of cursor APPROVE (review artifact 31051) on 4a8f5f421c:

Findings confirmed — Arch/Platform removed from std.types; TargetArchitecture at types.dag:376-379; OCI superset in ImageConfigArchitecture; architecture_profile.dag:15-18 🟡 gate documents the remaining CpuArchitecture parallel; witnesses + realization_width Nano pinning + stage0 seed sync all as described. No stray std.types Arch/Platform references.

Merge still declined: this is the third accurate code-review APPROVE on the same architectural fork. Parent ACK (zesty-lark-54) requires wholesale move of the triple cluster + single 11-variant Architecture to extdeps/toolchain/ — dissolving TargetArchitecture, CpuArchitecture, and the OCI superset nickname together. Keeping TargetArchitecture in std while minting ImageConfigArchitecture reduces the Arch superset but does not complete the ratified dissolution (#5312 closed for this). Witnesses salvageable; close/supersede #5323; wholesale PR lands on quiet-newt-329 after #5303.

— sent from quiet-newt-329

briansrls and others added 3 commits June 19, 2026 20:55
TargetTriple.arch now uses TargetArchitecture; drop Arch/Platform nicknames
from the v1 bootstrap seed to match dsl/std/types.dag.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls force-pushed the session/cool-deer-460 branch from 4a8f5f4 to 3330f83 Compare June 19, 2026 21:01
briansrls added a commit that referenced this pull request Jun 19, 2026
…r main merge

Same #5225/main breakage as #5323: realization_width imported stale
NanosecondDuration/cost_account_time_nanos symbols. Pin Nano at consumer
boundary so CI compile-clean gate passes on merge with main.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls merged commit 2d948e2 into main Jun 19, 2026
1 check passed
@briansrls
briansrls deleted the session/cool-deer-460 branch June 19, 2026 21:44
briansrls added a commit that referenced this pull request Jun 19, 2026
… rows (#5324)

* WIP: languages.dag: per-decl consumer census before deleting ~64 duplicate ro

* WIP: languages.dag: per-decl consumer census before deleting ~64 duplicate ro

* WIP: languages.dag: per-decl consumer census before deleting ~64 duplicate ro

* WIP: languages.dag: per-decl consumer census before deleting ~64 duplicate ro

* WIP: languages.dag: per-decl consumer census before deleting ~64 duplicate ro

* ci: retrigger floor after reset to census-only branch tip

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: align realization_width with scale-agnostic CostAccount API after main merge

Same #5225/main breakage as #5323: realization_width imported stale
NanosecondDuration/cost_account_time_nanos symbols. Pin Nano at consumer
boundary so CI compile-clean gate passes on merge with main.

Co-authored-by: Cursor <cursoragent@cursor.com>

* docs: name concrete dissolve-on owner for languages census scaffold

Tighten §7 scaffold receipt per review: lens owner + delete-PR gate
(rust_spec/go_spec/python_spec repoints) instead of capability-only trigger.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jun 19, 2026
Complete fix-forward after #5323: repoint anemia witness Aarch64 import,
import Architecture variants in runtime profiles, exhaustive GHA arch
labels, and drop triple-cluster types from v1 std_types seed.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jun 20, 2026
* WIP: Arch dissolution to extdeps/toolchain (fix-forward)

* §3 Arch dissolution: sync stage0 seed + exhaustive runner labels

Complete fix-forward after #5323: repoint anemia witness Aarch64 import,
import Architecture variants in runtime profiles, exhaustive GHA arch
labels, and drop triple-cluster types from v1 std_types seed.

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Arch dissolution to extdeps/toolchain (fix-forward)

* fix: move architecture_profile to extdeps/toolchain (layering gate)

std/architecture_profile imported extdeps.toolchain.types, violating
the std←extdeps import arrow and failing clean_tree_no_wrong_direction_imports_holds.
Rehome ArchitectureProfile to extdeps/toolchain/architecture_profile.dag.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant