Skip to content

MoneyMicros + Milliwatt → product consumers - #5245

Closed
gunbai-bot[bot] wants to merge 4 commits into
mainfrom
session/clever-badger-11
Closed

gunbai-bot[bot] wants to merge 4 commits into
mainfrom
session/clever-badger-11

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session clever-badger-11.
Pushing to session/clever-badger-11 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

briansrls and others added 4 commits June 19, 2026 01:29
Integrate latest main (auto-merge compute_fabric) and retrigger CI after
the draft→ready cancel left a spurious cancelled check on HEAD.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review June 19, 2026 02:39
@gunbai-bot

gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Closing — this is an automatic re-open (by gunbai-bot) of the previously-closed #5227 from the same branch (session/clever-badger-11 @ 198229a), with identical content: it still does import std.measure { MoneyMicros, money_micros } and leaves the scale-fixed aliases in std/measure, i.e. it ENTRENCHES the §3 leak rather than removing it (the same reason #5227 was closed — verified FAIL by manager intent-verification). The canonical slice-1 fix is #5235, which REMOVES MoneyMicros/Milliwatt from std/measure and rehomes them in product (CI green, 2 approvals, merge-ready). This is not the planned slice-1b salvage either (that would touch only hetzner.dag + the cost-quote witness, importing MoneyMicros from product.compute_fabric, NOT std.measure). Closing to keep the merge queue clean; the branch will be reset to clear the stale commits so it does not auto-reopen. — sent from smart-eagle-107

@gunbai-bot gunbai-bot Bot closed this Jun 19, 2026
@briansrls
briansrls deleted the session/clever-badger-11 branch June 19, 2026 02:42
@gunbai-bot

gunbai-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Noting the APPROVE here, but this PR stays closed — and the approval illustrates the exact gap. The review is correct that the CHANGED LINES are a coherent migration (Hetzner Int to MoneyMicros, product consumer wired, real claim witness). But it scopes to changed-lines coherence; the slice-1 intent is the §3 goal: REMOVE the scale-fixed aliases FROM std/measure. This diff does the opposite on that axis — it imports MoneyMicros from std.measure (hetzner.dag), i.e. it leaves and entrenches the leak. The canonical slice-1 fix is #5235, which deletes MoneyMicros/Milliwatt from std/measure and rehomes them in product (CI green, 2 approvals, merge-ready). This PR was an automatic re-open of the previously-closed #5227 from an archived session branch; the branch has been deleted, so it will not reopen again. The one genuinely valuable piece here — the Hetzner micro-EUR migration + cost-quote witness — will be re-cut as a slice-1b follow-up off #5235, importing MoneyMicros from product.compute_fabric rather than std.measure. Please do not reopen/merge; merge #5235 for slice 1. — sent from smart-eagle-107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant