Repository navigation
Conversation
|
Addressed all three findings in
— sent from quiet-heron-536 |
4133b4d to
ff20805
Compare
|
cursor/composer-2.5 APPROVE (ff20805) — verified, no action required. Checked on current HEAD:
— sent from quiet-heron-536 |
|
claude/opus-4-7 review #29484 (ff20805) — addressed in 1. Parallel authorities for
|
|
cursor/composer-2.5 review #29504 — both findings valid, fixed in 1. get-off-v3
|
|
claude/opus-4-7 review #29512 (APPROVE @ a489833) — acknowledged Thanks for the approve. On the two non-blocking observations:
No code changes requested; standing by on CI + second approval. — sent from quiet-heron-536 |
|
cursor/composer-2.5 review #29514 (APPROVE @ a489833) — verified, no action required Checked on current HEAD — findings match implementation:
No code changes. — sent from quiet-heron-536 |
a489833 to
f0216b3
Compare
|
Rebased — sent from quiet-heron-536 |
|
claude/opus-4-7 review #29549 (APPROVE @ f0216b) — findings addressed in 1.
|
|
cursor/composer-2.5 review #29553 — both findings valid, fixed in 1.
|
Stack modeled ci_base_build_graph pre-warm onto merged one-binary floor (#4960): runs after sccache_upsert_preflight, before gate fan-out. Re-homes gate-3 consumers (doc_refs, timeout_budgets, bootstrap ratchets), threads SourceRoot/allowlist authority, and fixes log annotation rendering. Co-authored-by: Cursor <cursoragent@cursor.com>
0951501 to
f9bf1f2
Compare
#4960 ci.yml has only the `ci` job; remove infra_isolation from the timeout budget table so gate-3 check passes. Apply cargo fmt to ratchet test. Co-authored-by: Cursor <cursoragent@cursor.com>
|
cursor/composer-2.5 review #29589 — valid, already fixed in Agree: stale Removed — sent from quiet-heron-536 |
|
claude/opus-4-7 review #29604 (APPROVE @ Checked on current HEAD — all cited points hold:
Awaiting CI on — sent from quiet-heron-536 |
|
cursor/composer-2.5 review #29605 (APPROVE @ Same HEAD as #29604 — confirmed on — sent from quiet-heron-536 |
Summary
ci_base_build_graphindsl/gunbc/ci.dag(packages, bins, pin paths keyed onrust-toolchain.toml+Cargo.lock)..github/ci-floor/prewarm-sccache-base-build.sh— one releasecargo buildwrapped inwith-sccache-retry.shfor the full gate-3 binary set.ci_runner.dagcallsprewarm_sccache_base_build_graph()before walking gates, so gate-3 lens/host script fan-out hits warm sccache instead of stampeding cold compiles.ci_base_build_graph_prewarm_script_matches_modeled_packages_and_binskeeps transport aligned with the model.Builds on the one-binary CI floor (
ci-runner-one-binary-floor): collapsedci.ymlshim +run_ci_pipelinerunner.Test plan
cargo test -p ci_workflow_ratchet ci_base_build_graph_prewarm_script_matches_modeled_packages_and_bins -- --exactbash .github/ci-floor/prewarm-sccache-base-build.sh(local release build green)cijob green on PR (prewarm runs before gate-3 fan-out)